From: Fabian Frederick <fabf@skynet.be>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Joe Perches <joe@perches.com>,
linux-kernel@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH V3 RESEND] SYSV: logging update
Date: Sat, 20 Sep 2014 12:06:40 +0200 (CEST) [thread overview]
Message-ID: <297345823.196267.1411207600196.open-xchange@webmail.nmp.skynet.be> (raw)
In-Reply-To: <20140919160032.5863df2729d42df7c0b58825@linux-foundation.org>
> On 20 September 2014 at 01:00 Andrew Morton <akpm@linux-foundation.org> wrote:
>
>
> On Sat, 13 Sep 2014 23:12:36 +0200 Fabian Frederick <fabf@skynet.be> wrote:
>
> > -use current logging functions
> > -replace no level printk by pr_err
> > -add debug.c / sysv_err function to include sb->s_id
> > -use pr_fmt with standard KBUILD_MODNAME ": "
> > -use __builtin_return_address to display function name
> > logging format is now:
> > sysv: (sb->s_id) sysv_fill_super [sysv]: msg
>
> Is this patch tested?
Yes but looking at it again I wonder if __builtin_return_address is the best
function to use. %pf displays "sysv_fill_super [sysv]".
Maybe a trivial question but is there a way to have it simply display function
name ?
Of course I hope to have more feedback/testing to improve this patch.
Regards,
Fabian
prev parent reply other threads:[~2014-09-20 10:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-13 21:12 [PATCH V3 RESEND] SYSV: logging update Fabian Frederick
2014-09-19 23:00 ` Andrew Morton
2014-09-20 10:06 ` Fabian Frederick [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=297345823.196267.1411207600196.open-xchange@webmail.nmp.skynet.be \
--to=fabf@skynet.be \
--cc=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).