Re: [PATCH v2 0/5] platform/x86: int3472: don't use gpiod_toggle_active_low()

Bartosz Golaszewski
2023-09-28T18:40:19Z

On Thu, 28 Sept 2023 at 14:40, Hans de Goede <hdegoede@redhat.com> wrote:
>
> Hi All,
>
> Here is a v2 of Bartosz' "don't use gpiod_toggle_active_low()" series.
>
> New in v2:
> - Rework to deal with ACPI path vs gpiod_lookup.key differences:
> acpi_get_handle(path) -> acpi_fetch_acpi_dev(handle) -> acpi_dev_name(adev)
>
> Regards,
>
> Hans
>
>
> Bartosz Golaszewski (2):
> platform/x86: int3472: Add new
> skl_int3472_gpiod_get_from_temp_lookup() helper
> gpio: acpi: remove acpi_get_and_request_gpiod()
>
> Hans de Goede (3):
> platform/x86: int3472: Add new skl_int3472_fill_gpiod_lookup() helper
> platform/x86: int3472: Stop using gpiod_toggle_active_low()
> platform/x86: int3472: Switch to devm_get_gpiod()
>
> drivers/gpio/gpiolib-acpi.c | 28 -----
> .../x86/intel/int3472/clk_and_regulator.c | 54 ++--------
> drivers/platform/x86/intel/int3472/common.h | 7 +-
> drivers/platform/x86/intel/int3472/discrete.c | 101 ++++++++++++++----
> drivers/platform/x86/intel/int3472/led.c | 24 +----
> include/linux/gpio/consumer.h | 8 --
> 6 files changed, 93 insertions(+), 129 deletions(-)
>
> --
> 2.41.0
>

Thanks Hans, this looks good to me. I'd let it sit on the list for a
week. After that, do you want to take patches 1-4 and provide me with
another tag?

Bart