Re: [RFT PATCH 0/4] platform/x86: int3472: don't use gpiod_toggle_active_low()

Hans de Goede
2023-09-27T08:42:03Z

Hi,

On 9/27/23 10:38, Hans de Goede wrote:
> Hi Bartosz,
>
> On 9/26/23 16:59, Bartosz Golaszewski wrote:
>> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>>
>> gpiod_toggle_active_low() is a badly designed API that should have never
>> been used elsewhere then in the MMC code. And even there we should find
>> a better solution.
>>
>> Replace the uses of it in the int3472 driver with the good old temporary
>> lookup table trick. This is not very pretty either but it's the lesser
>> evil.
>
> I saw your previous proposal which added a new api to directly set
> the active_low flag, rather then toggle it.
>
> I intended to reply to that thread to say that I liked that approach,
> but I don't remember if I actually did reply.
>
> I wonder what made you abandon the new function to directly set
> the active-low flag on a gpio_desc?
>
> For the int3472 code that would work pretty well and it would
> be much cleaner then the temp gpio-lookup approach.

I missed that 4/4 removes acpi_get_and_request_gpiod(),
so I guess that this is not just only about removing gpiod_toggle_active_low()
but also about removing gpiod_toggle_active_low() ?

Regards,

Hans

>>
>> Bartosz Golaszewski (4):
>> platform/x86: int3472: provide a helper for getting GPIOs from lookups
>> platform/x86: int3472: led: don't use gpiod_toggle_active_low()
>> platform/x86: int3472: clk_and_regulator: use GPIO lookup tables
>> gpio: acpi: remove acpi_get_and_request_gpiod()
>>
>> drivers/gpio/gpiolib-acpi.c | 28 ------------------
>> .../x86/intel/int3472/clk_and_regulator.c | 22 ++++++--------
>> drivers/platform/x86/intel/int3472/common.c | 29 +++++++++++++++++++
>> drivers/platform/x86/intel/int3472/common.h | 9 ++++++
>> drivers/platform/x86/intel/int3472/led.c | 12 +++-----
>> include/linux/gpio/consumer.h | 8 -----
>> 6 files changed, 51 insertions(+), 57 deletions(-)
>>