Re: [RFT PATCH 2/4] platform/x86: int3472: led: don't use gpiod_toggle_active_low()

Andy Shevchenko
2023-09-26T15:27:07Z

On Tue, Sep 26, 2023 at 04:59:41PM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> Instead of acpi_get_and_request_gpiod() + gpiod_toggle_active_low(), use
> temporary lookup tables with appropriate lookup flags.

...

> + int3472->pled.gpio = skl_int3472_gpiod_get_from_temp_lookup(
> + int3472->dev, path, agpio->pin_table[0],
> + "int3472,privacy-led", polarity,
> + GPIOD_OUT_LOW);

Personally I found this style weird. I prefer to have longer line over
the split on the parentheses.

--
With Best Regards,
Andy Shevchenko