From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B92A8ECE566 for ; Thu, 20 Sep 2018 20:23:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 691F220877 for ; Thu, 20 Sep 2018 20:23:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="usbS7rAY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 691F220877 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388229AbeIUCIp (ORCPT ); Thu, 20 Sep 2018 22:08:45 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:36308 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727252AbeIUCIo (ORCPT ); Thu, 20 Sep 2018 22:08:44 -0400 Received: from avalon.localnet (dfj612ybrt5fhg77mgycy-3.rev.dnainternet.fi [IPv6:2001:14ba:21f5:5b00:2e86:4862:ef6a:2804]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 052AF1C86; Thu, 20 Sep 2018 22:23:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1537475010; bh=0xwDsFarEVhG7mFsvaNxI1p1QTZHrZ1+SYSh8xu5CjU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=usbS7rAYKTRmcbi4EdIq0dZlipH7ZA0c97e0sUYqnxiaJQLnJ6kRpmbQGl9RRU8sB S90ZoxTYuxAxZqsMo49XA3TfcCmPW3BqDegjmV1qo/KTeSl662qHUrL88t1+ZzDaXi YJ7apVgxNz0nC7+oGjUMJQ9pHAkgYSTHq2SnYbWw= From: Laurent Pinchart To: Ricardo Ribalda Delgado Cc: Pavel Machek , Sakari Ailus , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Hans Verkuil , devicetree@vger.kernel.org Subject: Re: [PATCH 3/4] [media] ad5820: DT new optional field enable-gpios Date: Thu, 20 Sep 2018 23:23:43 +0300 Message-ID: <2983018.WjSXnZMEY4@avalon> Organization: Ideas on Board Oy In-Reply-To: <1939782.bRt5jKDIiS@avalon> References: <20180920161912.17063-1-ricardo.ribalda@gmail.com> <20180920161912.17063-3-ricardo.ribalda@gmail.com> <1939782.bRt5jKDIiS@avalon> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, 20 September 2018 23:21:28 EEST Laurent Pinchart wrote: > Hi Ricardo, > > Thank you for the patch. > > On Thursday, 20 September 2018 19:19:11 EEST Ricardo Ribalda Delgado wrote: > > Document new enable-gpio field. It can be used to disable the part > > without turning down its regulator. > > > > Cc: devicetree@vger.kernel.org > > Signed-off-by: Ricardo Ribalda Delgado > > --- > > > > Documentation/devicetree/bindings/media/i2c/ad5820.txt | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/media/i2c/ad5820.txt > > b/Documentation/devicetree/bindings/media/i2c/ad5820.txt index > > 5940ca11c021..07d577bb37f7 100644 > > --- a/Documentation/devicetree/bindings/media/i2c/ad5820.txt > > +++ b/Documentation/devicetree/bindings/media/i2c/ad5820.txt > > > > @@ -8,6 +8,11 @@ Required Properties: > > - VANA-supply: supply of voltage for VANA pin > > > > +Optional properties: > > + > > + - enable-gpios : GPIO spec for the XSHUTDOWN pin. > > xshutdown is active-low, so enable is active-high. Should this be documented > explicitly, to avoid polarity errors ? Maybe something along the lines of > > - enable-gpios: GPIO spec for the XSHUTDOWN pin. Note that the polarity of > the enable GPIO is the opposite of the XSHUTDOWN pin (asserting the enable > GPIO deasserts the XSHUTDOWN signal and vice versa). Or alternatively you could name the property xshutdown-gpios, as explained in my (incorrect) review of 2/4. > > If specified, it will be > > + asserted when VANA-supply is enabled. > > That documents a driver behaviour, is it needed in DT ? > > > Example: > > ad5820: coil@c { > > > > @@ -15,5 +20,6 @@ Example: > > reg = <0x0c>; > > VANA-supply = <&vaux4>; > > > > + enable-gpios = <&msmgpio 26 GPIO_ACTIVE_HIGH>; > > }; -- Regards, Laurent Pinchart