From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751399AbXDLS7H (ORCPT ); Thu, 12 Apr 2007 14:59:07 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751450AbXDLS7H (ORCPT ); Thu, 12 Apr 2007 14:59:07 -0400 Received: from mx1.redhat.com ([66.187.233.31]:40752 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751328AbXDLS7D (ORCPT ); Thu, 12 Apr 2007 14:59:03 -0400 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 Directors: Michael Cunningham (USA), Charlie Peters (USA) and David Owens (Ireland) From: David Howells In-Reply-To: <5c49b0ed0704121123x341d10afxfdf6930b4b26417b@mail.gmail.com> References: <5c49b0ed0704121123x341d10afxfdf6930b4b26417b@mail.gmail.com> <20070412024938.27380.44677.patchbomb.py@localhost> <1273.1176375482@redhat.com> To: "Nate Diller" Cc: "Andrew Morton" , "Alexander Viro" , "Christoph Hellwig" , "Roman Zippel" , "Mikulas Patocka" , "David Woodhouse" , "Dave Kleikamp" , "Anton Altaparmakov" , "Evgeniy Dushistov" , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, reiserfs-dev@namesys.com Subject: Re: [PATCH 3/17] afs: convert afs_dir_get_page to read_kmap_page X-Mailer: MH-E 8.0; nmh 1.1; GNU Emacs 22.0.50 Date: Thu, 12 Apr 2007 19:57:23 +0100 Message-ID: <29898.1176404243@redhat.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Nate Diller wrote: > Hmmm you're right. Is your security work going into the next -mm? I don't know. Andrew hasn't said anything. Andrew? Are you waiting for it to go through DaveM's networking tree? > If so, I'll just re-base this cleanup patch on that ... at the very least I > want to get rid of afs_dir_put_page(). That's reasonable. > Also, did you consider passing the key pointer directly and modifying the > readpage actor to simply cast the pointer back, like > read_mapping_page(mapping, page, (struct file *)key)? It seems like a waste > to allocate a whole file struct on the stack just for the ->private field. There's one small problem with that... And that's filemap_nopage() (it passes vma->vm_file to readpage() unconditionally). Unless, of course, your patches fix that too... David