From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C420BC43334 for ; Wed, 22 Jun 2022 08:40:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355209AbiFVIkp (ORCPT ); Wed, 22 Jun 2022 04:40:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39830 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354745AbiFVIko (ORCPT ); Wed, 22 Jun 2022 04:40:44 -0400 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1FD29F7 for ; Wed, 22 Jun 2022 01:40:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655887243; x=1687423243; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=tl2qUZB6PuyGPDvcow6eu6mLNljNYkxedfCib16DPLI=; b=GrizN5JKNr2T2C9BDMQxLiRqSpplbaOkVt89SV5fURr9o8Wmp1rqoI1S N4k/2GaYtz6ubxuH9dUTOu+E2knMKUF7iSY9y1XsogpwtJRCdSkKyEykW kez6Q/VLz32PuA21YublkK0YBvhPp1j3JYzGWdAQjJHMI/gsdEFaom0wr KgGv5T0Y5wNCQRZ3vIcZo+iJkfccShEDObKTGbMcUzhlRpFK4g7FlKAH0 5WhkcSN065zhLX31T/F16Zj8V5lxzQIn8/R1uPLpd67qA7ZB7uy3QPANm 9aK6Dr5xq0Iw/xgrsdUoZ0E0NEpCZeWqawOL4frnxALt42UJ3TOVg85/K w==; X-IronPort-AV: E=McAfee;i="6400,9594,10385"; a="263391033" X-IronPort-AV: E=Sophos;i="5.92,212,1650956400"; d="scan'208";a="263391033" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jun 2022 01:40:42 -0700 X-IronPort-AV: E=Sophos;i="5.92,212,1650956400"; d="scan'208";a="644080113" Received: from aslawinx-mobl.ger.corp.intel.com (HELO [10.99.249.103]) ([10.99.249.103]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jun 2022 01:40:40 -0700 Message-ID: <298dd904-586a-d09f-2e14-0e0fc45385fa@linux.intel.com> Date: Wed, 22 Jun 2022 10:40:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v7 07/14] ALSA: hda: cs35l41: Support multiple load paths for firmware Content-Language: en-US To: Vitaly Rodionov , Jaroslav Kysela , Takashi Iwai , Mark Brown Cc: patches@opensource.cirrus.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Stefan Binding References: <20220622074653.179078-1-vitalyr@opensource.cirrus.com> <20220622074653.179078-8-vitalyr@opensource.cirrus.com> From: =?UTF-8?Q?Amadeusz_S=c5=82awi=c5=84ski?= In-Reply-To: <20220622074653.179078-8-vitalyr@opensource.cirrus.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/22/2022 9:46 AM, Vitaly Rodionov wrote: > From: Stefan Binding > > To be able to support different firmwares and tuning > for different models, the driver needs to be able to > load a different firmware and coefficient file based > on its Subsystem ID. > > The driver attempts to load the firmware in the > following order: > > /lib/firmware/cirrus/cs35l41-dsp1---dev<#>.wmfw > /lib/firmware/cirrus/cs35l41-dsp1--.wmfw > /lib/firmware/cirrus/cs35l41-dsp1-.wmfw > > Signed-off-by: Stefan Binding > Signed-off-by: Vitaly Rodionov > --- ... CS35L41_FIRMWARE_ROOT, NULL, NULL, "wmfw"); > + if (!ret) { > + /* fallback try cirrus/part-dspN-fwtype.bin */ > cs35l41_request_firmware_file(cs35l41, coeff_firmware, coeff_filename, > - CS35L41_FIRMWARE_ROOT, "bin"); > + CS35L41_FIRMWARE_ROOT, NULL, NULL, "bin"); > return 0; > } > > @@ -143,7 +183,6 @@ static int cs35l41_request_firmware_files(struct cs35l41_hda *cs35l41, > return ret; > } > > - You add unnecessary line in patch 4 and remove in this one? > static int cs35l41_init_dsp(struct cs35l41_hda *cs35l41) > { > const struct firmware *coeff_firmware = NULL;