From: David Howells <dhowells@redhat.com>
To: Tony Jones <tonyj@suse.de>
Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org,
linux-audit@redhat.com, Eric Paris <eparis@redhat.com>,
Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: PATCH [1/1]: audit: acquire creds selectively to reduce atomic op overhead
Date: Fri, 11 Mar 2011 16:33:52 +0000 [thread overview]
Message-ID: <29980.1299861232@redhat.com> (raw)
In-Reply-To: <20110310202516.GA16122@suse.de>
Tony Jones <tonyj@suse.de> wrote:
> I'm not seeing the 'tsk->real_cred' usage, can you clarify?
get_task_cred() and task_cred_xxxx() call __task_cred() which uses
tsk->real_cred. These are the real credentials of the process, and the ones
that are used when the process is being acted upon and the ones that are
visible through /proc.
However, if a task is acting upon something, task->cred is used instead. These
are not visible from the outside and may be overridden. current_cred_xxx()
uses these.
It's possible that the credentials being used in audit_filter_rules() are
incorrect under most circumstances and should be task->cred, not
task->real_cred.
David
next prev parent reply other threads:[~2011-03-11 16:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-07 21:06 PATCH [1/1]: audit: acquire creds selectively to reduce atomic op overhead Tony Jones
2011-03-08 18:02 ` David Howells
2011-03-10 20:25 ` Tony Jones
2011-03-11 16:33 ` David Howells [this message]
2011-03-15 17:38 ` Tony Jones
2011-03-15 17:44 ` Eric Paris
2011-03-15 20:11 ` David Howells
2011-03-17 18:11 ` Tony Jones
2011-03-21 13:57 ` Eric Paris
2011-04-27 13:12 ` Jiri Kosina
2011-04-27 16:26 ` Tony Jones
2011-03-15 20:04 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29980.1299861232@redhat.com \
--to=dhowells@redhat.com \
--cc=eparis@redhat.com \
--cc=linux-audit@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tonyj@suse.de \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).