From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92259C433E6 for ; Thu, 18 Mar 2021 11:48:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1A90B64F4D for ; Thu, 18 Mar 2021 11:48:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229805AbhCRLra (ORCPT ); Thu, 18 Mar 2021 07:47:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47636 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230232AbhCRLrJ (ORCPT ); Thu, 18 Mar 2021 07:47:09 -0400 Received: from mail-qk1-x72b.google.com (mail-qk1-x72b.google.com [IPv6:2607:f8b0:4864:20::72b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 13092C06175F for ; Thu, 18 Mar 2021 04:47:09 -0700 (PDT) Received: by mail-qk1-x72b.google.com with SMTP id n79so1613945qke.3 for ; Thu, 18 Mar 2021 04:47:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vt-edu.20150623.gappssmtp.com; s=20150623; h=sender:from:to:cc:subject:in-reply-to:references:mime-version :content-transfer-encoding:date:message-id; bh=Xd/+a2wJECnWGpm73LH+F3DCjZXOTUzAsNn6jljBOVo=; b=YswBmbZdVUxNJ1nAUXjhf3j4INsf/RmYoYDujnohUbSUgoSygaKKo/EC1SmcMQKB/0 h0xC/s9oNjQEgFbIbgf1tn4PfF9TnO6weoaDjDrFv+fx1YTk4SaIhE1kubU6mzcLmdzF awM1N8VS4PHwli+oy6jujof72sZJ9GC4dtuUbyKB2dI8cYT7dweKuOD+U1isU3b1aT3g VMOdM6d2t9VhKbuWN2C6dWw5az96ziHNYPTCijX9ttft2qSJpQjiBX994F2iWkNFVEy3 cQUxYtvZTIjY5ZH2ihcolY7ujm8v6bnPthudWbFFouU7iOyHXa/HbWUdCnjO3aVq0Xiw gdzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:in-reply-to:references :mime-version:content-transfer-encoding:date:message-id; bh=Xd/+a2wJECnWGpm73LH+F3DCjZXOTUzAsNn6jljBOVo=; b=lqTWUBdrCyhB1uldKkpvl64t38RUhlb9NdM0loamCVj6wzn9w80QYHO+vQfYpXHXnF B++OqCMFsJ/y6ccCVvCnDLxZG1ypLXb6Wth4++cmdpbgnbJR8sNZT4q3V2jTZeFPGxUd BYtnpL/WeE2nLGHsB4K803MCyn5yVz1r8TNX4DJkKJrv/RgLYo4h+on8suqxkHKyRZD9 3JjCm8QxMj4wqC8To8osXXWOuc0JXzY7YEmMMT/OyLumUlNHKO1E4Yiy67soXj+j+rUF unsUQPfArvkUFAwTnfzPMpgR52/t0mS9fF1JOi4xogSPCxzICyJcnwFCzfii+cTPO/kX szeQ== X-Gm-Message-State: AOAM532G5EScm4yIH2kNo2Fhwbo5KW5W1XxaI4fOLL3faDHUYKKjTya3 blCyn2XcsNuVouWc4glVDlLUfw== X-Google-Smtp-Source: ABdhPJy2cYcPwTcgduhapJYhM1AEXyAUTeig+OlggUs5JR2SA6Z6PUa51PLJp6xPkr2jicckzs2Fgg== X-Received: by 2002:a37:a085:: with SMTP id j127mr3688500qke.206.1616068028177; Thu, 18 Mar 2021 04:47:08 -0700 (PDT) Received: from turing-police ([2601:5c0:c380:d61::359]) by smtp.gmail.com with ESMTPSA id o197sm1543765qka.26.2021.03.18.04.47.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Mar 2021 04:47:07 -0700 (PDT) Sender: Valdis Kletnieks From: "Valdis Kl=?utf-8?Q?=c4=93?=tnieks" X-Google-Original-From: "Valdis Kl=?utf-8?Q?=c4=93?=tnieks" X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7+dev To: Masahiro Yamada Cc: Miguel Ojeda , Kees Cook , Josh Poimboeuf , Geert Uytterhoeven , linux-hardening@vger.kernel.org, Linux Kernel Mailing List , Nick Desaulniers , Joe Perches Subject: Re: [PATCH RESEND] gcc-plugins: avoid errors with -std=gnu++11 on old gcc In-Reply-To: References: <279558.1615192821@turing-police> <202103172251.F9D770D@keescook> <282490.1616047333@turing-police> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="==_Exmh_1616068026_248661P"; micalg=pgp-sha1; protocol="application/pgp-signature" Content-Transfer-Encoding: 7bit Date: Thu, 18 Mar 2021 07:47:06 -0400 Message-ID: <299822.1616068026@turing-police> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --==_Exmh_1616068026_248661P Content-Type: text/plain; charset=us-ascii On Thu, 18 Mar 2021 18:07:28 +0900, Masahiro Yamada said: > We can require GCC 6+ for building GCC plugins. > + depends on CC_IS_GCC && GCC_VERSION >= 60000 I'd be OK with that personally, but the question is whether any gcc 4.9 or 5.x users are using plugins. That's a bit above my pay grade. Kees? Do we have any data on that? (All I know is that there is at least one, because they tripped over the GCC bug that prompted the second patch) > BTW, the commit message mentions that > the issues only happen on GCC 4 and 5, > but the added code was: > > GCC_FLAVOR = $(call cc-ifversion, -ge, 1100, 11, 98) > > instead of > > GCC_FLAVOR = $(call cc-ifversion, -ge, 600, 11, 98) > > So, this patch is also requiring to cover two standards: > > GCC_VERSION >= 11 : -std=gnu++11 > GCC_VERSION < 11 : -std=gnu++98 I chose 1100 so that everything from 4.9 to 10 would keep getting handed gnu++98 the way they had been, and only change it for gcc11. --==_Exmh_1616068026_248661P Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Comment: Exmh version 2.9.0 11/07/2018 iQIVAwUBYFM9ugdmEQWDXROgAQJ0BhAAhLOSziVfqbVLcMdTzxE83OAGHH4JDetz oUS6F3q25fp7VR0wesEoFWpFOdKrMObHM6Lw20lZmNFltV9BBTK/54FoNivyUAJ9 DXAkm6cPgUIg6w/rxOVYFh0vHs1WUYMfFfa527IhClr3ZyDbky4Xhx6s7z4zZq4I nU0k3WHupSl8auF5v7/ooOm8JWNM90nI6HLv2L1aLY2mIWVSXWFuUX6dPG5dbEKd iZ4iUYotm1LoLX3KA82SlhGe8j/JryVicQP/3t3mr8dERoFHPgYky+7vVY6Tdzou giWTTQOeAxPr16Dq5Ct6aYqeST63QufKSpvVeHVqZpR0GoQxOEf2mhUJLBRmRqr0 AS6yfEybFzqn2fg8LrvKyn/2taMilKKHjdXjvK7/16fq23osmrgvQ0QzrSPzhU9Q peDaJnivzQKg2MdgTFXMGwBaNPFAA6NDmW5ykOAtkC/rkLBfPwjB2a0g/QwZ/HT3 8Fu6DRTxbFdjZjNHJGnAgdxhOjmaLYL4G2JtEfYDgpzFQvDsWVaWqMtHoKQ/OvRu S6nyJqalE5I1cKmUx44/Gjg62PX1qCdLLd6SsnmVeVziDy85Q4U4u+mYonZfmD7e fth3FpjYSHjwVRXyCNp4/Qvnie+xKA2hbUXPTiUibh+x+40XRYjgseejgk8fg3XI w9zUfcNsqDE= =kv1K -----END PGP SIGNATURE----- --==_Exmh_1616068026_248661P--