From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754569AbdCILkj (ORCPT ); Thu, 9 Mar 2017 06:40:39 -0500 Received: from szxga03-in.huawei.com ([45.249.212.189]:3958 "EHLO dggrg03-dlp.huawei.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1752887AbdCILkh (ORCPT ); Thu, 9 Mar 2017 06:40:37 -0500 Subject: Re: [f2fs-dev] [PATCH 1/2] f2fs: don't need to invalidate wrong node page To: Jaegeuk Kim References: <20170306215102.3807-1-jaegeuk@kernel.org> <8fa2118d-1da0-29f6-a755-fd661333d05d@huawei.com> <20170308213546.GB5483@jaegeuk.local> CC: , , From: Chao Yu Message-ID: <29a94fb3-67be-d326-b8f8-a553b18ee549@huawei.com> Date: Thu, 9 Mar 2017 19:36:22 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <20170308213546.GB5483@jaegeuk.local> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020205.58C13E3A.00B7,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 8f94d429a1c03f381f0e940ba9462854 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017/3/9 5:35, Jaegeuk Kim wrote: > On 03/08, Chao Yu wrote: >> On 2017/3/7 5:51, Jaegeuk Kim wrote: >>> If f2fs_new_inode() is failed, the bad inode will invalidate 0'th node page >>> during f2fs_evict_inode(), which doesn't need to do. >> >> Hmm...should not allow other using of inode->i_ino in following codes of >> f2fs_evict_inode, right? > > Right. I mean those codes below invalidate_mapping_pages(NODE_MAPPING(sbi),,) After having a look at them, I think it's OK without any change. :) Reviewed-by: Chao Yu Thanks,