From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751371AbdKUSzi (ORCPT ); Tue, 21 Nov 2017 13:55:38 -0500 Received: from mout.web.de ([212.227.17.11]:62043 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750772AbdKUSzg (ORCPT ); Tue, 21 Nov 2017 13:55:36 -0500 Subject: Re: [PATCH] selftest: sync: Use common error handling code in sync_file_info() To: shuah@kernel.org, linux-kselftest@vger.kernel.org, =?UTF-8?Q?Emilio_L=c3=b3pez?= Cc: LKML , kernel-janitors@vger.kernel.org, Shuah Khan References: <219c366b-d753-e65b-b021-6d4a584588d0@users.sourceforge.net> <3a27095e-84ad-6e93-bae5-3b242a042238@kernel.org> From: SF Markus Elfring Message-ID: <29abb1d8-95dd-fdf3-cecb-40d6c035508c@users.sourceforge.net> Date: Tue, 21 Nov 2017 19:55:25 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <3a27095e-84ad-6e93-bae5-3b242a042238@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:mWu6QOxdoUHujlkRzGfVjv+pEMHd/05nJWIgSwbFKKAQTb9mqK1 jVfa8SCYtLeXLd+HSmZlUYs+2wb6sJ2CdBE2Sq8Vsm1XCNI31BoBP2U9MNN/bJGcDo7lVau qD3R1+2BjhrLjKAJbxs4CTE7yUQH/a6G89Vv9xlxkFAtgzj7kxefDlI6xdxv1Bur11tE02+ beYaq/nyGhLWtT1m8nTIw== X-UI-Out-Filterresults: notjunk:1;V01:K0:jmFCm3BHo88=:u7o3sTQqdHh1bMgrEYd70Z IOtezuD3XpZXHiMtsUnUYPErisEEu/oaVgS0k9SDOx+OzAf00Qu9Gn1R4xnPPDhUdNdSRBtiU J2tR9paL2lRvpov3UfNlCRAkCDTyra3NYLxooXbGMnpJ6r6KxdfjZhGnyh7mznO9nasP5zD3y O8YhChwNbNFDiFQIV+2xwp+sLu7p2HpSS+My3FY4tBdhgrXcj0yiPhsbvaflbZ8wRUvA6Weys hxU2/XcD2kBuZoMFz4Xg5/gQkb4sY7YlVcf1Vkkrzm7+WxewKSpa6LjMMoggbL5tdgMnplebk hvcjnO7C2QBKIidxINguRchfx1H+w8wmU+0XBy2pc64Mfo6Y5NnvxhJKqyru9Apwvr8Vdg2bU ouUF733j5dCFH+m9aRPovG9NbD2iDAxIt/EOoJ3zXveEGPbqU5rc4aeO0mwWTCQ7TZGsNwEb1 1PaAHDWXK8TefvNlySTPThkWiwRkxmYkj15MiygV/lPuuumOmm56gK42FAtsMIFgJYxCZuWvN l1xCrCcVDjcGr3Adph3ZjNgSESQ5hfsA/PXcxRsQPTLqtY9GG8M/1jEjke3pJYCs/PrgU6fvC 5AhDqNV6vwhoQZ3VVNDzlAT3LlXJb1bXeCgbiThlp5sPWMSaD9kJbZhG17oYX0Aick/yYr5Or vX17sdJAvQn+YQgoyLCxwNsbQvtxbNz70Fo4gPJ159zJ37nD35K681rXL73CTch+zTmtWrvX2 faC9FI0Z3lj2umlt9xHGt5D9Jlc5bkO74nUGtAWPIMj/+FZh3sqJsqQrBazwvJVVxE31bjFL7 29UGfEqDNggsJlccvvzz6+eKlcRrj5zp1BS+Eywi67Y60w73KY= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> Add a jump target so that a bit of exception handling can be better reused >> at the end of this function. >> >> This issue was detected by using the Coccinelle software. > > I would like to see the Coccinelle log included in the commit log I guess that I can not append the kind of report you might be looking for so far. This small update suggestion is just another result from one of my evolving scripts for the semantic patch language. It was discussed under the topic “Comparing statement lists with SmPL” to some degree. https://systeme.lip6.fr/pipermail/cocci/2017-August/004388.html >> @@ -104,22 +102,23 @@ static struct sync_file_info *sync_file_info(int fd) >> info->num_fences = num_fences; >> >> fence_info = calloc(num_fences, sizeof(*fence_info)); >> - if (!fence_info) { >> - free(info); >> - return NULL; >> - } >> + if (!fence_info) >> + goto free_info; >> >> info->sync_fence_info = (uint64_t)fence_info; >> >> err = ioctl(fd, SYNC_IOC_FILE_INFO, info); >> if (err < 0) { >> free(fence_info); > > Why not add a free_fence_info to make it consistent? It did not add another jump label because it would be used only once for this if branch (according to your enquiry). >> - free(info); >> - return NULL; >> + goto free_info; Do you expect a second update approach for this source code place? Regards, Markus