From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE857331EC5 for ; Tue, 25 Aug 2026 18:03:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787681010; cv=none; b=Fbnf21yObqXyQQtRzX+Gg1BeDjrdR+S8BDSorwnMIm0/v2puxWBp7opf/M6WV5cCvjfjnpi/MB4/YjC8R0/WakcC6WEyMIPPG1SOLZjwzt1BfkhtcxeuByZmNCNdxOtEj3dsr/Y03idmR5Br64mHy8UIAX/EPdUZi0xNHoEaDjs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787681010; c=relaxed/simple; bh=/qmvj7oQP9+hee2C20TKZdFcP+FMqjk6v+eNCfV8brU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=o4pFrISelbv2ZNfoIonZUW3olIgyaztKiNzsnO2PaMirzpbnSt/qj2wKAbKOfRHaBgKQJfWIyKbdIIkm0acAei/6dxpFooU7MrT0brbbagoDepQ2OtFAQRdEtqSVavucEY3Gn39end6Hhxxb/61JyNfY2BXfK7VZ84eHIAdG8e0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=LStShXil; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=FR0yEzTp; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="LStShXil"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="FR0yEzTp" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67PHdJXg2049027 for ; Tue, 25 Aug 2026 18:03:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= dAzvwPMvS0QGNlY8eB3tLuP2d1LA5UE0AZDeb4igS9A=; b=LStShXilBn/N/NVU B+zJ086C8sJhHVWLd+R8rKiO9UfjZ0740/W+UGfDVPq1bKPENeK4jFfAyipylQJu BVHo5R1jDR+u93GetjgtVEj78/zpeMpkezZobvZcP9GvPdAdpFo4xz526CB7J4/L wPFFto914JwtFXJGu1jM1yJ53TkHeSG+BI8vSo/ENi2hzJ3W+en+8vdrL2/bwVXl kJuIV4gj8mFE7uBeQYpZkJxQgJk5IOocT7/JvB5MDsMUsmsuP51NgRq1E37cVd3H wwmoU+biGU/cZYb4Y03MkYOB3Di92t2XG3svLhIS0lB99KMrFzTR7kXia+r5OxvD F5eR6w== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g9fjn03we-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 25 Aug 2026 18:03:28 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-cc1b8088202so13865a12.3 for ; Tue, 25 Aug 2026 11:03:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787681008; x=1788285808; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=dAzvwPMvS0QGNlY8eB3tLuP2d1LA5UE0AZDeb4igS9A=; b=FR0yEzTp7qj4FRn+UDsp29ky/Q2Fgy1yn604tago1GCPF8/YWdemv6mk754nr1fkBl lV5ihNOn2P1CIChsBm+YI56XMTAWBi5IVqkqmPU/dpKagHoWkZ2Pmw9zIgIBd64uGDHC 5oPADUNys86Kq488QeGHiHbS1R0UEWy8+9CGkUG0gLZAbgBHqKk1RFiGvln0RL1uQazq GcTAcon1xbTNZCrifsecYQo3jIqbmGhXHAfVUi4y2iSaIVXyhlsc9vP+lhDiHGC1b0rA Kw/Q2+2Sj4EJ+JsJchiaAxfDe7fscDv0ToHlf7kg/lQUnIvvPblJodqUm6It8J360tjE IEMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787681008; x=1788285808; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=dAzvwPMvS0QGNlY8eB3tLuP2d1LA5UE0AZDeb4igS9A=; b=qipCTdfVTnU1MMCmdCFzKy/XOyw4BfqdI+9BMXt2mbaBKfSriN6Cxi44NNYD0nYsrR MS7wSRzGcHAu+dZU+Ho/q+w2AEV9GzJ15NFbx2YIaTdDLKLI607vnwnZGqXjMpHrmqMk heszi6FiADtbRPkhCaWfHHBLj5ybMhd4ZHAWWiFKa671VlyLPX2WB1gppgiYeRPgUgc6 7nNT/+Yo/UavN5Xp22QTnB8OZjSzQYU/vqxPykdvCeAmD3wqgNSWYKaU1NSSinCQdFAL bnCEUBFMZUnhABogAJAgdrMf0/1Df5FNSKNr6TRDJxUCWOw4Rb48MDov2p/6/0rwQsJR reuA== X-Forwarded-Encrypted: i=1; AHgh+RrIUmyVgen8tH98NPtFEOI2kYV0WGxgX0A6P7QXN/0lRpWhEt433WyOH0+7ozqBEzEbV79kWlfuHRsU0eo=@vger.kernel.org X-Gm-Message-State: AFuF++k4Ch5xcqk9CxqtUKtIDFbb83qZPoabs9phJIo11jrZUhtDfM5y bsVqB1HJRGC3WmBv9YwLRDZz14Q4n40uMb3O7VDCoopfuj8pguTMAB9/iWFTNgflJcTFmWKPglQ UhgoqF7BSEtNMI9CVTYSf2LTKX74T8d3mGj1pWH/OfzK6pcv3DyjnSoZN/AO2ElPY6MY= X-Gm-Gg: AR+sD131DEx8vZehovyx+XzmeNRXk4HP/N5Ng++qXXsLt8dw97/qc/o0r4ZAmQTC3MI Ak2MbkJqB7PEBntsdbwT5vzfOsYuyhRCo1zNrGQyI8gP2YeHnWIv4uNER8B1ENWSKutbR/KDY38 Z+My13Cl5YwZLfE7ZdiYSR/Aaehsb/c/CgT8USN8QwVkjprro0Zlr+rRKsZ+4qIf9NGVm7/TkXj Imh1omuVG1hK1AOZeE7wtx6x+UND6il8E9ruL3R+vZy02lLKGfVhHOxajOJTxVPyZpj2qbse9Wu WpfyYCWUxRj5omeUfvx93ukDbRFGWjV/smL9O7Cp2iw5wXtu4vpMhrQnhT32QX3OLzRqIwN6R0K RAQMhYIt8pM02WlYbPqyOPvnTiZyX0+V6 X-Received: by 2002:a17:90b:4e8d:b0:38d:f5bb:e0f4 with SMTP id 98e67ed59e1d1-3966d400334mr1832595a91.1.1787681006059; Tue, 25 Aug 2026 11:03:26 -0700 (PDT) X-Received: by 2002:a17:90b:4e8d:b0:38d:f5bb:e0f4 with SMTP id 98e67ed59e1d1-3966d400334mr1832233a91.1.1787681004826; Tue, 25 Aug 2026 11:03:24 -0700 (PDT) Received: from [192.168.0.7] ([49.204.110.145]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-141a8f20095sm914906c88.6.2026.08.25.11.03.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Aug 2026 11:03:24 -0700 (PDT) Message-ID: <29b5226a-d403-4bdd-a114-eeb2fd341ea0@oss.qualcomm.com> Date: Tue, 25 Aug 2026 23:33:12 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 7/7] i2c: qcom-geni: Use geni_se_set_rate() for setting source clock frequency To: Mukesh Savaliya , konrad.dybcio@oss.qualcomm.com, Sudeep Holla , Cristian Marussi , Ulf Hansson , Bjorn Andersson , Konrad Dybcio , Greg Kroah-Hartman , Jiri Slaby , Mark Brown , Viken Dadhaniya , Andi Shyti Cc: chandana.chiluveru@oss.qualcomm.com, arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org, linux-spi@vger.kernel.org, linux-i2c@vger.kernel.org References: <20260805-derive_clk_perf_tbl_from_perf_domain_opp_table-v1-0-61171ab1cdce@oss.qualcomm.com> <20260805-derive_clk_perf_tbl_from_perf_domain_opp_table-v1-7-61171ab1cdce@oss.qualcomm.com> <8af7a34a-da4f-492f-a51c-cc420edc5e6e@oss.qualcomm.com> Content-Language: en-US From: Praveen Talari In-Reply-To: <8af7a34a-da4f-492f-a51c-cc420edc5e6e@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: G7HeKYpMd4DBC07VLXaMtLXMOPlGVJWK X-Proofpoint-Spam-Info: AW1haW4tMjYwODI1MDE1MyBTYWx0ZWRfX/xk3hCiwIgGs APHRnDzhXGRLupGYIi7w4emLV/iwaEOWdzp80BcluDE1x+OYAusK3k0I59PvtxK7tlz7WS0jj+p sQYRu2ObnIikyzC8Vv/dz+U+mc9DXVM= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODI1MDE1MyBTYWx0ZWRfX0FGc6lTMoS1N JwnL3oT+X4zqWHhRl8fM2e97/g+WDbJzD73BYozSivwaFvDcZg3COPOcvtvtNJ9vzmwdTWL/Hq7 t3ivHtCzOadcsjC0u1ozgBpOI0yZxUEI+4uUpkuwlVeRLT3JBowsvuMfoG3OJLsG3Y3tFGMSQsl Mlwu5ENwzDAqMdtsQLGKOf3lyvT0xYyU2BIumG/odES/7x6tjgX2q9W3tm4BlAMK6epotgUDe8e ENkKK2ZEuF5GqALwqX2WkQFKnykIW7kuk/qMaoZlTKdXANhM2+sVcsk5d3618xd+8tcqayQMtyx 3TwRmZ+bc5ylnskWM+XUgg6E/hPDLUjVMPuv/RxJPLnWimr0Z9qRqS/r7qcoo/sOlymhN+LLLQX kuaLDAmzLtUlwSiqMNwrwIIxSO0YTphLCd01udoVMco2Qd0JqjVChg/K7HKYu0lCO+9GNrqN3+G gtTSJDLlm/50pDI9AoQ== X-Authority-Analysis: v=2.4 cv=ccziaHDM c=1 sm=1 tr=0 ts=6a8dd8f0 cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=T2iwtsF3Qoe1cvxaLfjbZQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=s8i-5AHMM79FQocxpXYA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=x9snwWr2DeNwDh03kgHS:22 X-Proofpoint-ORIG-GUID: G7HeKYpMd4DBC07VLXaMtLXMOPlGVJWK X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-25_05,2026-08-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 spamscore=0 suspectscore=0 clxscore=1015 malwarescore=0 bulkscore=0 adultscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608250153 Hi Mukesh On 24-08-2026 19:11, Mukesh Savaliya wrote: > > > On 8/5/2026 1:27 AM, Praveen Talari wrote: >> On the SA8255P platform there is no Linux clock handler for the SE >> source >> clock; resources are instead managed by firmware via a genpd performance >> domain. The I2C driver therefore relies on geni_se_set_rate() to >> apply the >> fixed 19.2 MHz source clock frequency expected by the SCL divider and > > somewhere it's 32 MHz also and this may change too ? 19.2 MHz is just the frequency currently requested by the I2C driver. Other frequencies such as 32 MHz are also supported and may change in the future. > >> counter values programmed by qcom_geni_i2c_conf(). >> >> Call geni_se_set_rate() directly from qcom_geni_i2c_conf() so the >> configured frequency is applied to the correct device (the perf domain >> device on the firmware-managed path, or se->dev otherwise) without >> the I2C >> driver needing to know which resources_init() variant is in use. >> >> Drop the now-unused set_rate field from struct geni_i2c_desc, the >> geni_se_set_perf_opp() usage on the SA8255P variant, and the unused freq >> parameter from qcom_geni_i2c_conf(). >> >> Signed-off-by: Praveen Talari >> --- >>   drivers/i2c/busses/i2c-qcom-geni.c | 13 +++++++------ >>   1 file changed, 7 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/i2c/busses/i2c-qcom-geni.c >> b/drivers/i2c/busses/i2c-qcom-geni.c >> index a23554d101fd..4561e2d235d5 100644 >> --- a/drivers/i2c/busses/i2c-qcom-geni.c >> +++ b/drivers/i2c/busses/i2c-qcom-geni.c >> @@ -213,11 +213,11 @@ static int geni_i2c_clk_map_idx(struct >> geni_i2c_dev *gi2c) >>       return -EINVAL; >>   } >>   -static int qcom_geni_i2c_conf(struct geni_se *se, unsigned long freq) >> +static int qcom_geni_i2c_conf(struct geni_se *se) >>   { >>       struct geni_i2c_dev *gi2c = dev_get_drvdata(se->dev); >>       const struct geni_i2c_clk_fld *itr = gi2c->clk_fld; >> -    u32 val; >> +    u32 val, ret; >>         writel_relaxed(0, gi2c->se.base + SE_GENI_CLK_SEL); >>   @@ -233,6 +233,10 @@ static int qcom_geni_i2c_conf(struct geni_se >> *se, unsigned long freq) >>                    itr->clk_div, itr->t_high_cnt, >>                    itr->t_low_cnt, itr->t_cycle_cnt); >>   +    ret = geni_se_set_rate(&gi2c->se, 19200000); > > hard code ? Good point. The 19.2 MHz value is not intended to be a permanent limitation. This matches the frequency currently used by the I2C driver and therefore preserves the existing behavior. If support for higher source clock frequencies (e.g. 32 MHz or others) is added in the future, the requested OPP/performance state will need to be updated accordingly. > May work currently, but if higher frequency support added, source may > change. > > Also you have added in commit message, but add a comment also here. > >> +    if (ret) >> +        return ret; >> + >>       return geni_icc_set_bw_ab(&gi2c->se, GENI_DEFAULT_BW, >> GENI_DEFAULT_BW, >>                     Bps_to_icc(gi2c->clk_freq_out)); >>   } > > [...] >