public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: "Sandeep Maheswaram (Temp)" <quic_c_sanm@quicinc.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Mathias Nyman <mathias.nyman@intel.com>
Cc: Felipe Balbi <balbi@kernel.org>,
	Stephen Boyd <swboyd@chromium.org>,
	Doug Anderson <dianders@chromium.org>,
	Matthias Kaehlcke <mka@chromium.org>,
	Pawel Laszczak <pawell@cadence.com>,
	Peter Chen <peter.chen@kernel.org>,
	Roger Quadros <rogerq@kernel.org>,
	Aswath Govindraju <a-govindraju@ti.com>,
	linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org, quic_pkondeti@quicinc.com,
	quic_ppratap@quicinc.com
Subject: Re: [PATCH v2 0/3] Refactor xhci quirks and plat private data
Date: Tue, 22 Mar 2022 17:53:42 +0200	[thread overview]
Message-ID: <29ba84fb-1db2-1d84-cf9e-191e9bcbf739@linux.intel.com> (raw)
In-Reply-To: <b38ddfcc-68c3-d99f-816b-8b9f788aa88a@quicinc.com>

On 21.3.2022 8.21, Sandeep Maheswaram (Temp) wrote:
> Hi Mathias,
> 
> On 3/18/2022 5:29 PM, Greg Kroah-Hartman wrote:
>> On Thu, Mar 17, 2022 at 11:17:17AM +0530, Sandeep Maheswaram (Temp) wrote:
>>> Hi Greg,
>>>
>>> On 3/1/2022 3:58 PM, Sandeep Maheswaram wrote:
>>>> changes in v2:
>>>> Added a PATCH 2/3 to remove unwanted header inclusion.
>>>> Fixed minor nitpicks in PATCH 3/3.
>>>>
>>>> Pavankumar Kondeti (1):
>>>>     usb: xhci: refactor quirks and plat private data
>>>>
>>>> Sandeep Maheswaram (2):
>>>>     usb: xhci: Remove unwanted header inclusion
>>>>     usb: dwc: host: add xhci_plat_priv quirk XHCI_SKIP_PHY_INIT
>>>>
>>>>    drivers/usb/cdns3/host.c        |  2 +-
>>>>    drivers/usb/dwc3/host.c         | 13 ++++++++
>>>>    drivers/usb/host/xhci-plat.c    |  3 +-
>>>>    drivers/usb/host/xhci-plat.h    | 24 ---------------
>>>>    drivers/usb/host/xhci-rcar.c    |  3 +-
>>>>    drivers/usb/host/xhci.h         | 60 ++++--------------------------------
>>>>    include/linux/usb/xhci-plat.h   | 24 +++++++++++++++
>>>>    include/linux/usb/xhci-quirks.h | 67 +++++++++++++++++++++++++++++++++++++++++
>>>>    8 files changed, 115 insertions(+), 81 deletions(-)
>>>>    delete mode 100644 drivers/usb/host/xhci-plat.h
>>>>    create mode 100644 include/linux/usb/xhci-plat.h
>>>>    create mode 100644 include/linux/usb/xhci-quirks.h
>>> Please let me know your opinion about this patch series.
>> I need the xhci maintainer to review it...
>>
>> thanks,
>>
>> greg k-h
> 
> 
> Can you please review this patch series.
> 

I don't have a better solution than this.

So neither devicetree or ACPI entries exists for the xHC part of this dwc3 controller?

A pure platform device is created, and it matches and binds to xhci-plat driver by "xhci-hcd" name.
I guess we have no way to identify this dwc3 xhci controller in xhci-plat.c, and set quirks there,
like all those devicetree xhci devices that we set quirks based on .compatibility. 

Thanks
Mathias


  reply	other threads:[~2022-03-22 15:52 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-01 10:28 [PATCH v2 0/3] Refactor xhci quirks and plat private data Sandeep Maheswaram
2022-03-01 10:28 ` [PATCH v2 1/3] usb: xhci: refactor " Sandeep Maheswaram
2022-03-18 12:00   ` Greg Kroah-Hartman
2022-03-01 10:28 ` [PATCH v2 2/3] usb: xhci: Remove unwanted header inclusion Sandeep Maheswaram
2022-03-18 12:01   ` Greg Kroah-Hartman
2022-03-21  9:17     ` Sandeep Maheswaram (Temp)
2022-03-21  9:34       ` Greg Kroah-Hartman
2022-03-01 10:28 ` [PATCH v2 3/3] usb: dwc: host: add xhci_plat_priv quirk XHCI_SKIP_PHY_INIT Sandeep Maheswaram
2022-03-18 12:01   ` Greg Kroah-Hartman
2022-03-21  6:09     ` Sandeep Maheswaram (Temp)
2022-03-17  5:47 ` [PATCH v2 0/3] Refactor xhci quirks and plat private data Sandeep Maheswaram (Temp)
2022-03-18 11:59   ` Greg Kroah-Hartman
2022-03-21  6:21     ` Sandeep Maheswaram (Temp)
2022-03-22 15:53       ` Mathias Nyman [this message]
2022-03-23  3:07         ` Pavan Kondeti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=29ba84fb-1db2-1d84-cf9e-191e9bcbf739@linux.intel.com \
    --to=mathias.nyman@linux.intel.com \
    --cc=a-govindraju@ti.com \
    --cc=balbi@kernel.org \
    --cc=dianders@chromium.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    --cc=mka@chromium.org \
    --cc=pawell@cadence.com \
    --cc=peter.chen@kernel.org \
    --cc=quic_c_sanm@quicinc.com \
    --cc=quic_pkondeti@quicinc.com \
    --cc=quic_ppratap@quicinc.com \
    --cc=rogerq@kernel.org \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox