From: Paolo Abeni <pabeni@redhat.com>
To: Justin Lai <justinlai0215@realtek.com>, kuba@kernel.org
Cc: davem@davemloft.net, edumazet@google.com, andrew+netdev@lunn.ch,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
horms@kernel.org, michal.kubiak@intel.com, pkshih@realtek.com,
larry.chiu@realtek.com
Subject: Re: [PATCH net v5 3/3] rtase: Corrects error handling of the rtase_check_mac_version_valid()
Date: Tue, 26 Nov 2024 10:12:18 +0100 [thread overview]
Message-ID: <29d8c41d-ea21-4c35-9ec7-e7d5ef8aa55c@redhat.com> (raw)
In-Reply-To: <20241120075624.499464-4-justinlai0215@realtek.com>
On 11/20/24 08:56, Justin Lai wrote:
> Previously, when the hardware version ID was determined to be invalid,
> only an error message was printed without any further handling. Therefore,
> this patch makes the necessary corrections to address this.
>
> Fixes: a36e9f5cfe9e ("rtase: Add support for a pci table in this module")
> Signed-off-by: Justin Lai <justinlai0215@realtek.com>
Note that you should have retained the Acked-by tag provided by Andrew
on v3.
No need to repost, I'm applying the series, but please keep in mind for
the next submission.
Thanks,
Paolo
next prev parent reply other threads:[~2024-11-26 9:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-20 7:56 [PATCH net v5 0/3] Correcting switch hardware versions and reported speeds Justin Lai
2024-11-20 7:56 ` [PATCH net v5 1/3] rtase: Refactor the rtase_check_mac_version_valid() function Justin Lai
2024-11-20 7:56 ` [PATCH net v5 2/3] rtase: Correct the speed for RTL907XD-V1 Justin Lai
2024-11-20 7:56 ` [PATCH net v5 3/3] rtase: Corrects error handling of the rtase_check_mac_version_valid() Justin Lai
2024-11-26 9:12 ` Paolo Abeni [this message]
2024-11-27 7:08 ` Justin Lai
2024-11-26 9:20 ` [PATCH net v5 0/3] Correcting switch hardware versions and reported speeds patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29d8c41d-ea21-4c35-9ec7-e7d5ef8aa55c@redhat.com \
--to=pabeni@redhat.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=justinlai0215@realtek.com \
--cc=kuba@kernel.org \
--cc=larry.chiu@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.kubiak@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox