From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760160AbdKQSOn (ORCPT ); Fri, 17 Nov 2017 13:14:43 -0500 Received: from mail-bl2nam02on0064.outbound.protection.outlook.com ([104.47.38.64]:31872 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1760101AbdKQSOf (ORCPT ); Fri, 17 Nov 2017 13:14:35 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Christian.Koenig@amd.com; Subject: Re: [git pull] drm for v4.15 To: Linus Torvalds , =?UTF-8?Q?Nicolai_H=c3=a4hnle?= Cc: LKML , dri-devel References: <26729c32-cfd6-82e0-b370-a46ca951adea@gmail.com> From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: <29dd45a7-4a58-ed71-e6d4-1cd4bfc69ee5@amd.com> Date: Fri, 17 Nov 2017 19:14:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [2a02:908:1251:7981:3c4e:9086:75cd:8e88] X-ClientProxiedBy: AM5PR0602CA0024.eurprd06.prod.outlook.com (10.175.46.162) To BN6PR12MB1298.namprd12.prod.outlook.com (10.168.227.148) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a1dde178-b771-4550-8b1a-08d52de70dc0 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(2017052603199);SRVR:BN6PR12MB1298; X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1298;3:HfBqscAjfn72tpSNdHvfcAeHBrfXi5DEIg/UEJ2dhHZKNksnQEuUcJfqtJccZXJZWdzB/pzH2LgRynbbU+S+g88JNFbOuWuzTh5JQ5I9pcTxJ3e+fD3XqyvO0IoqDsMoElNr01JUGcK+IqrtDpCBue90xrayRSMVsvTXvVWGJtCJurvn+6DT0oBDhbi2TqhyBD7sZfzpQkKGpmy81AXGURg1+fwaQJY/TZA1AhyxzeCS2bbe+gN4BvpJIyPvfnGw;25:b6tSZYN3hnxElH0xNa7vyiZ3Yog6mUVgyTG4ycG6zJ9opUq3PYJ9w3fJpPw1/PzvAtkJEUfyFDF7SqeyOF+nqJ/0YSK+Yd6bpXIoEyTa6ODGyEP7PKd7NbvD3c+kqHGVkIMXzhl9NuixeHmF6iTTfJsVNYNHEJ3YSfM8p3+YwKOA1PnaZfD30OIjqPgmjFHhLrPg8zqdEwOHUmxhZ0J9l4t6R7+ZTHhFV8xG2Yizpjp7db/XgFkccMl321sxTMltn3OsCWZOuDT4XLmm46FVEh7xbrSlKDQwcNk4XkSL25LrigfvcuaiB8t3JsjWo6mOgXJzJ0t0VoHG2vBOy4bAJg==;31:XEYPZoR7AvvQcmYrFB1/8J46YHuCy7m17S6TSQDGMuRd/DgAdTrWELlu1fV03FB1Q82Fy/4cLrGnMe0ZFPt8ZhVHSlZs9HrSOWCexHSqdB437L6KRw/oskf3n3wN81r8lUfsPa2/+YpoQG5o1xiqM+0SjfDIJEsL4uwuKv8ztntD22VMRNlb5htGgA1Ac7hfGW4fW6eSidH9C3m6G6/1lc1dw3XxijqQhKyMH3vcQ9k= X-MS-TrafficTypeDiagnostic: BN6PR12MB1298: X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1298;20:rxO2fSwLUA+pIMEhQrovYCPnW0TRCBonr2yIAYroh7XuqNDRirLgBTlKZwMZB2WNl6UHABlZgdmweriEXvmwslkyd2scxp28zsGq3/huTxmh5HitIxn3Aq7wvWO4X1knX3MJlamZCT924YqzA2UlAhx9xjg+j+47TQyDmEDAHaxRIF1CVtbMs/QDDT1zoZSYMVA7MnvfavbhtaUtrWA7YdiLUB2yAzJFaLuLCZKvOadwNCC/JcwQ9yAnXjhmJpvtmZEiTGGrGUukCBKvHs1DfI5sUYDklUx+Hu2Ubw92734OXZwISUZdJg0ejE5B0xdWdlc4pTwbxbP1BSMFKx4VowAuITO5RobITJjJPt+QRRXVyJeQ2USqOmL21bybr2xbe3atS36Qf3J/PIIte6b6OUV5kiqHW42dXyejz7FSKUIUiqz6e27rmZ9q9q/9X6PTqOAcmBM1Col2trDN4q8IevItMQ89NYTM6UZ1s4E1WqhJDo3Ka7gPg/hLBlQGIldH;4:+5NTQTMoPw6vDsz7E7C9ptwZj7f7VKIIcVgVKxLUnBDcUKkRe2fknBwAeRoyKndP1m/dJSNl6j7hmumD4bZKC7x4MadLVHrXnsLpd83G2zzo8hPhvhUd6RqaezQKj4iDh5hzL9vVkGAb6XvUH/KyXT2lVTQCIjFTmUg/vi1L3WH0OQvBjx6GNCDGOIfvSNUep8jorCS3Zv9SmWzAZb11o1/lCMEu3gsMPoAnsaDQrowlO9ZcMX2WDK9MexzviDGjWKHHm/AtOY8zKzOhMTb8pA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(3002001)(10201501046)(93006095)(93001095)(3231022)(100000703101)(100105400095)(6055026)(6041248)(20161123558100)(20161123562025)(20161123555025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:BN6PR12MB1298;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:BN6PR12MB1298; X-Forefront-PRVS: 049486C505 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(376002)(346002)(39860400002)(199003)(189002)(101416001)(36756003)(229853002)(6486002)(6246003)(53936002)(1706002)(65956001)(65806001)(58126008)(47776003)(2906002)(4326008)(50986999)(54356999)(76176999)(478600001)(6116002)(39060400002)(83506002)(65826007)(67846002)(23676003)(5660300001)(8936002)(110136005)(72206003)(54906003)(6666003)(2950100002)(31686004)(86362001)(230700001)(81166006)(81156014)(64126003)(105586002)(68736007)(33646002)(316002)(93886005)(7736002)(97736004)(8676002)(31696002)(305945005)(106356001)(25786009)(189998001)(50466002);DIR:OUT;SFP:1101;SCL:1;SRVR:BN6PR12MB1298;H:[IPv6:2a02:908:1251:7981:3c4e:9086:75cd:8e88];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjZQUjEyTUIxMjk4OzIzOmcyalI2RHpKcW5pWWVSMG9JUlJaTTNXSG0x?= =?utf-8?B?SkdyOE1YVEN3Wm9CQU9zMUdUMGZ1d2JJVThEaUJJMGY2Z0Y5eVpsTXFJVkd4?= =?utf-8?B?bnliZTE1ZUlWWkIwV1BXb3BNeTRqYm5PbDZqRFpMNUQ0bjM3djVXOE9qVWUw?= =?utf-8?B?T0ZjM0RQbTkvMm1jejdPd1QrNWdaRkpPbkZ2QVBwc2plRjRJdE9TL2I0Zktq?= =?utf-8?B?OVJyNmtKSVNtMzdRSm5wNElrNDh0UUFXNEI0N2svVHRrQ1hSWE9oTWJGaVBK?= =?utf-8?B?ckhrMUJpR2dzek9sVjh0SDBnZkhUcDhTZFk2WGdnaEs3VWhDdEVKc2MrUUEx?= =?utf-8?B?QVF4TzN3RVNSL0RxNEJBWjd4ZGdNaEwrN2hDWEgybmF3bTdUSktOK3pmbU5Z?= =?utf-8?B?Mk43Z3JFVzlYNVBjZVBjMVZCYk9nNVdSNDF2WkVHZGlxdDJaaXp3cjBrYTJQ?= =?utf-8?B?RGRxNFNabzFtOVU4dEpxNm9zRFVyQjVvSm9XVFR2U2pGclJQVGhRaVJyaktn?= =?utf-8?B?eGNoK2VRZ1pjZnhkVFA5M1VQTWtzOXNaallUMzRQNjVQQUV2Lzl3bXoyTjNN?= =?utf-8?B?MndCcmVjZ1lFQkkwREVCMEUzTUxySDNPSDVUMlZoNStYQTZTdXpLZDNBK1R5?= =?utf-8?B?M0RUdGcxSzB0d0tjdG16UzFRc1V4cU1WZHBGVlRFZ2dLUGlTQW9IajY5dFJx?= =?utf-8?B?YTcySGMwanJ1WHl1QjdQcDR0UVZ4ZEpET0NqbTJaemNHWElsWk5lRWNxV0xS?= =?utf-8?B?RjJ3YlpxREtPdmhDV1FSWnd1TnRjaFZLY1lwWDVWSEJhYnBaOHBIK0dTKzcx?= =?utf-8?B?b3UvMlowdFJEOG5mMnhQMktZZFFnT3NBeFptL3ZBMU1ScVZ4MXA3dnM0VTVD?= =?utf-8?B?SWx1amx6aXh1UUcyWWRLaUtROGUrWVF4cVVabjlEdkhHbExvWStkcXgrODRm?= =?utf-8?B?ZmNIeFlwczB6a1o2cG9TdHhXTnhCcW9SQVpvVHp0aURhRmZaMCs0ZWl2eTN3?= =?utf-8?B?RDBHR2Q2ZjJLS1JRc3ZXbS9sNDlVTWpmdC92WWhvZ0xMTnZpUHgxTGtlNEU5?= =?utf-8?B?MU1BL1Q2SXZRRWdEeTd6WnVXa3lsTkRPaUIwM1VDZWdJZHdGaHNBMC9EM3Bu?= =?utf-8?B?Y1FWeEpxNzhIaTRVc1Y3SnRnZHBTNEovaGhvY0o2ZTNwK3BjaHBLc0tpMStJ?= =?utf-8?B?MWw2UnBReUNUaTlEdkdVUEcvaDVtVlQyWDhBenNLZEZRaFdNVWxMbkRONm5Q?= =?utf-8?B?VmlMbjVJRXlIc1E1bWo5UnM5aGJxclN3QmorUVV2dUExcW4xWkFaSktqbFI4?= =?utf-8?B?QlFYVTZjMGFONWNCODVLMTRERHErZC9iOFZ6dG41Z2l3TzQ1OWVaNnduR3BV?= =?utf-8?B?QkViRXFmdHNOazAzZmQ3QUxkeHlnNU8veWsyMmVGdU9sWnEzbnB0VWxsZmhI?= =?utf-8?B?bEcvYUV6TjQ1SnJjRVZJWDhoSXMzRERYMTdqb202WEM1dnNkdjJtT09IbTRU?= =?utf-8?B?T0pKdVRBVmpSTUJyWlk0c3BUQ0JOaWpMZW5rdTZJNVhIT1lwZmNRdUtwOEJ1?= =?utf-8?B?eVROdjRuajRGUjZpUk5pMEhxOGJhazdDZkdzYXVHQ29nZXdEYnFraUVWQzJY?= =?utf-8?B?T1ZMY2tKV3pXTUdmdjY2Y0FvUUZjRTFqVDA1NkZrMG1CTjkyS01rNjdVVTdi?= =?utf-8?B?SW1URm5xemlrZCswMCtpNWpBcTRoMWVjRkRDcXlFelI1OHFkSU4vLzZ4Ymh1?= =?utf-8?Q?PFY6TuAte9l2CIRywqdtwzoNO7fLPKUqNknkE=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1298;6:EkXww4GslRvrNHo9xFDoLv99ScYJT+NphBn1bdZrwabxe7AijRUrM2BPWk8ZDwHHd85xlYgDGnXD4veEt8U/YjpQvA04sY/dNrtvK/kOGNF8Udis30Mt/n75HG0BKWxMTkLGOZajklrd762GnQ/MvNHniCfC1tx8w/91OebmymEmdtVE13a/cQpoCJrtqi82028r9ZhlafQDu0adttIIC4bkDj1J6EeRSNAaTjXHxWiidTUXRZS6OIyYF+VWzqvUjO6AJLZvEcxBxAmEFMxgFASQMwx4bU1XW9L5cwsCvM36Tp4Y0o1Nqc2/pMbmW0OnU8VNkwRhL/mfv3czlQNuB64uyWCT7D5JDek0HR3hIrE=;5:XR1MsD2NaO18ohf2916RVqjoypI9ZPR8bGrt8EOIzSexSCCcOc4HET34niooYE3OX6xgiXui66PHspkvskosC7xNVuN6JTITG7KGUDh1NrjLr2G2duxLGdSwbPNtX9LHnqbcGenCHtV88Q7eAcp/niO75KiYSQwnQpAiKtr3kKw=;24:FDbMjPz9ivr44HyIWPwLGYEKjBI43Tz+URgBuy7hk1Za4pH6M9NM0bDxT4/9qKng4DAxHtiPP50UKRYk6qzHkBvwFrEZHHzARfr+QzzdzHM=;7:Wn2Uh/LJPbu4/Fr9l43iDnmX+wIW+UVh6OwMFghHLrnC83SlH+SuqLujodyx8c/Nv4fQT57qKQn7aFcqBwwjrhWvJJnHbITyZbwxHOExetfLYxz/hKXwq9HFevYh4sk0/mwagpZvBe++y4/sB+tIBvhcexzpSyQHy3IspfX4nDW87Y1O+C2euVQxml+G161LJZYX+lIOzo/mNkxEsVFTKmhSz+qZgEyf58sv+WMTRJFqsIG1Ril6tNL4NJYBTC7r SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1298;20:YoBiuS+Q4IH3RvlT3e1rQe8HaQ8suo4SLhE2qbayektsdrYblpkbaaHSiSGlKx5dbx/nrDJVMqABGTGp8UkwWHw7n+3/5k8guLF323HyrjPtYI62HEJslkq2olFBTjldaP7l5g4G+aiK4nTx+MTyp9E1av3gNmxJ6XbuyBTILKheCBccjqU5mWI6VwITlup6Uf9bOlqK7eqs5ITJAMiaqU9nZ+YPeHFgyfWPJw7GyEHqxvsD7cPk4HyvBy91oBJK X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2017 18:14:32.3897 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a1dde178-b771-4550-8b1a-08d52de70dc0 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1298 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org First of all I can certainly agree with everything said so far, so just skipping to the technical problem. Am 17.11.2017 um 17:57 schrieb Linus Torvalds: > > People say "it's a ton of work to do it by hand". They'd be right. I'm > not saying you should do it by hand. But "automation" does not always > need to mean "completely mindlessly stupid" either. Taking an example from the AMD headers why this automation is more tricky than it sounds in the first place: Look at the mmVM_CONTEXT*_PAGE_TABLE_BASE_ADDR registers for example. Register 0-7 are consecutive and so could be perfectly addressable with an index, but register 8-15 aren't and so we always end with logic like if(i<8) ... else .... The rational from the hardware guys is obvious that they initially had only 8 and on a later hardware generation extended that to 16 registers. Patterns like that repeat all over the place and are not limited to AMD at all. We could write up hand written rules to sanitize all of that, but then we are back to "automatically" creating the headers by hand. When you have to maintain 10+ years of hardware generations where sometimes registers headers even need to be regenerated from the database then that is something which won't fly either. Certainly not saying that this is a bad idea, but we simply need better tools for that which also have 100% reproducible results. Ideas welcome, Christian.