From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752852AbdHIJYM (ORCPT ); Wed, 9 Aug 2017 05:24:12 -0400 Received: from mx2.suse.de ([195.135.220.15]:59073 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752548AbdHIJYK (ORCPT ); Wed, 9 Aug 2017 05:24:10 -0400 Subject: Re: [PATCH v4 1/2] x86/unwind: add ORC unwinder To: Peter Zijlstra Cc: Andy Lutomirski , Josh Poimboeuf , Linus Torvalds , "Levin, Alexander (Sasha Levin)" , "x86@kernel.org" , "linux-kernel@vger.kernel.org" , "live-patching@vger.kernel.org" , Jiri Slaby , Ingo Molnar , "H. Peter Anvin" , Mike Galbraith References: <20170728175234.pmou7z6dosbi7krh@treble> <20170728182954.imivl45vrc7toarp@sasha-lappy> <20170728185720.fwczcezbkrlxmwqb@treble> <20170728195912.panyn4p6e6ovueey@sasha-lappy> <20170729035437.fmnxmeedrq55bpwm@treble> <20170808185809.qaug762cj7nw3bcd@treble> <20170808191344.kw5nlicmq4g6fpii@treble> <79d6e04a-0a1d-592d-5e35-e4d6e7c7526b@suse.com> <20170809091648.p57ircm64t63mejj@hirez.programming.kicks-ass.net> From: Juergen Gross Message-ID: <29fcd05f-3a0d-c20e-f20a-ee2019eea73c@suse.com> Date: Wed, 9 Aug 2017 11:24:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170809091648.p57ircm64t63mejj@hirez.programming.kicks-ass.net> Content-Type: text/plain; charset=utf-8 Content-Language: de-DE Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/08/17 11:16, Peter Zijlstra wrote: > On Wed, Aug 09, 2017 at 10:49:43AM +0200, Juergen Gross wrote: >>> ALTERNATIVE "pushfq; popq %rax", "callq *pv_irq_ops.save_fl", >>> X86_FEATURE_GODDAMN_PV_IRQ_OPS >> >> You are aware that at least some of the Xen irq pvops functionality is >> patched inline? Your modification would slow down pv guests quite a >> bit, I guess. > > Where does that live? I know of the inline patching for native, but > didn't know the guests did any of that too. See arch/x86/xen/enlighten_pv.c xen_patch(). Juergen