From: "Dan Akunis" <dan.akunis@gmail.com>
To: <labbott@redhat.com>, "David Miller" <davem@davemloft.net>
Cc: <kuznet@ms2.inr.ac.ru>, <jmorris@namei.org>,
<yoshfuji@linux-ipv6.org>, <kaber@trash.net>,
<samanthakumar@google.com>, <willemb@google.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [REGRESSION] Select hang with zero sized UDP packets
Date: Wed, 24 Aug 2016 11:22:09 +0300 [thread overview]
Message-ID: <2ABF798B42E64D9C89DEB806A2E636B5@mtl.com> (raw)
In-Reply-To: <20160823.112515.318902967155957764.davem@davemloft.net>
When select wakes up on a UDP socket, user is expecting to get data. Getting
0 from recvfrom() or whatever read function she uses, is a wrong attitude.
I agree with David.
The unit test that expects select to wake up is wrong and should be changed.
-----Original Message-----
From: David Miller
Sent: Tuesday, August 23, 2016 9:25 PM
To: labbott@redhat.com
Cc: kuznet@ms2.inr.ac.ru ; jmorris@namei.org ; yoshfuji@linux-ipv6.org ;
kaber@trash.net ; samanthakumar@google.com ; willemb@google.com ;
netdev@vger.kernel.org ; linux-kernel@vger.kernel.org
Subject: Re: [REGRESSION] Select hang with zero sized UDP packets
From: Laura Abbott <labbott@redhat.com>
Date: Tue, 23 Aug 2016 10:53:26 -0700
> Fedora received a report[1] of a unit test failing on Ruby when using
> the
> 4.7 kernel. This was a test to send a zero sized UDP packet. With the
> 4.7 kernel, the test now timing out on a select instead of completing.
> The reduced ruby test is
>
> def test_udp_recvfrom_nonblock
> u1 = UDPSocket.new
> u2 = UDPSocket.new
> u1.bind("127.0.0.1", 0)
> u2.send("", 0, u1.getsockname)
> IO.select [u1] # test gets stuck here
> ensure
> u1.close if u1
> u2.close if u2
> end
Well, if there is no data, should select really wake up?
I think it's valid not to.
next prev parent reply other threads:[~2016-08-24 8:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-23 17:53 [REGRESSION] Select hang with zero sized UDP packets Laura Abbott
2016-08-23 18:25 ` David Miller
2016-08-23 19:03 ` Eric Dumazet
2016-08-23 20:06 ` Laura Abbott
2016-08-23 20:42 ` Eric Dumazet
2016-08-24 8:22 ` Dan Akunis [this message]
2016-08-24 13:02 ` Eric Dumazet
2016-08-24 13:42 ` One Thousand Gnomes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ABF798B42E64D9C89DEB806A2E636B5@mtl.com \
--to=dan.akunis@gmail.com \
--cc=davem@davemloft.net \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=labbott@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=samanthakumar@google.com \
--cc=willemb@google.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox