From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from CY3PR05CU001.outbound.protection.outlook.com (mail-westcentralusazon11013055.outbound.protection.outlook.com [40.93.201.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A732F277C96 for ; Sat, 25 Apr 2026 14:17:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.201.55 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777126632; cv=fail; b=TF1zqvmePVtRyASJEixCWil+no2PxMSYjpme/ytfYh06KFzY1qBbC4/gTPQLSt+3v2Gro+D+nmz1kOlS9B2AMPU8z/ZVQcbWDB3XouTJKc39lAX2QBjkhFhewdExp0WyWboUcmlnSx6UPWPjelBVqQG1A+Pfbc9NKik1F8sNeNM= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777126632; c=relaxed/simple; bh=t/gAJaK3SUIwyrfHvVWpmPVK3ATKDIuLSR0r63CoJok=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=izZbA7jTc/NtdRvrXIDCGoikNbvDvM+xfj+twwsTzaRQDEi3TE69uC9IcEl8P8azZWzMRhLzpatFXAjCGyHLXaTX7VGsdA69PFH0o3X5xHOKFvSq9dYEMPdPH2zAV02xYnkZFcpSt0lM0GthMD2n0e9Obr8l8rQHKHLYB6i44oo= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=L85Jo+F/; arc=fail smtp.client-ip=40.93.201.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="L85Jo+F/" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Fgmf3XDT4ynIhB40VfyAxG9knogrJRl5TaL9k9yCjiGPZUp/7ZwWmB82XOp9OE/qSf14h83gBgytVYdMEiRTpq9FRsAsu7BXTVCnKe3MZF6LONDKHxJtZoqzblG0VuhIdtiLdp4ci8mbVw/TqM6QHzdig5E45vk/GIXZJmUQBqZD09bbFabBtE0oQFjbNBvYPM9ylGd87u5Jka45ecHVcJvFrvuO1+iKKA/COG+112x0153vI9lBY6hU4gIwlpZrqgXBpB6KBVcGebjeZhl43WpMjznxjL7oXmVzJyh4m4ZSOkQ9hsnczjJaRKrKjBqm7DgZWXkqcxAltemoAFsLgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hkSrY1/k+MTpBbqK8/VdTaTRt1uFgKieojhBHVIwk6w=; b=E0eEswxxY3phDFix6yq35cvzvHKfq03S5WCj3qa/rz/CiHPtSxTqsPTQ0S1Xkfnt6rdKVxUmi003aJp35iiTHHh1ktvS3MjugAnn4dMCpC0E2iVq8ze2CZpDxH3xLLP6yYSFOTAB93+ssuLW7HmG5hOnc0M0VhtuA3YF7UqoVexNtnrdw/IgDi8NYZq9JdiV6og0VlbjAyp2jPWKhyxzXCcj9xZWXhdgsakMdWsNOMd6mz0IxqLJPuIHKDbeTlbPjQqEZqWuHAcrQmuOsptrC68u2mk8KGyENyWCElNl4F71mDAwxS5ML52tw5TSKdpOyAdhoLlgfW9mMG1iQ7vTMA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hkSrY1/k+MTpBbqK8/VdTaTRt1uFgKieojhBHVIwk6w=; b=L85Jo+F/IYGHJNSy/2ruq4YB+fnDI4J4e0gtD2GtTW/uDECFndi9vxjFzSQPHBMTmaG1UxQT20sgfXH+G23QYszqhFvFpzbcKg8hIS81WZ4hKVTmz5lXxBH/WXBvQETMzqXbNhN2S8zypHCSwMMpJXW5QNW0fwdhX7h/bJRhNEhzEyJMG4bcLoURlcHAF7ewh57/SrqpZy3AkYscGgPs8imz+2H5KL8pmdUWpZihvWRWT81rVkUDfqzBkWonJV1kyaiv7P3CNF1cwI7v9NMAov9quiB02dm0CbHdSCx52KoL0hVeOQLJ08jb8AV29uloLUji9kKeoBA8P0TBvTeFIg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) by SJ0PR12MB7035.namprd12.prod.outlook.com (2603:10b6:a03:47c::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9870.12; Sat, 25 Apr 2026 14:17:03 +0000 Received: from DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::f01d:73d2:2dda:c7b2]) by DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::f01d:73d2:2dda:c7b2%4]) with mapi id 15.20.9846.021; Sat, 25 Apr 2026 14:17:03 +0000 From: Zi Yan To: Sunny Patel Cc: Andrew Morton , David Hildenbrand , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/migrate_device: fix pgtable leak in migrate_vma_insert_huge_pmd_page Date: Sat, 25 Apr 2026 10:17:01 -0400 X-Mailer: MailMate (2.0r6290) Message-ID: <2BBC72DF-CD17-49CB-A72A-5D534D4CD997@nvidia.com> In-Reply-To: <20260425134453.23769-1-nueralspacetech@gmail.com> References: <20260425134453.23769-1-nueralspacetech@gmail.com> Content-Type: text/plain X-ClientProxiedBy: YQBPR0101CA0158.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:e::31) To DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB9473:EE_|SJ0PR12MB7035:EE_ X-MS-Office365-Filtering-Correlation-Id: 375ec4d7-0bcb-4169-2351-08dea2d552d8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|1800799024|366016|22082099003|56012099003|18002099003; X-Microsoft-Antispam-Message-Info: v0SKqn2RiHcKpimkpxUt2mmnF2IPC852n8sSWwvxBDwWgmJN3pxDSosv+mS5yANOaBuIRJRNcY27zRuXGVXCkUQY3SBzCCDYXlu6zdE02D1hT8W9DnzU37W9Eh7hFLaS5hTGddY44klWx0j+kT1GZTEJ+5ydRz/+t2DkmAhaiYeUKSqEMmanM+xoV/p9y4ARFckhsr1UBxrf5kXdcXOO+/Iw62bPgs0Nmy6znr3JPjGLrB2+gpw/GXZAwi5KNq7pxectme9ciB4RWnNSXQRWC+wf11UIk9tXYNi1mgFkCjEQSu4sYP/mNyMY5kq+mch8tNLIMKLj/e4MPsVi3Zr/nYuxyEXaAaioVz0fBHI/D/vjr0P0ruSQXicgVsJx8S7HFluJDaRsMkDB8aU5TAUXqSJw5sfHDnge35N1cIvmSepN7mTuuP2QiqKEf+QZWuTvEo6OPrcY9bE+VzLvQATFW5DGITHleIP/pt6EAWaqCYzW74fNZ+f577lZi/3UoOP3ILOX7Wfi9a38Xy/hloHFX95LRkLlc0qUpJLK82pr6nYPP6clPInlFtvcKOlprZds2YaTfdnPq5M736+XObHwRv20XwDokyVzT2f8a+yNk61sNrEuVdA3n6QeY/PpWDcyyKN9CD+HshrFB9JuT+r8CWY6MpZr2NCGtLk6Nq7aO8SHVF7JfT/+jaGl+3kUM+ITMpgNVqE9cavkGdl+P5A4xBLaHF+z4uGiUCPsLpj2dgE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR12MB9473.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(1800799024)(366016)(22082099003)(56012099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?RUVVZzpyrE3PTldwfkNJWNQqYXwfkrnPc1iXd//8eiI/7jjmaMObg33ZaxRX?= =?us-ascii?Q?jeYlUBH1sYafYaUdv0ZdUUrXuQztnsFcy1EijHH1MiiklHt0uWoEVYb/YupX?= =?us-ascii?Q?rnsRUq5riCW7R3KVDfXXkrV9cjWW03TP8bqmmq3VVL9iHeBM3lIUcM3xHyA4?= =?us-ascii?Q?1WQynS+0RWqb3X9lIeBfyCw6Y6vro3oCb1QWAmyVKOammf18bK3n2l8OzIvJ?= =?us-ascii?Q?qLbyfRpDhGVJfYBFwRQDOoz8PNCGxP06jq4a2e2RCYfIakXYmfb0mnCBBhq+?= =?us-ascii?Q?lWvp04964Q4b0nyU5gv3C8POvYFeZykpaG1OVqU2BijWe++/586Y7ai6tMtm?= =?us-ascii?Q?6MJobFUOowxBJqkLASRnoX5fbZ34NIIX2cNjsplOUsxQykXXBgEn6Gzw6bWa?= =?us-ascii?Q?Xgp5RZHIOK0IZNyt+GbdQW9DV0MKgg043wALTRQvGAQbWWt9Qlva9Da5ZCwt?= =?us-ascii?Q?AkT9ryYVE9/k30D2KAInmHq0WZxmOL/L5f9DkHYrt3loWSWoD4jD1h1w4p2x?= =?us-ascii?Q?ufaFD0SAVkcgtdaWrQYX8LFvhg7MibNi8Re9/GnNZwHvVUssr4atLbacgreH?= =?us-ascii?Q?Fft252mwf9z/o094i55c/QosA1codXxXPcc2kFK7pavhgLOZuJL7EP8cUSTo?= =?us-ascii?Q?Ty3TsBQo0gohOKIT4oBNwEqF7bhw4sy18EhPZsbw6WfCAbXLtSn3LyWMkCzy?= =?us-ascii?Q?PVEcWp0eSRKI4EZLOIzegoKBVA8EbsBW7hGD/qjvqJgMC94IhJU1BudB2Iw/?= =?us-ascii?Q?2vyxkO9wUICr9uTaNwF4e7gWi11NV/+/9YSNL8MDKzKzZ1HoULwkpiSwnM3C?= =?us-ascii?Q?CbeJtDZ0h2ABzVjWj9ButFAVC2rd4Nmxsga8OQ7nBp14+yWohXA8e5Kjqeys?= =?us-ascii?Q?H/CerRRqBq13ZEu3lSF8jDnZ9jMFCvxmy3ACOh2xQNKgic9fbmtE4J1aYUVs?= =?us-ascii?Q?KBUI1MCMI93jgxJHna96FIbH+0Twi1O1BDTCCnzSLJq18AMy+u9yyx15YzQF?= =?us-ascii?Q?R7i5UoD5eHfYqtNXmIWNJlR8XmMfPSVSyhc5XZwNlmKYlqHOQQdyypz06Wuz?= =?us-ascii?Q?CXgXBCQ/odad04fOUiu8MO4a4OAgOy1gbFfurxXDZJ/nHjT7j0slbUyo6eUk?= =?us-ascii?Q?hJmM/7MyBjPygLikqCslaTcY+tbG8RiDlQrqgpyyjpuIeVuIYWvCSD4cn/kd?= =?us-ascii?Q?bGKLH4PF6PQilS/nsWs0OBoO94HrpR/kQZ411MXJbuo4yx6FV15LqI8r53XX?= =?us-ascii?Q?+BThbDM36lQBCrFOsMGXFgI6LqlRQXybTq8Ii88qF3EbPOKD0tQUWyjmJAQc?= =?us-ascii?Q?Vd8z/RQqjSvGy4/ZVQBzy0wF2yV4k7BfxDQDBtTUvPfaSJKLggCEKt+xe6K3?= =?us-ascii?Q?J4ZkBEvxz07Cx8vvcRagMEwUa/llO3PAug5KUU63JZp4TDoAUIHY2SgDFmcB?= =?us-ascii?Q?C1VUSHvB3zcngCPyfoBNBqumVqzEs4TV7ERShqVNKwStvLJr/+/rCvU+HBCH?= =?us-ascii?Q?KEM6OHGL4wgTf+ZHl1p71XhU8JZ+W4sX6KOSz1g+Ksyy2utV7O+hq4heDtGr?= =?us-ascii?Q?lku0VJ2vBxyct1to8+OID7+CoNmoDYUWxIHaAVs72HRISjw950lQsYBQ16f0?= =?us-ascii?Q?p1ym46Z1SHlmgm/OZizyJxWyuCSOh5sPnjQiEHeSwBWqvuQ99lXi6/v9YaoM?= =?us-ascii?Q?CyW9CVFzZSL3V0eVXwRfocbtwk0i8p+6lXl8pUoCCGFLftTx?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 375ec4d7-0bcb-4169-2351-08dea2d552d8 X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB9473.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2026 14:17:03.6036 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tpwhkoK/0Myf1Dq2LUGSmSoK+wE16x8bkUxjrTDwyQLeVFGKftcxz/YVAbWoL38r X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB7035 On 25 Apr 2026, at 9:44, Sunny Patel wrote: > When migrate_vma_insert_huge_pmd_page() jumps to unlock_abort due > to a PMD check failure, the pgtable allocated earlier via > pte_alloc_one() is never freed, causing a memory leak. > > Add a pte_free() call in the unlock_abort error path to release > the pgtable before returning. > > Signed-off-by: Sunny Patel > --- > mm/migrate_device.c | 1 + > 1 file changed, 1 insertion(+) > LGTM. Acked-by: Zi Yan -- Best Regards, Yan, Zi