From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E32A352C4F for ; Tue, 7 Apr 2026 17:42:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775583766; cv=none; b=tMeif3SdzwEDnEda+aQD7v/XRAPvUGh/VdvhT8eMf/EG6Htiu3clOwmRfzq1fg/mkPoL8cCiZ7EaTGVE2mnIhVDs8/xv9T1t+wXnU7yG+GchrPFRg3gKKMnKJBjO9vq7hzSvP5pZYZwUPiaedBbyVWZFcBr3oZJKp71fFQplOlA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775583766; c=relaxed/simple; bh=N2kFjKlbE9WU6r3wDdHF6nerFyB/aBWhVhhdRg7x15Y=; h=Date:From:To:CC:Subject:In-Reply-To:References:Message-ID: MIME-Version:Content-Type; b=alJ4QNjM5t7D/kc6LsAfipLDRncRE+0q4mbNyVTPu2w90mE24FJmGNGrZiRQYIdo+SqrrAvZbpOO+qFR0Aqmwtmbp+WDz+YK89hRE6sY/vWuVFfL9l0tgqb2bBTdWJHQJaO8YVm7fLo8j2xCugZg4ouESHXeZGN4+NRljflVGSU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=d10Q+eE/; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="d10Q+eE/" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-2b256a4c6b5so32141255ad.0 for ; Tue, 07 Apr 2026 10:42:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775583764; x=1776188564; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=N2kFjKlbE9WU6r3wDdHF6nerFyB/aBWhVhhdRg7x15Y=; b=d10Q+eE/3cChsbmw2LasEk6iEleUx63636MO3yv6x+mDeZnIA+3JN102M6mzH6ce74 tLcxOOPP6PmpQFjE80fOyEY//M4FWNq724wBQOoiq4Ivbe0XWewiFylR+GRuZcEorMBo 4FYq7uR5x5mVRU+4S4lq+xFW82mabNc4gdWGbz7695UngLOFuaYULXqNwVY2lD/7jg1J M/6R1cNusEuVKSk3b1/G/YxIX4WfOvHJ03HxdEkckDd4qMPS8ffu64bp7+fT1lYOOEOz W0sgCNlQxQoI5JE4lBY8Dwp/JFRXmKQna853B40VjTUxUvYDlL6d7525O4gixhwt/nwD VqCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775583764; x=1776188564; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=N2kFjKlbE9WU6r3wDdHF6nerFyB/aBWhVhhdRg7x15Y=; b=KdvFhHAKBdssnuaudwkeqmMdfB6vrR0ul0p4FEfB8A4SSG013Q7OecEfjFRi0UxR6u YVMmsrZGT6r+8rq569cTrh7GaxieEGj3PB5t61FiGG2KbnXNYlaH2OsvDyr8xBZXP7Y8 6F+CGMCSzju7Bcqwjzo9dhNv6v0gG+eIdIabSy5qB10f8k5MVuge9xO8m98EJOnEQOdz p/7DM/uaNkoQmGZWutohVoXaBHCuw5aUFILvr3SJGZNFFg0xb7bF0FGL0z0uq9VZcvNm mlqhGMkc8u2KtTgyHE5vULAsP3OUosZDBFWymwcV0B9NPRyUqRbiWVXZoqU6balwfPLc AVGw== X-Forwarded-Encrypted: i=1; AJvYcCWO3S/6hHIs2UbHjwYILpD4h47WZP1ZHJ5SrdFd+a/i5uxsAGPODFF2ngw7v6lS4XN0eqfAbg1fqaO9drs=@vger.kernel.org X-Gm-Message-State: AOJu0YxaxQ1pftdLCzE0Jdd3qQX1nQ17q7uOYeLD0dUA14TMfbHkFFaD cOE2bgEUMWC4Gddgi6esu6DaubhoLVBeuActnTrTjrYe23/pgy0J0mshe72irg== X-Gm-Gg: AeBDieunmzUY98CX7rcBNBm6C1W3NBhPOIonONXS3eT0D86OWgqZ24g5P8lSNu8IqCP Kdlqofry92tWB3X/22HvSGrMBJYcoS1CQ9Df4DRg/VD6NVB2yhuZtq+rB2vAyTRXtn0BiOFLv+o 6Hgrbvx//kY9VzaHFy+uafVjTdrIj/EOGemCrpD9TQrMQerjGm+tvM6sPQ4LO2pCTmm2gIzzaRx wvvagJE0tt9lamPXEOdC7svtUzykb1Uv7jH7M3M9TyzRw1Nr+Zz7AdqqgDrzHP08OiNhVxkXr9g h0u173iLVL+W2aQYtrHS6WUWPBebpMR8G4KsSilYtxtuyNBgt7GSw3nZKBFrwWGuClxQBiR8Koc nCJSYbRKpf26MX/V/k2eBr0S7o/wo4NC2mDDfRRqoZ6DmMGZT7nCbl/NEcYpO8YGUqOGGIgWQ6t 12DfJ/tJzlVLiYvTFYr/FxS6pCRc6guwTu37+iW/gxyC5Q/JxgcWKXAWD56w== X-Received: by 2002:a17:902:8f91:b0:2b0:b325:7491 with SMTP id d9443c01a7336-2b2816be210mr160228635ad.17.1775583763409; Tue, 07 Apr 2026 10:42:43 -0700 (PDT) Received: from ehlo.thunderbird.net ([2401:4900:ae30:a700:31b3:856c:f304:d107]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b2749cbce2sm176710485ad.79.2026.04.07.10.42.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Apr 2026 10:42:43 -0700 (PDT) Date: Tue, 07 Apr 2026 23:12:25 +0530 From: Sanjay Chitroda To: Andy Shevchenko CC: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, kees@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 1/5] iio: ssp_sensors: cleanup codestyle warning User-Agent: Thunderbird for Android In-Reply-To: References: <20260406080852.2727453-1-sanjayembedded@gmail.com> <20260406080852.2727453-2-sanjayembedded@gmail.com> Message-ID: <2D18BE15-3AC7-47DD-9430-E3ECB201EC84@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 7 April 2026 12:03:39=E2=80=AFam IST, Andy Shevchenko wrote: >On Mon, Apr 06, 2026 at 01:38:48PM +0530, Sanjay Chitroda wrote: >> From: Sanjay Chitroda >>=20 >> Reported by checkpatch: >> FILE: drivers/iio/common/ssp_sensors/ssp_spi=2Ec >>=20 >> WARNING: Prefer __packed over __attribute__((__packed__)) >> +} __attribute__((__packed__)); > >Do we need __packed to be there in the first place? Isn't it naturally al= igned? > This structure isn't naturally aligned as in header structure u8 is follow= ed by __le16 and __le32 fields=2E Without packing, compiler inserts padding to satisfy alignment requirement= =2E