From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-171.mta0.migadu.com (out-171.mta0.migadu.com [91.218.175.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD02333F59E for ; Wed, 29 Apr 2026 03:02:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777431752; cv=none; b=uVOANLeUhFFUC5Pqz0S3D+974EbkmeP99HtipfVgLYjiXxrHbei/7ZVLVH+Anjwe/MfJYO8sEMa2hn5/FvRUToFGICYIjCeAcBNY+gH1xLXRFCH9WRBE2QA4YrShuW1cNxQ6BFxGJYX7XPeMtn0n/dFZrziKgXMB9NiqmyFBNAU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777431752; c=relaxed/simple; bh=7h02+kko38y3XtVxgSAUYSU6zFyAkUiyWjecs8zN9pg=; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc: Message-Id:References:To; b=Jz3gI0c2AFv1Q1g6K+RfbolU4hlOUpzDgybYqeLuOP2EXgFzoQ8KnW5XkTR0cASEBoHfC9oqUlaSEdFMEiIP+Ui0lZfdC0uj9sUteKhdklJNP3CiuxXKt1vcp/qGQXxuGRYMDTpt9nLoKoPvMQ67YVoDwC+Zek3AerJ7XwuyOFE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=nUKX6miB; arc=none smtp.client-ip=91.218.175.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="nUKX6miB" Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1777431748; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xAptSnBmp9h9N12mhZQEdxJex9G2kRMi+UwodffAKNw=; b=nUKX6miBABkPqJTWDSe3nzmfIfQo2Vwx4KnKafK/tN9cODk7otB5prJfru7ieBqJdxxlRV 8z0o0dwhC7ungjhgBrC8noRgvfZ/g4DM7YVbaKB0AQyBNgeDDmuX9Cg/avGVnCjQE3aiPX NFUPD7RRWZxRYLlyVhPJShq70PfUdZI= Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.500.181\)) Subject: Re: [PATCH 12/49] mm: make set_pageblock_order() static X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: Date: Wed, 29 Apr 2026 11:01:39 +0800 Cc: Muchun Song , Andrew Morton , David Hildenbrand , Oscar Salvador , Michael Ellerman , Madhavan Srinivasan , Lorenzo Stoakes , "Liam R . Howlett" , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Nicholas Piggin , Christophe Leroy , aneesh.kumar@linux.ibm.com, joao.m.martins@oracle.com, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: 7bit Message-Id: <2DE2FBA9-6D7E-4DDA-8B11-E844EB42E574@linux.dev> References: <20260405125240.2558577-1-songmuchun@bytedance.com> <20260405125240.2558577-13-songmuchun@bytedance.com> To: Mike Rapoport X-Migadu-Flow: FLOW_OUT > On Apr 28, 2026, at 15:17, Mike Rapoport wrote: > > On Sun, Apr 05, 2026 at 08:52:03PM +0800, Muchun Song wrote: >> Since set_pageblock_order() is only used in mm/mm_init.c now, make it >> static and remove its declaration from mm/internal.h. >> Signed-off-by: Muchun Song > > The removal of set_pageblock_order() from sparse.c should be moved here as > well :) Will do. > With that > > Reviewed-by: Mike Rapoport (Microsoft) Thanks. > >> --- >> mm/internal.h | 1 - >> mm/mm_init.c | 4 ++-- >> 2 files changed, 2 insertions(+), 3 deletions(-) > > -- > Sincerely yours, > Mike.