From: "Petr Vandrovec" <VANDROVE@vc.cvut.cz>
To: Denis Zaitsev <zzz@cd-club.ru>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] matroxfb_base.c - not a so little patch
Date: Fri, 22 Mar 2002 13:17:04 +0100 [thread overview]
Message-ID: <2F43B06E5F@vcnet.vc.cvut.cz> (raw)
On 22 Mar 02 at 16:47, Denis Zaitsev wrote:
>
> The patch is against 2.5.5. It seems that matroxfb_base.c is still
> the same since that time. And I assume matroxfb_base.c with
> <if (var->bits_per_pixel == 4)> branch present, i.e. without my
> previous little fix.
Did you verified effects on generated code/data size?
> + for (p= &table[0].bpp; *p < bpp; p+= sizeof table[0]);
> + var->red .offset= *++p; var->red .length= *++p;
> + var->green .offset= *++p; var->green .length= *++p;
> + var->blue .offset= *++p; var->blue .length= *++p;
> + var->transp.offset= *++p; var->transp.length= *++p;
Please no. Access fields by their names, and do not assume anything
about padding.
Petr Vandrovec
vandrove@vc.cvut.cz
next reply other threads:[~2002-03-22 12:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-03-22 12:17 Petr Vandrovec [this message]
2002-03-23 19:29 ` [PATCH] matroxfb_base.c - not a so little patch Denis Zaitsev
2002-03-30 16:40 ` Denis Zaitsev
2002-03-31 0:46 ` Petr Vandrovec
2002-03-31 20:51 ` Denis Zaitsev
[not found] <144D3761283A@vcnet.vc.cvut.cz>
2002-03-22 11:47 ` Denis Zaitsev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2F43B06E5F@vcnet.vc.cvut.cz \
--to=vandrove@vc.cvut.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=zzz@cd-club.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox