From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] usb: usb-acpi: fix uninitialized variable in usb_acpi_get_connect_type()
Date: Fri, 15 Mar 2024 17:36:16 +0200 [thread overview]
Message-ID: <2a3ab595-80b2-fd4a-8748-c823fa5ec098@linux.intel.com> (raw)
In-Reply-To: <fdd4f94d-fb8c-44a0-9472-3485a567caca@moroto.mountain>
On 15.3.2024 17.21, Dan Carpenter wrote:
> The "pld" pointer is uninitialized if acpi_get_physical_device_location()
> fails. Initialize it to NULL.
>
> Fixes: f3ac348e6e04 ("usb: usb-acpi: Set port connect type of not connectable ports correctly")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
I sent a similar patch a week ago, just before merge window opened.
looks like it didn't make it.
https://lore.kernel.org/linux-usb/20240308113425.1144689-1-mathias.nyman@linux.intel.com/
Thanks
Mathias
next prev parent reply other threads:[~2024-03-15 15:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-15 15:21 [PATCH] usb: usb-acpi: fix uninitialized variable in usb_acpi_get_connect_type() Dan Carpenter
2024-03-15 15:36 ` Mathias Nyman [this message]
2024-03-15 18:43 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a3ab595-80b2-fd4a-8748-c823fa5ec098@linux.intel.com \
--to=mathias.nyman@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox