Re: [PATCH v5 2/2] dt-bindings: media: rockchip-vpu: Add rk3588 vdpu121 compatible string

Diederik de Haas
2024-04-18T09:20:12Z

[-- Attachment #1: Type: text/plain, Size: 1533 bytes --]

On Saturday, 13 April 2024 17:57:09 CEST Jianfeng Liu wrote:
> I'm sorry for my unkonwing about the kernel patching process. And I'm
> sorry to let maintainers do extra work. Thank you for teaching me this.
> I will do this right in future patches.
>
> I did received a Acked-by tag from Conor in v4:
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
>
> I note it here in case someone forgets this tag.

I think it's beneficial to send a v6 with the following changes:
1) Make this dt-bindings patch the first in the series
2) Make sure you've collected all the tags you've received to all the patches
3) Specify the base commit

ad 1) I don't know if it's a hard rule, but I've seen a consistent pattern
where the dt-binding changes come before those changes being applied to
DeviceTree files. It also makes sense as when the dt-binding change hasn't been
applied, then the DT file is technically invalid.

ad 2) You shouldn't make maintainers do extra work to get your patch(es)
merged; you want to make their work as easy as possible. Thus you do the
(extra) work and provide a new version of the patch(es).
Sending multiple versions in a single day is generally not recommended as you
should give reviewers some time to do the review. But it should be fine now as
several days have past without new reviews.

ad 3) The `git format-patch` command has a `--base=<commit>` parameter with
which you can make explicit upon which commit the patch is based.
That works a lot better/easier then a textual description.

HTH

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 228 bytes --]