Re: [PATCH 00/29] staging: bcm2835-audio: Cleanups and fixes

Takashi Iwai
2018-09-10T09:16:11Z

On Mon, 10 Sep 2018 11:12:36 +0200,
Greg Kroah-Hartman wrote:
>
> On Sat, Sep 08, 2018 at 06:21:55PM +0200, Takashi Iwai wrote:
> > On Sat, 08 Sep 2018 15:18:10 +0200,
> > Stefan Wahren wrote:
> > >
> > > Hi Takashi,
> > >
> > > > Takashi Iwai <tiwai@suse.de> hat am 4. September 2018 um 17:58 geschrieben:
> > > >
> > > >
> > > > Hi,
> > > >
> > > > since I had an opportunity to play with RPi3B+ recently, I took a look
> > > > at the existing bcm2835-audio driver code and was amused very much :)
> > > >
> > > > So here is the result, a cleanup and fix patch series.
> > > >
> > > > Most of the patches are trivial cleanups, just brushing up, removing
> > > > many redundant and buggy codes, as well as code simplifications.
> > > >
> > > > A big functional change is that now it uses non-atomic PCM ops, so
> > > > that we can kill the ugly workqueue usages. Also, the resource
> > > > management was simplified.
> > >
> > > first of all, thank you very much for this series.
> > >
> > > Eric has no time as maintainer, so i will try to give you some feedback (beware of very little audio driver knowledge).
> > >
> > > I functionally tested your patch series on a Raspberry Pi 1 B (bcm2835_defconfig), so this whole series is at least:
> > >
> > > Tested-by: Stefan Wahren <stefan.wahren@i2se.com>
> >
> > OK, thanks, I'll put to my series in case of resubmission.
> > Meanwhile I'll keep the series in topic/vc04 branch of sound.git
> > tree.
>
> I'll just take this through my tree now, so there aren't merge issues if
> there happens to be other cleanups to the driver that show up in the
> near future.

OK, thanks!

Takashi