From: Krzysztof Kozlowski <krzk@kernel.org>
To: Gokul Sriram P <quic_gokulsri@quicinc.com>, q@krzk-bin
Cc: andersson@kernel.org, krzk+dt@kernel.org,
linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
quic_viswanat@quicinc.com, quic_mmanikan@quicinc.com,
quic_varada@quicinc.com, quic_srichara@quicinc.com
Subject: Re: [PATCH 1/2] dt-bindings: remoteproc: qcom: document hexagon based WCSS secure PIL
Date: Fri, 23 Aug 2024 15:47:43 +0200 [thread overview]
Message-ID: <2a8c20ce-0c90-4e59-ab77-7c71de21e502@kernel.org> (raw)
In-Reply-To: <982ca02e-a0b0-4dac-9294-ae2c2fb3463f@quicinc.com>
On 23/08/2024 11:47, Gokul Sriram P wrote:
>
> On 8/22/2024 5:00 PM, Krzysztof Kozlowski wrote:
>>> IM_SLEEP_CLK - Internal Module sleep clock needed for Q6 reset.
>>>
>>> SLEEP is not an acronym here.
>> Then probably you mean "Internal sleep", although "internal" is also
>> confusing. Devices do not receive as input something which is internal
>> to them.
>>
>>>>> +
>>>>> + clock-names:
>>>>> + items:
>>>>> + - const: im_sleep
>>>> sleep? Are there different sleep clocks here?
>>> We have different branches of sleep clk each enabled separately.
>>>
>>> im_sleep is one of those branches that q6 uses.
>> So this device misses other branches? Then provide them. Otherwise it is
>> just "sleep".
>
> ok, I shall keep it as simply "sleep" and move on? Other branches of
> sleep clk are irrelevant to remoteproc.
Then it is "sleep". The name here describes the clock input in this
device, not the clock in other places.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-08-23 13:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-20 8:55 [PATCH 0/4] Add new driver for WCSS secure PIL loading Gokul Sriram Palanisamy
2024-08-20 8:55 ` [PATCH 1/2] dt-bindings: remoteproc: qcom: document hexagon based WCSS secure PIL Gokul Sriram Palanisamy
2024-08-20 11:20 ` Krzysztof Kozlowski
2024-08-22 10:47 ` Gokul Sriram P
2024-08-22 11:30 ` Krzysztof Kozlowski
[not found] ` <982ca02e-a0b0-4dac-9294-ae2c2fb3463f@quicinc.com>
2024-08-23 13:47 ` Krzysztof Kozlowski [this message]
2024-08-20 8:55 ` [PATCH 2/2] remoteproc: qcom: add hexagon based WCSS secure PIL driver Gokul Sriram Palanisamy
2024-08-20 11:25 ` Krzysztof Kozlowski
2024-08-22 9:01 ` Gokul Sriram P
2024-08-20 8:55 ` [PATCH 3/4] arm64: dts: qcom: ipq5332: add nodes to bringup q6 Gokul Sriram Palanisamy
2024-08-20 11:21 ` Krzysztof Kozlowski
2024-08-22 10:38 ` Gokul Sriram P
2024-08-20 8:55 ` [PATCH 4/4] arm64: dts: qcom: ipq9574: add nodes to bring up q6 Gokul Sriram Palanisamy
2024-08-20 11:12 ` [PATCH 0/4] Add new driver for WCSS secure PIL loading Krzysztof Kozlowski
2024-08-22 10:43 ` Gokul Sriram P
2024-08-22 11:28 ` Krzysztof Kozlowski
2024-08-23 9:49 ` Gokul Sriram P
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a8c20ce-0c90-4e59-ab77-7c71de21e502@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=q@krzk-bin \
--cc=quic_gokulsri@quicinc.com \
--cc=quic_mmanikan@quicinc.com \
--cc=quic_srichara@quicinc.com \
--cc=quic_varada@quicinc.com \
--cc=quic_viswanat@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox