Re: [PATCH v13 48/53] ALSA: usb-audio: mixer: Add USB offloading mixer control

Takashi Iwai
2024-02-07T07:00:09Z

On Wed, 07 Feb 2024 02:24:46 +0100,
Wesley Cheng wrote:
>
> Hi Takashi,
>
> On 2/6/2024 4:57 AM, Takashi Iwai wrote:
> > On Sat, 03 Feb 2024 03:36:40 +0100,
> > Wesley Cheng wrote:
> >>
> >> In order to allow userspace/applications know about USB offloading status,
> >> expose a sound kcontrol that fetches information about which sound card
> >> index is associated with the ASoC platform card supporting offloading. In
> >> the USB audio offloading framework, the ASoC BE DAI link is the entity
> >> responsible for registering to the SOC USB layer. SOC USB will expose more
> >> details about the current offloading status, which includes the USB sound
> >> card and USB PCM device indexes currently being used.
> >>
> >> Signed-off-by: Wesley Cheng <quic_wcheng@quicinc.com>
> >
> > The concept is understandable, but the control element name ("SNDUSB
> > OFFLD playback available") looks non-intrusive and non-conformant.
> > Use a bit more understandable name instead.
> >
> > This provides a card number where the offload driver is bound, and the
> > name should indicate something about that.
> >
>
> Hmmm, does USB sound have a naming convention that it usually follows
> for mixer/control interfaces?

The old rule is found in Documentation/sound/designs/control-names.rst
(although the prefix and the suffix are often dropped for non-standard
controls).

> For something that is more closely related, how about:
> "USB offload capable card"

Yes, it looks better. But usually each word begins with an upper
letter.

Takashi