public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: peterz@infradead.org
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Oleg Nesterov <oleg@redhat.com>
Subject: Re: [PATCH] kernel: update callers of task_work_add() to use TWA_RESUME
Date: Mon, 10 Aug 2020 11:50:33 -0600	[thread overview]
Message-ID: <2aeafd33-7e26-cdfc-9a4c-98965faeccfb@kernel.dk> (raw)
In-Reply-To: <21d27dfe-91f8-ebc3-6390-a0345603ac28@kernel.dk>

On 8/10/20 8:37 AM, Jens Axboe wrote:
> On 8/10/20 5:44 AM, peterz@infradead.org wrote:
>> On Sat, Aug 08, 2020 at 03:43:50PM -0600, Jens Axboe wrote:
>>> Any pre-existing caller of this function uses 'true' to signal to use
>>> notifications or not, but we now also have signaled notifications.
>>> Update existing callers that specify 'true' for notify to use the
>>> updated TWA_RESUME instead.
>>>
>>> This was noted in the original commit as well:
>>>
>>> e91b48162332 ("task_work: teach task_work_add() to do signal_wake_up()")
>>>
>>> Cc: Oleg Nesterov <oleg@redhat.com>
>>> Cc: Peter Zijlstra <peterz@infradead.org>
>>> Signed-off-by: Jens Axboe <axboe@kernel.dk>
>>>
>>
>> Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
>>
>> How do you want to route this?
> 
> I don't really care, as I have no dependencies on it. Feel free to queue
> it up! It's just sitting at the top of my io_uring branch right now,
> but that's because I had to stuff it somewhere. Easy to pop off the top.

FWIW, I dropped this from my branch, so would be great if you or Oleg
could push this one upstream.

-- 
Jens Axboe


  reply	other threads:[~2020-08-10 17:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-08 21:43 [PATCH] kernel: update callers of task_work_add() to use TWA_RESUME Jens Axboe
2020-08-10 11:06 ` Oleg Nesterov
2020-08-10 11:44 ` peterz
2020-08-10 14:37   ` Jens Axboe
2020-08-10 17:50     ` Jens Axboe [this message]
2020-08-10 20:12       ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2aeafd33-7e26-cdfc-9a4c-98965faeccfb@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@redhat.com \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox