From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-179.mta1.migadu.com (out-179.mta1.migadu.com [95.215.58.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C26639C63D for ; Mon, 3 Aug 2026 19:48:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785786527; cv=none; b=OeVolLg1C7uZTeYYMYqu9s71ZwyTqFnrWoeEaE3b2MRqz40TxAiCz2EQmyyMPvaQs4sRPVPbbzqPPfB7ourkPz5hYOdQj1BRhv4yE6uju1F1b6JATFPkZR0TkRKuXK45dGw6LK95R2OI3Dg6tBaEu/rJtXBOOZqxCKVd04v4oOk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785786527; c=relaxed/simple; bh=MtrOz9e1XaQQI9fz0YpsBcbmXW3bvacusp8dfGi6s3Q=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=evx4g4BoyHt8AsqZrC2SeqjMTKLk9A0CrirxEj8ryCS5X123oZbjLaVK+oPO+kzTv/H9LHE72GicXX0DdC4HH26CdNESxxVJTlPii2Ej8vcxakhLRdmXnT1tzTGJkiwBEk+JJoCaRLDL3S6FSma6eCJh0a9v1jGptPzyvA5HJEU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=p3Mf2r5J; arc=none smtp.client-ip=95.215.58.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="p3Mf2r5J" Message-ID: <2af4a79b-8b97-47d7-9589-53ba9b2b9d2c@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1785786521; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pE0xBbCk1DUJFkU84tTR7Yk/pEsr/WpnPdo7d6grOuw=; b=p3Mf2r5Jkj53TzSjT5oq15UdVfRCDlLLBVu9a6Nos0ictHPRDO9AJ8h4/F0JN8zLgeEbZs A/ZVjXymGP9abxuNMjUoOI5UoW2SvZ9aW9x4TJx3uT2D896MnuULqMIiJaqGeh88RTwUm/ kQTkZUv6r1AyEbu5uw6kDhKGXAaLKi0= Date: Mon, 3 Aug 2026 12:48:13 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [bpf-next 2/4] selftests/bpf: add --no-error-summary to skip end-of-run error log dump To: bot+bpf-ci@kernel.org, bpf@vger.kernel.org, ast@kernel.org, eddyz87@gmail.com, andrii@kernel.org, ihor.solodrai@linux.dev Cc: linux-kernel@vger.kernel.org, daniel@iogearbox.net, martin.lau@kernel.org, yonghong.song@linux.dev, clm@meta.com References: <20260803170251.1898102-3-vineet.gupta@linux.dev> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Vineet Gupta Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 8/3/26 11:15 AM, bot+bpf-ci@kernel.org wrote: >> diff --git a/tools/testing/selftests/bpf/test_progs.c b/tools/testing/selftests/bpf/test_progs.c >> index aa06bab309665..8ee46745e2e85 100644 >> --- a/tools/testing/selftests/bpf/test_progs.c >> +++ b/tools/testing/selftests/bpf/test_progs.c > [ ... ] > >> @@ -1686,9 +1696,12 @@ static void calculate_summary_and_print_errors(struct test_env *env) >> * We only print error logs summary when there are failed tests and >> * verbose mode is not enabled. Otherwise, results may be inconsistent. >> * >> + * --no-error-summary only elides the human readable dump: the walk >> + * still happens so the JSON report keeps its per-test results. >> */ >> - if (!verbose() && fail_cnt) { >> - printf("\nAll error logs:\n"); >> + if (!verbose() && fail_cnt && (env->error_summary || w)) { >> + if (env->error_summary) >> + printf("\nAll error logs:\n"); > Does the comment match what the code does? The comment says "the walk > still happens", but the guard now requires either env->error_summary or w > to be non-NULL. > > When --no-error-summary is passed without --json-summary, both > env->error_summary and w are false/NULL, so the entire for loop at the > bottom of this function gets skipped, not just the human readable output. > > The walk does happen with --no-error-summary --json-summary FILE (where > w != NULL), but not in the no-JSON case. Could the comment be more > specific, maybe "the walk still happens when a JSON report was requested, > so the JSON report keeps its per-test results"? Good catch indeed the comment overstate it. Will reword in v2. Thx, -Vineet > --- > AI reviewed your patch. Please fix the bug or email reply why it's not a bug. > See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md > > CI run summary: https://github.com/kernel-patches/bpf/actions/runs/30836252778