From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF0C3379EDA for ; Thu, 7 May 2026 14:44:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778165057; cv=none; b=rIOSmGI5i7+Xef1hQ4elUCKcsUb9Ff3Vpb+mTqlyUL15vJuKg4kT0nM7pAc3H0lzmsi2xX1eePUOEeDY/cAgzMdMC+6NdVj7qY3oVrncKT8B9QkqEkN1tkbd5YH9J5W+vYYxuh5yQjRHDW+ixfBC/B/lsxbVvvENN0x1DpT6ClI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778165057; c=relaxed/simple; bh=yxxFW0lGHLlrJIKZ+qN8cjJC/Uz3gM3CTDcnUzHMmGc=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=DSTSihEOzMpz/80+In2q61XXOWIXvNMtUGpGQc6iUS67SJuXczh2ls80h4BbOodgUUv8NmZLPP4bA9rh9ubg+FIXF0NMBq1QnmbVN6grngitZqQM9TayfUK/zaHB3r7ymMJKAAJuOr6ZcC1lCziaTr69+GlJ9ObNyWH9RFURjbw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=EVVSz7wI; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=MRNhDBCi; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="EVVSz7wI"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="MRNhDBCi" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 647A4Pgo879573 for ; Thu, 7 May 2026 14:44:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= dZS4Z+n5yl3239JmhoNbCdzxJTz/lzr+NgykezCYlEg=; b=EVVSz7wIFyrLJmZz poqDC3p78W4clIeM/dnCNcNXkaMl9hccxhUDA1kztXGceFFPT1+RfYYwsNuym+wC 7u0waGaZrVg96sa7G0K2pUbTzqVaTsDioOnkmQO2Vim0bGqGiBk5A3oLZj9WUB3L YsZPwunY8DwBOQ4tXrKefPz/yHz2sXS6/tsNuR86NYl/kukj5WfyB7z2VwJ9kJJ9 Q7zJByAu6lYhRsxgK/M1IBILIdKVvdSBAv+gO/17XQ0pUssg7TBXcr7ZHyq4BBPD XqH88/Qw52PRlp7eOzVLy7oMp9D1uTpeC2gBw7vjvaKJdbKyTnMjUFO4461pg0FT o1qPWQ== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e0kdq2a2g-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 07 May 2026 14:44:14 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2babc42244aso17150815ad.3 for ; Thu, 07 May 2026 07:44:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778165054; x=1778769854; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=dZS4Z+n5yl3239JmhoNbCdzxJTz/lzr+NgykezCYlEg=; b=MRNhDBCiim1HPRHSWPiP0KkoDWe+UY5uuCW7+vN5p9EiIACvrxOhXDXlNWZREATz9u LbJwS6FFW15JXhW8MPt907x++4f1e3dZYiVhCwiw9RyAn8c75LzvWh8p9ybi2X5E83LN ry7xHSUpOForrVu3oWS/FVFjZbsiuV/dr8YpwpQVO+ZuQGvSbD+Ex4Dq9rFH+kQTB9Yi Qq1MnRfm3+6TIyv05FTRMcKaf0e/dVurtMH2cToMB2k0fyoRL6cOWCFDzhSk40Hf398R L8fbx/ZewUAXx/ZjNVv+pMB8phjLR/+WdYAW6lqhq7kbECqVQHDjzFXkoylk7Dg2cEPy pqIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778165054; x=1778769854; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dZS4Z+n5yl3239JmhoNbCdzxJTz/lzr+NgykezCYlEg=; b=H/hPFZIMPWtdqPezU6T74Lxqvttstwe88ZFOZiyL3D+Iya61ErnXzMwbAf80S0UNlE w/uKcus/Khr5M33akjy5WnBFw8mXAw+UIR9gX4atI8Vm6A1WslJfuxIB4vzqC96mn1is InwOQXArwU0m5cjmTmmzeFswcZn83bsnPXTiBhaBq/POTd0V1dpNNI+EJ0e6wBAUExtN rNstg1IvAk/djiAUs0oc1yJpdCIHU896YCZNN22VoYweGCUySnGLKaRD7BNi8gBkZp6n vXhUJUsEmsZGED5oXHtosfBdjist+SRgBlOW8+OSuHVQisQ167ADfMn1NxJeAGn5AeeS LKbw== X-Forwarded-Encrypted: i=1; AFNElJ8CvjRXd7xVwubK3hU8fFMhQrClrINZ+Ie08s8JuRrvtLEeBOFS3O7FSvo7Nv5QqLvmufjVhu7J5ZZ4eas=@vger.kernel.org X-Gm-Message-State: AOJu0YxARgBwau8a5hcaTEgz04HrRk9u0/Vw0PaJ4Tr+1Rbz38HnPw6r pkbb938gqGsM9vvpZ2MFAcU1zaBd9TbVw+bPvo6Dhh3ZV/rn5FrtIETVlHVb7kubp5br4EGFtSk zvL0fPPWBbn9K1j8R9WDbfeObaFT8tqX1dB2Q6gDQEeFHivhLoxCMs5MZEL8rHaAyNRc= X-Gm-Gg: AeBDiet3lohSJ6z+bC8XrAky38Gpfqnp1sXLnOpmlLhZY3a5mp/qQdFGtnlOOAN2Lbu lzFanG5QXxuMIllhKAtxhKfMCWMbZ6DYXfgOQiupIsVkOJ0HWpT2zPJvS3mFvnffbX+aKIUw1o6 DHUiat+4sACnsVvv2xXtT7IE2xDKIZ0xvUzFcuWQK5sr9LPDgSs881C7cxIf5rqPodBkYOZ+TNL Vs5F6GZemppGOCXA/SjXIJWVaXQcnTFke1zTAKSCPnUABDnMsfMcK6cuXyJtkJKczzptVM3tgYX abZ9xYhUlU6fDSUfHGB983B41Vq4YzihKzJft0zqgxlskRdt3lxXWfR3u4r0eIK/ioWD/jJtzo9 Ia9fo90v2LZM3DNfPYT00RWy66Hu+Jl4BbCMaovwuZsVrNuGXimOaVxA= X-Received: by 2002:a05:6a21:6d82:b0:3a2:ecb8:56f0 with SMTP id adf61e73a8af0-3aa5aaf65f0mr8713546637.33.1778165053537; Thu, 07 May 2026 07:44:13 -0700 (PDT) X-Received: by 2002:a05:6a21:6d82:b0:3a2:ecb8:56f0 with SMTP id adf61e73a8af0-3aa5aaf65f0mr8713494637.33.1778165053030; Thu, 07 May 2026 07:44:13 -0700 (PDT) Received: from [10.206.103.12] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-83965c30ddasm11425000b3a.21.2026.05.07.07.44.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 May 2026 07:44:12 -0700 (PDT) Message-ID: <2b3e5751-4de1-45fa-95a4-6d3d69fbe2dc@oss.qualcomm.com> Date: Thu, 7 May 2026 20:14:06 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Akhil P Oommen Subject: Re: [PATCH v4 16/29] drm/msm/adreno: write reserved UBWC-related bits To: Dmitry Baryshkov , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260507-ubwc-rework-v4-0-c19593d20c1d@oss.qualcomm.com> <20260507-ubwc-rework-v4-16-c19593d20c1d@oss.qualcomm.com> Content-Language: en-US In-Reply-To: <20260507-ubwc-rework-v4-16-c19593d20c1d@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=P6IKQCAu c=1 sm=1 tr=0 ts=69fca53e cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=ZswEv4b9r44Tze3PQiwA:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-ORIG-GUID: etUhnYBJH0JLWhXOWbL_BQc9a0Op-R7q X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA3MDE0NyBTYWx0ZWRfX3rUMoSGxb0Ql GQdzcZQszY1hxK/pVfFLci5GNdzZV7kiPojc6lo3n/kqLpRvBBMLknwfL/mRBYsuE6YLsN5sQ0w +JkrOvNp5G46WtBYwX1wRZn8O+qyNCKFzuYx4mQJn11tCnY1WdgJkD8l2X+Uk9M9LEL9JYS7bSs ghzF7WMhxgGCt1RJejSvqeV3ZZ4IzRdl507nax4mGjoXuqiQv0lkzgS8pkO0hHYgrzK4LEznreh IwTDv+fnnxf/3lPBHE+JtEZwvdmzuYjcpE0zfT0NW/J88GaSxjH5cbe0qZzVbtg0VAU0Yz4zLdD C+1S2RGVFEqn/X7neihu6v6LR/4ex/BmHzUd/tWb3OtcVk4ieUWxs/1cDvOYeCBSJ3De3bL81KZ xOh28wZuRcfO3MqkGXJUY+CAs5cyXMlnrovlPpG4vijRFbNRRJp8vdRv/yKZyU3txbC3eRQSyXn 5+MEabsSP6A32OKgNkA== X-Proofpoint-GUID: etUhnYBJH0JLWhXOWbL_BQc9a0Op-R7q X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-07_01,2026-05-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 suspectscore=0 clxscore=1015 bulkscore=0 spamscore=0 lowpriorityscore=0 malwarescore=0 adultscore=0 priorityscore=1501 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605070147 On 5/7/2026 6:33 PM, Dmitry Baryshkov wrote: > On the latest A8xx Adreno chips several of the bits in the UBWC-related > registers are now hardwired to 1. Currently the driver doesn't write > them because there is no side-effect. In the preparation for the > refactoring in the next patch, write '1' to those bits anyway. > > Signed-off-by: Dmitry Baryshkov Reviewed-by: Akhil P Oommen -Akhil > --- > drivers/gpu/drm/msm/adreno/a8xx_gpu.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/msm/adreno/a8xx_gpu.c b/drivers/gpu/drm/msm/adreno/a8xx_gpu.c > index 53def136e0fc..7a6223ddd8cf 100644 > --- a/drivers/gpu/drm/msm/adreno/a8xx_gpu.c > +++ b/drivers/gpu/drm/msm/adreno/a8xx_gpu.c > @@ -288,6 +288,8 @@ static void a8xx_set_ubwc_config(struct msm_gpu *gpu) > switch (ubwc_version) { > case UBWC_6_0: > yuvnotcomptofc = true; > + amsbc = true; > + rgb565_predicator = true; > break; > case UBWC_5_0: > amsbc = true; >