Re: [PATCH 1/3] dt-bindings: spi: Add VIA/WonderMedia serial flash controller

[Krzysztof Kozlowski <krzk@kernel.org>]

On 15/05/2025 21:50, Alexey Charkov wrote:
>>> +
>>> +  "#address-cells":
>>> +    const: 1
>>> +
>>> +  "#size-cells":
>>> +    const: 0
>>
>> This follows the SPI binding, right? Drop these 2 and add a $ref to
>> spi-controller.yaml.
> 
> Need some advice here. While this controller speaks SPI protocol to
> its connected flash chips, it's a special-purpose thing that doesn't
> expose much SPI functionality to the outside world, nor can it drive
> any SPI devices other than SPI NOR flash. Does that still qualify as
> an SPI controller as far as the bindings are concerned?
> 
> Happy to reference the spi-controller.yaml binding if so.

SPI NOR flashes are still child devices of an SPI controller. You can
look at other examples - aren't they all using spi-controller? Why this
would be different? Unless you found some cases that are different, but
then which ones?



Best regards,
Krzysztof