From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70E7A62809 for ; Thu, 7 May 2026 09:42:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778146956; cv=none; b=IWYjodfKUr1dgPuI0EkpYWmztySemzHDraIlamrT4LYQbIK81Nd9CxzQWv9s5ztQ87HhscM6T5+zt98ggVZ2kbMQZQOJcCpFFOWCSArRHEwt7izBpz8BXTg92er+xh/iq+vWwlovpusD/uHmxRqZhnJ8xcB5CGn0AIEL2KJp/Fs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778146956; c=relaxed/simple; bh=JKeHjw5d+vS95B0gqhrrMQ08nSofzwyMUDvN6S3xMYs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=h/4uP8bRwzWlRFrwUUxiMHhNK6B+HWrwtC9Czq9sfj1eI+u+dBH8JOjPM45w8D6Dcbjz/kZmfr7X0QVMETh0UApM3TAljeBXl0KYfGzt4A875Y08VeqvFAhbi5WYrb57gLTzNVqeqRqvlCSiiaW76iht62ypaNOcxXka+W9vtCc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=b6ZXSnRz; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=DnpPsYZB; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="b6ZXSnRz"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="DnpPsYZB" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778146954; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=j0bzjHNwg/4dsgcGNIVawkmXretC17GVDXq9ice+Mi4=; b=b6ZXSnRznVTmLnm3c61UgV+tlHmixko3dThW3HKSmXJWyUTrsTj+MtzZFaFeB3B3e2tTpz UHv/xCZoyQVkOS2FI+xeKsIrG5tOp1tS9TLBS5X38WjqXyUjZZwDwyZc8FPCiC5kSN2ufV Jm1eFiGZPRX3OaxBe7byHIdAzNF9K1Q= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-661-BCJ1gNvRNdmJerlFC5ivcw-1; Thu, 07 May 2026 05:42:33 -0400 X-MC-Unique: BCJ1gNvRNdmJerlFC5ivcw-1 X-Mimecast-MFC-AGG-ID: BCJ1gNvRNdmJerlFC5ivcw_1778146952 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-48a5952c635so6275825e9.2 for ; Thu, 07 May 2026 02:42:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1778146952; x=1778751752; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=j0bzjHNwg/4dsgcGNIVawkmXretC17GVDXq9ice+Mi4=; b=DnpPsYZBmVBhZ4FEQHpizHlahQEuoX7d7byKXdU292DlgmZXBSGE8I4ZBxGD7qiDlL nqzHe2cc1NyBGZNhjd88Il//7WgNuopiMo22ehL3E+YXhOiWVlPS6D/tKt0L+4LWMPHL SCxuZ2W9qlSFp7J5EfkWIdB4rz9F1Q1w79pg1I0D23RJrCGCRVB9HhwhX4/8Fk8LHl/Q 0D6v+MrJkeB5bFIskJUv75t5BGD88UGG9nbLGBeVhMjLRpEAZ3BIElxrGB4Zjq12DPYc SITtQsOrlgKfT6u6WFudY/tLLgDt8/P4BnhL2Tqa21dg7v74ko8d5vYmD+Q+/1t1+PA2 oDEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778146952; x=1778751752; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=j0bzjHNwg/4dsgcGNIVawkmXretC17GVDXq9ice+Mi4=; b=f/hPm4d8QQYkQty9dlDXQ/XWrCGvu4tuWeiySfhkcoLPVtv0j+nZG0RWhKa5aP8u4r +JpwK31u5EgY+J/k0S0AExuTRbEjh5CSYZkNClrg+R3Rq1c5zuBO26Zam4D7IXIlf04+ +H+Y/awzPlmmVuoSH7A2ptWA2IHPuX8p80/PEeg4H9bw3Lly1zmw98JNHHN3Ico1tnoC Fu0lZabIyf7POmQBH6WFw/lZ9hA9C3tbvlbo2U20Ctxk3h9U4fIpwC4oXeeytsUKryzx MWlReO7iscKpY+DX2qVnBGQ82usBSfs/I28xyb+ExcyGBTB3pKGHE+OwzDdjCji75Yhg UBVw== X-Forwarded-Encrypted: i=1; AFNElJ+KbdC8hgv/Ti0J0qRvcpebyGJPB9h3tArB12YHCDXR57r86PpeynGlPP02J9b9WyD02WPd21klUAG05+0=@vger.kernel.org X-Gm-Message-State: AOJu0YxTCNzLFUjtMLlzZg5+wWpTo8CyU83z1uesL3ReuzwpV0ob/sMS pFzha2kJNwIXUT1NFJyGq94hm4iiSghRIBgVOHAMrheVo4S0JyequbFt3p7VBxdX9znEvuRmyel Yqkc+3EnPFjeYXPrAsai3JOJr7dF0MoeEN/aEjlcH5xDW/VqnWMDdoCRZg8qBjGABzBVxfhr3qw == X-Gm-Gg: AeBDiesQ6yFgWn3z2J7PnV/3dSMgQyKGYB7oxM043DHgfpr0kWt2oKnJEprq3KgXLFa fQHpautfx9+Xuwy/Nchbx5I5h2IG4SzbbtSLrana0Zq9pXjdxk5YirC018uf/LinNI129ZDtQZ4 XAtCYdSWUn4zdZmWWjL7RHjn78kCUyUZA019cdAi3VPAz25cUFWbtFrXL2VXfNbTVbbfcFeHSY3 fqCTMb/G+JsBpHr1lZmSlk7+4auh+6yMBp1FxR2rHjem/WZhMu0MRMFoDgysBYFH9Agh1F3QJuu nqsM9Me1m8gHjQakogPQkgtThAv5xunPdV58VODsKLQkGUVxhKrtOkEnWODs6JgU7wyvEz+Lm3k w2vvg6c7Vu5LiEnO8BLigRijoVMjTSpJbjx8jSlAfUfui4E246fEJOfAYtLwPETScsg== X-Received: by 2002:a05:600c:b8a:b0:48a:56de:d620 with SMTP id 5b1f17b1804b1-48e51f32ac3mr119824585e9.14.1778146951909; Thu, 07 May 2026 02:42:31 -0700 (PDT) X-Received: by 2002:a05:600c:b8a:b0:48a:56de:d620 with SMTP id 5b1f17b1804b1-48e51f32ac3mr119824225e9.14.1778146951416; Thu, 07 May 2026 02:42:31 -0700 (PDT) Received: from [192.168.88.32] ([150.228.93.82]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48e538fad5fsm121570435e9.10.2026.05.07.02.42.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 May 2026 02:42:30 -0700 (PDT) Message-ID: <2b583f22-4f34-4c7b-99c4-ade2431070b3@redhat.com> Date: Thu, 7 May 2026 11:42:29 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v6 04/10] enic: add admin CQ service with MSI-X interrupt and NAPI polling To: Satish Kharat , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Sesidhar Baddela References: <20260503-enic-sriov-v2-admin-channel-v2-v6-0-0af4fbc2d86d@cisco.com> <20260503-enic-sriov-v2-admin-channel-v2-v6-4-0af4fbc2d86d@cisco.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20260503-enic-sriov-v2-admin-channel-v2-v6-4-0af4fbc2d86d@cisco.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/3/26 1:22 PM, Satish Kharat wrote: > +static void enic_admin_msg_enqueue(struct enic *enic, void *buf, > + unsigned int len) > +{ > + struct enic_admin_msg *msg; > + > + msg = kmalloc(struct_size(msg, data, len), GFP_ATOMIC); > + if (!msg) { > + enic->admin_msg_drop_cnt++; > + if (net_ratelimit()) > + netdev_warn(enic->netdev, > + "admin msg enqueue drop (len=%u drops=%llu)\n", > + len, enic->admin_msg_drop_cnt); Failed allocation will splat dmesg; no need to added additional error messages (here and elsewhere in the series). /P