From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E214C4338F for ; Tue, 24 Aug 2021 15:52:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 880CF611C8 for ; Tue, 24 Aug 2021 15:52:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238304AbhHXPwu (ORCPT ); Tue, 24 Aug 2021 11:52:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40938 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238411AbhHXPwr (ORCPT ); Tue, 24 Aug 2021 11:52:47 -0400 Received: from mail-io1-xd33.google.com (mail-io1-xd33.google.com [IPv6:2607:f8b0:4864:20::d33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE52CC0613C1 for ; Tue, 24 Aug 2021 08:52:02 -0700 (PDT) Received: by mail-io1-xd33.google.com with SMTP id q3so9540150iot.3 for ; Tue, 24 Aug 2021 08:52:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=G9UnSSnlYRLUttWk790OTUp3vVDNhuFNpjJPwPR33gg=; b=eiDog05hn6geYVERCCz83M7DncCeFgjW4iVb4MF6TQEZkST+XbuWGBUN1J6xMd4+Jf oM6/wKi3lPr7xBEq/SDCgNOErb+C8y5w78/D3J30mqecQNi6O/28hBNP1LgaZjVpIfoq tgO3TkEdbvxp+lDdPSMN9Ujo3Q7e2wtUN10sM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=G9UnSSnlYRLUttWk790OTUp3vVDNhuFNpjJPwPR33gg=; b=BEjfJ97/w1yR6CihGGMaV2IEx5v5wxD2rxZa2Gh2Es3Ijt4Q486IhKDiNZ+fvNdUpR ZZsY5B5lZQYd83QTEravzrJJNXO7NsMW0MiyFP/4EhL4N5GjHdO9Nd0Iua6BihF0aWOR ztymxTLMi7F7/TvaSuIvsLIMtBXI87JxF5oqMSWbdt/r+9utVqapJn6Y6O8pQSwiIBIl 4x0h/TpVB/f7W8inTawY0pPIeV2DvYufb5naM1SRQC5qML5SGSHor27+ZT01Z8UHaCZP TELQmB6NzjR8mLJe8Vm+xfM8MT5qPkdMN0Szyrtg5CdbUhuPTivLz8JobIND1mG4MgUj SyAA== X-Gm-Message-State: AOAM5336aNPLq5r5NmEPsFsFSM78oXWloev0ZkOj8cTVjrY44WivKMw4 gu/4gVZOGmStJO35lde73uKI0A== X-Google-Smtp-Source: ABdhPJw12PHQe4ldQaJd+CQv6s5KafuQsOqHWMdAGHu+kcNMgcpKWej3e22m86/A7SuIEuuLmE4LnQ== X-Received: by 2002:a05:6638:1504:: with SMTP id b4mr32944162jat.144.1629820321934; Tue, 24 Aug 2021 08:52:01 -0700 (PDT) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id c25sm10609598iom.9.2021.08.24.08.52.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Aug 2021 08:52:01 -0700 (PDT) Subject: Re: [PATCH linux-next] tools:test_xdp_noinline: fix boolreturn.cocci warnings To: Jakub Kicinski Cc: CGEL , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Yonghong Song , netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Jing Yangyang , Zeal Robot , Shuah Khan References: <20210824065526.60416-1-deng.changcheng@zte.com.cn> <2d701f13-8996-ed7d-3d41-794aa8a6e96c@linuxfoundation.org> <20210824074657.363455a6@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> From: Shuah Khan Message-ID: <2b6bf2fa-cf40-9610-ede5-ceab35004864@linuxfoundation.org> Date: Tue, 24 Aug 2021 09:52:00 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210824074657.363455a6@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/24/21 8:46 AM, Jakub Kicinski wrote: > On Tue, 24 Aug 2021 08:42:15 -0600 Shuah Khan wrote: >> On 8/24/21 12:55 AM, CGEL wrote: >>> From: Jing Yangyang >>> >>> Return statements in functions returning bool should use true/false >>> instead of 1/0. >>> >>> Reported-by: Zeal Robot >>> Signed-off-by: Jing Yangyang >> >> We can't accept this patch. The from and Signed-off-by don't match. > > That's what I thought but there is a From in the email body which git > will pick up. The submission is correct. > Missed that. Thanks. > Please trim your responses. > Will do. thanks, -- Shuah