From: Sergei Shtylyov <sergei.shtylyov@gmail.com>
To: Menglong Dong <menglong8.dong@gmail.com>, axboe@kernel.dk
Cc: linux-ide@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Menglong Dong <dong.menglong@zte.com.cn>
Subject: Re: [PATCH] ata: remove redundant error print in rb532_pata_driver_probe
Date: Thu, 14 Jan 2021 11:29:57 +0300 [thread overview]
Message-ID: <2b6dcfbf-d534-4a2a-53e0-c942a9120a0f@gmail.com> (raw)
In-Reply-To: <CADxym3bzFPeCXzkO1iFy+Sx7GhwRGo=VkOUzrDE4KMCjMx0v-w@mail.gmail.com>
Hello!
On 13.01.2021 17:04, Menglong Dong wrote:
[...]
>>> irq = platform_get_irq(pdev, 0);
>>> - if (irq <= 0) {
>>> - dev_err(&pdev->dev, "no IRQ resource found\n");
>>> + if (irq <= 0)
>>> return -ENOENT;
>>
>> This still beaks the probe deferral. :-(
>> But that's another problem...
>>
>> [...]
>>
>> MBR, Sergei
>
> What does this 'MBR' mean? I am a novice~~~
Generally speaking, Master Boot Record. But I also use it to send you My
Best Regards. :-)
> So, is it better to replace 'platform_get_irq' with
> 'platform_get_irq_optional' here?
No. You should stop overriding the result to -ENOENT and pass the result
up the call chain instead. In order to do it, you should only check for (irq < 0).
> --
> Best Regards
> Menglong Dong
MBR, Sergei
next prev parent reply other threads:[~2021-01-14 8:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-12 2:36 [PATCH] ata: remove redundant error print in rb532_pata_driver_probe menglong8.dong
2021-01-12 11:15 ` Sergei Shtylyov
2021-01-13 14:04 ` Menglong Dong
2021-01-14 8:29 ` Sergei Shtylyov [this message]
2021-01-14 14:53 ` Menglong Dong
2021-01-14 15:49 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b6dcfbf-d534-4a2a-53e0-c942a9120a0f@gmail.com \
--to=sergei.shtylyov@gmail.com \
--cc=axboe@kernel.dk \
--cc=dong.menglong@zte.com.cn \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=menglong8.dong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox