public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ross Lagerwall <ross.lagerwall@citrix.com>
To: Long Li <longli@microsoft.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	KY Srinivasan <kys@microsoft.com>
Cc: "James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] scsi: devinfo: Add Microsoft iSCSI target to 1024 sector blacklist
Date: Thu, 5 Apr 2018 17:58:13 +0100	[thread overview]
Message-ID: <2b7a3146-e2e4-699f-5633-13d8b568786d@citrix.com> (raw)
In-Reply-To: <MWHPR2101MB0729E7680EDB0EE4886AAED1CEA30@MWHPR2101MB0729.namprd21.prod.outlook.com>

On 03/28/2018 11:33 PM, Long Li wrote:
>> Subject: Re: [PATCH] scsi: devinfo: Add Microsoft iSCSI target to 1024 sector
>> blacklist
>>
>>
>> Long, KY: Please confirm.
>>
>>> The Windows Server 2016 iSCSI target doesn't work with the Linux
>>> kernel initiator since the kernel started sending larger requests by
>>> default, nor does it implement the block limits VPD page. Apply the
>>> sector limit workaround for these targets.
>>>
>>> Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com>
>>> ---
>>>   drivers/scsi/scsi_devinfo.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c
>>> index f3b1172..5cb748a 100644
>>> --- a/drivers/scsi/scsi_devinfo.c
>>> +++ b/drivers/scsi/scsi_devinfo.c
>>> @@ -213,7 +213,7 @@ static struct {
>>>   	{"Medion", "Flash XL  MMC/SD", "2.6D", BLIST_FORCELUN},
>>>   	{"MegaRAID", "LD", NULL, BLIST_FORCELUN},
>>>   	{"MICROP", "4110", NULL, BLIST_NOTQ},
>>> -	{"MSFT", "Virtual HD", NULL, BLIST_NO_RSOC},
>>> +	{"MSFT", "Virtual HD", NULL, BLIST_MAX_1024 | BLIST_NO_RSOC},
> 
> Ross,
> 
> What about storage_channel_properties.max_transfer_bytes returned from VSTOR_OPERATION_QUERY_PROPERTIES (in storvsc_channel_init())
> 
> Does it return correctly the maximum transfer size for iSCSI?
> 

I presume you're referring to the Hyper-V virtual storage driver? This 
has nothing to do with that module -- I don't even have it compiled in. 
It's just simply the Linux kernel initiator connecting over plain 
software iSCSI to a Windows Server 2016 iSCSI target.

This is easy enough to reproduce. Just set up a Windows Server 2016 
target and try and use it from Linux. You get I/O errors as soon as you 
try and format the disk.

Cheers,
-- 
Ross Lagerwall

  reply	other threads:[~2018-04-05 17:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-26 13:56 [PATCH] scsi: devinfo: Add Microsoft iSCSI target to 1024 sector blacklist Ross Lagerwall
2018-03-28 21:49 ` Martin K. Petersen
2018-03-28 22:33   ` Long Li
2018-04-05 16:58     ` Ross Lagerwall [this message]
2018-04-05 19:52       ` KY Srinivasan
2018-04-10  2:07 ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2b7a3146-e2e4-699f-5633-13d8b568786d@citrix.com \
    --to=ross.lagerwall@citrix.com \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=kys@microsoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=longli@microsoft.com \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox