public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Shuah Khan <skhan@linuxfoundation.org>
To: Laura Nao <laura.nao@collabora.com>
Cc: gregkh@linuxfoundation.org, kernel@collabora.com,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	nfraprado@collabora.com, shuah@kernel.org,
	Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] selftests: ksft: Track skipped tests when finishing the test suite
Date: Mon, 29 Jul 2024 14:06:41 -0600	[thread overview]
Message-ID: <2bb2d338-cd00-4ac2-b8bd-5579eae82637@linuxfoundation.org> (raw)
In-Reply-To: <20240729145222.119830-1-laura.nao@collabora.com>

On 7/29/24 08:52, Laura Nao wrote:
> Hi Shuah,
> 
> On 7/23/24 18:17, Shuah Khan wrote:
>> On 7/22/24 09:43, Laura Nao wrote:
>>> Consider skipped tests in addition to passed tests when evaluating the
>>> overall result of the test suite in the finished() helper.
>>>

I am finally with you now. Can you please more information in your
short log and commit log.

Isn't this a bug fix? Current logic before this change will report
tests failed if there are any skipped tests?

Can you send v2 calling it a fix and explain the problem clearly.
  
This isn't problem in this patch, but I am concerned about how
simply calling tests passed without calling out skipped tests.

This problem could be solved by printing a message at the end of tests
for non-zero skipped test conditions to say the coverage could be
increased by enabling config options.

thanks,
-- Shuah

  reply	other threads:[~2024-07-29 20:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-22 15:43 [PATCH] selftests: ksft: Track skipped tests when finishing the test suite Laura Nao
2024-07-22 17:32 ` Shuah Khan
2024-07-22 18:42   ` Shuah Khan
2024-07-22 18:51   ` Nícolas F. R. A. Prado
2024-07-23 14:06     ` Laura Nao
2024-07-23 16:17 ` Shuah Khan
2024-07-29 14:52   ` Laura Nao
2024-07-29 20:06     ` Shuah Khan [this message]
2024-07-30 10:35       ` Laura Nao
2024-07-31 23:04         ` Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2bb2d338-cd00-4ac2-b8bd-5579eae82637@linuxfoundation.org \
    --to=skhan@linuxfoundation.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel@collabora.com \
    --cc=laura.nao@collabora.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=nfraprado@collabora.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox