From: Dmitry Osipenko <digetx@gmail.com>
To: Jon Hunter <jonathanh@nvidia.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Thierry Reding <thierry.reding@gmail.com>,
Ben Dooks <ben.dooks@codethink.co.uk>
Cc: alsa-devel@alsa-project.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] Revert "ASoC: tegra: Allow 24bit and 32bit samples"
Date: Fri, 31 Jan 2020 18:38:54 +0300 [thread overview]
Message-ID: <2bb53d7d-2d36-e16e-5858-24360b19f936@gmail.com> (raw)
In-Reply-To: <20200131091901.13014-1-jonathanh@nvidia.com>
31.01.2020 12:19, Jon Hunter пишет:
> Commit f3ee99087c8ca0ecfdd549ef5a94f557c42d5428 ("ASoC: tegra: Allow
> 24bit and 32bit samples") added 24-bit and 32-bit support for to the
> Tegra30 I2S driver. However, there are two additional commits that are
> also needed to get 24-bit and 32-bit support to work correctly. These
> commits are not yet applied because there are still some review comments
> that need to be addressed. With only this change applied, 24-bit and
> 32-bit support is advertised by the I2S driver, but it does not work and
> the audio is distorted. Therefore, revert this patch for now until the
> other changes are also ready.
>
> Furthermore, a clock issue with 24-bit support has been identified with
> this change and so if we revert this now, we can also fix that in the
> updated version.
>
> Cc: stable@vger.kernel.org
>
> Reported-by: Dmitry Osipenko <digetx@gmail.com>
> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
> ---
Thanks, Jon!
Tested-by: Dmitry Osipenko <digetx@gmail.com>
Ben, looking forward to have 24bit working in 5.7 :)
next prev parent reply other threads:[~2020-01-31 15:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-31 9:19 [PATCH] Revert "ASoC: tegra: Allow 24bit and 32bit samples" Jon Hunter
2020-01-31 15:38 ` Dmitry Osipenko [this message]
2020-01-31 16:08 ` Jon Hunter
2020-02-01 11:27 ` Mark Brown
2020-02-02 12:08 ` Applied "ASoC: tegra: Revert 24 and 32 bit support" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2bb53d7d-2d36-e16e-5858-24360b19f936@gmail.com \
--to=digetx@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=ben.dooks@codethink.co.uk \
--cc=broonie@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=perex@perex.cz \
--cc=stable@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox