From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754322AbcICQlU (ORCPT ); Sat, 3 Sep 2016 12:41:20 -0400 Received: from mout.web.de ([212.227.15.14]:54414 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753253AbcICQlR (ORCPT ); Sat, 3 Sep 2016 12:41:17 -0400 Subject: [PATCH 3/4] sparc: bpf_jit: Avoid assignment for "flen" if BPF JIT is disabled To: sparclinux@vger.kernel.org, Adam Buchbinder , Alexei Starovoitov , Daniel Borkmann , "David S. Miller" , Rabin Vincent References: <566ABCD9.1060404@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall , Paolo Bonzini From: SF Markus Elfring Message-ID: <2bd51cac-bbb7-da76-9648-4ae24ba342b2@users.sourceforge.net> Date: Sat, 3 Sep 2016 18:40:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:nQSkerBYee4rMTNGgzyWEs/sy0fkntHBMdslQDCd6YEt5LYBuN1 pOrHU3qZLR1vof2IkDgkVq1vN9/QiMzslT8XpjS2IFSiuw7/pSmFM7TY9rL/vg54SCf7I3b WTccNTgEg5+WnVJ5DXZfqLQE6T7avq2+fGPeaYRbe1NlO+1RvMyXJlLVvn9i6qFPT40+cGE zmiugT46AQrX/Npx6UCtw== X-UI-Out-Filterresults: notjunk:1;V01:K0:0D5VKY8OBh8=:Zq9xFpohD/ZgZUspPeV3s9 6fhoszgCgGVMCFQliQ5Ya7VNrjNxPAUxUxoJVMOG8FGt24ctqheD5m+sCWeQtyq8RRejc5yV5 IiN+0oUAQPZdrgCrTtxh49aHp6oRiaECN3iKw+gqn8szWpsEbI4fGdja9YPc5bZehyQPcR9bT Ku2tNF8h1Yz+kBnQ2rp4NaDXfOrafs99QuIGf3+7lXc8oy8f5cXWEsXjAkXR+ZKPmRqOKJ9il S9LmcZKY0tc43zW1A7x155/X2ZFAvrlGctGIUzS9bhc1ORbvOTEJlgHiPM8stIxjF4HKs7lYU THgbn8i0NuWj/ZKv3GUkaJICdqzlG0AiJHuB5eKCJQawb/i4Wza7+sxXpgcaofyD0GJe/Xdss igploRmPtlenimo4HGKZ0PHHKLiG0jWV+fGnmMHFA8ptQrbQitLgoXLc9MaiXZHQc8QXIKXRr I/pEH7pKEG3BhkKJoqZXAGp0zkA2VZPimZKmMjM0MOQQ8tCHMI9A1uLIIE0HX0/kGj7YQeEwQ 5Y21fow78oxYAr8Yvn3VS9KeXEqch7x0RA9d1lgOlBIbfTRovDNixDNrxaGcLcC/cWTA26tMr CDT94U2OM2eA9GutEkOxQ2nN6y6ppWdckS1tryWbIPiXJ7wrFrt9gFTmZyAZhFbUde8R5CcdN KPNsd+u0AV8Q/0QDqdqd7WjrN4UOZHPDaVLwajfREjx2bVGvSZgUI4N/1wu2+6Z+UI2/VvvmR WqTavUDRMqREU22Aysfs9qonZ2DXtnYkMF6tJlNqj7+7wxEPA+s/4MA4DOdm82UvMPU0Ebd9N 2Jhc5ae Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 3 Sep 2016 18:00:03 +0200 Move the assignment for the local variable "flen" a bit at the beginning so that it will only be performed if BPF JIT is enabled for this function. Signed-off-by: Markus Elfring --- arch/sparc/net/bpf_jit_comp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/sparc/net/bpf_jit_comp.c b/arch/sparc/net/bpf_jit_comp.c index a927470..a6b6e29 100644 --- a/arch/sparc/net/bpf_jit_comp.c +++ b/arch/sparc/net/bpf_jit_comp.c @@ -365,13 +365,14 @@ void bpf_jit_compile(struct bpf_prog *fp) unsigned int cleanup_addr, proglen, oldproglen; u32 temp[8], *prog, *func, seen, pass; const struct sock_filter *filter; - int i, flen = fp->len, pc_ret0; + int i, flen, pc_ret0; unsigned int *addrs; void *image; if (!bpf_jit_enable) return; + flen = fp->len; addrs = kmalloc_array(flen, sizeof(*addrs), GFP_KERNEL); if (addrs == NULL) return; -- 2.9.3