From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932373AbZE3PIJ (ORCPT ); Sat, 30 May 2009 11:08:09 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759451AbZE3PH5 (ORCPT ); Sat, 30 May 2009 11:07:57 -0400 Received: from mail-gx0-f214.google.com ([209.85.217.214]:41741 "EHLO mail-gx0-f214.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759236AbZE3PH4 convert rfc822-to-8bit (ORCPT ); Sat, 30 May 2009 11:07:56 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding; b=F6sI6dFjwPi9KlRCa26r3eJJoADIOGFhXQTPdpV4JaXMAKKt5iRxYAH6WJIN2GLD59 UrqklnFWADw5a0GwO3pDBQFsRUGRG88UtdFd1I/qj/mI2QK/QjsALdBcpA35rd/0U8HJ ajcLeE4vFbYNBV03wVSMetz17ZMVvAybhaVMg= MIME-Version: 1.0 In-Reply-To: <20090530082048.GM29711@oblivion.subreption.com> References: <20090522113809.GB13971@oblivion.subreption.com> <4A187BDE.5070601@redhat.com> <20090527223421.GA9503@elte.hu> <20090528072702.796622b6@lxorguk.ukuu.org.uk> <20090528090836.GB6715@elte.hu> <20090528125042.28c2676f@lxorguk.ukuu.org.uk> <84144f020905300035g1d5461f9n9863d4dcdb6adac0@mail.gmail.com> <20090530075033.GL29711@oblivion.subreption.com> <4A20E601.9070405@cs.helsinki.fi> <20090530082048.GM29711@oblivion.subreption.com> From: Ray Lee Date: Sat, 30 May 2009 08:05:17 -0700 X-Google-Sender-Auth: 811ef9016753ebca Message-ID: <2c0942db0905300805h4cd3f8eew32a0b7f5bd50e7be@mail.gmail.com> Subject: Re: [patch 0/5] Support for sanitization flag in low-level page allocator To: "Larry H." Cc: Pekka Enberg , Alan Cox , Ingo Molnar , Rik van Riel , linux-kernel@vger.kernel.org, Linus Torvalds , linux-mm@kvack.org, Ingo Molnar , pageexec@freemail.hu, Linus Torvalds Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 30, 2009 at 1:20 AM, Larry H. wrote: > On 10:53 Sat 30 May     , Pekka Enberg wrote: >>> That's hopeless, and kzfree is broken. Like I said in my earlier reply, >>> please test that yourself to see the results. Whoever wrote that ignored >>> how SLAB/SLUB work and if kzfree had been used somewhere in the kernel >>> before, it should have been noticed long time ago. >> >> An open-coded version of kzfree was being used in the kernel: >> >> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=00fcf2cb6f6bb421851c3ba062c0a36760ea6e53 >> >> Can we now get to the part where you explain how it's broken because I >> obviously "ignored how SLAB/SLUB works"? > > You can find the answer in the code of sanitize_obj, within my kfree > patch. Besides, it would have taken less time for you to write a simple > module that kmallocs and kzfrees a buffer, than writing these two > emails. How about, for the third time, just sharing that information with the whole rest of us reading along? Do you really think it's useful for dozens of us to go do that test, when you already obviously *have*, and could just share the information? Please, act like a member of the community and share what you know. If you're unwilling to do so, that's a huge argument in favor of ignoring your code, no matter how good or right it might be.