linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [RESEND PATCH] mm: align larger anonymous mappings on THP boundaries
@ 2023-12-14 22:34 Yang Shi
  2024-01-20 12:04 ` Ryan Roberts
  0 siblings, 1 reply; 30+ messages in thread
From: Yang Shi @ 2023-12-14 22:34 UTC (permalink / raw)
  To: riel, shy828301, willy, cl, akpm; +Cc: linux-kernel, linux-mm

From: Rik van Riel <riel@surriel.com>

Align larger anonymous memory mappings on THP boundaries by going through
thp_get_unmapped_area if THPs are enabled for the current process.

With this patch, larger anonymous mappings are now THP aligned.  When a
malloc library allocates a 2MB or larger arena, that arena can now be
mapped with THPs right from the start, which can result in better TLB hit
rates and execution time.

Link: https://lkml.kernel.org/r/20220809142457.4751229f@imladris.surriel.com
Signed-off-by: Rik van Riel <riel@surriel.com>
Reviewed-by: Yang Shi <shy828301@gmail.com>
Cc: Matthew Wilcox <willy@infradead.org>
Cc: Christopher Lameter <cl@linux.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
This patch was applied to v6.1, but was reverted due to a regression
report.  However it turned out the regression was not due to this patch.
I ping'ed Andrew to reapply this patch, Andrew may forget it.  This
patch helps promote THP, so I rebased it onto the latest mm-unstable.


 mm/mmap.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/mm/mmap.c b/mm/mmap.c
index 9d780f415be3..dd25a2aa94f7 100644
--- a/mm/mmap.c
+++ b/mm/mmap.c
@@ -2232,6 +2232,9 @@ get_unmapped_area(struct file *file, unsigned long addr, unsigned long len,
 		 */
 		pgoff = 0;
 		get_area = shmem_get_unmapped_area;
+	} else if (IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE)) {
+		/* Ensures that larger anonymous mappings are THP aligned. */
+		get_area = thp_get_unmapped_area;
 	}
 
 	addr = get_area(file, addr, len, pgoff, flags);
-- 
2.41.0


^ permalink raw reply related	[flat|nested] 30+ messages in thread

end of thread, other threads:[~2024-05-09  1:47 UTC | newest]

Thread overview: 30+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-14 22:34 [RESEND PATCH] mm: align larger anonymous mappings on THP boundaries Yang Shi
2024-01-20 12:04 ` Ryan Roberts
2024-01-20 12:13   ` Ryan Roberts
2024-01-20 16:39   ` Matthew Wilcox
2024-01-22 11:37     ` Ryan Roberts
2024-01-22 19:43       ` Yang Shi
2024-01-23  9:41         ` Ryan Roberts
2024-01-23 17:14           ` Yang Shi
2024-01-23 17:26             ` Yang Shi
2024-01-23 17:26             ` Ryan Roberts
2024-01-23 17:33               ` Yang Shi
2024-05-07  8:25               ` Kefeng Wang
2024-05-07 10:08                 ` Ryan Roberts
2024-05-07 10:59                   ` Kefeng Wang
2024-05-07 11:13                     ` David Hildenbrand
2024-05-07 11:14                       ` Ryan Roberts
2024-05-07 11:26                         ` Ryan Roberts
2024-05-07 11:34                           ` David Hildenbrand
2024-05-07 11:42                             ` David Hildenbrand
2024-05-07 12:36                               ` Ryan Roberts
2024-05-07 13:53                       ` Kefeng Wang
2024-05-07 15:53                         ` Ryan Roberts
2024-05-07 17:17                           ` Yang Shi
2024-05-08  7:48                             ` Kefeng Wang
2024-05-08  8:36                               ` Ryan Roberts
2024-05-08 13:37                                 ` Kefeng Wang
2024-05-08 13:41                                   ` Ryan Roberts
2024-05-08 15:25                                   ` Yang Shi
2024-05-09  1:47                                     ` Kefeng Wang
2024-01-22 20:20       ` Yang Shi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).