From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 118961E49B; Wed, 20 Mar 2024 17:59:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=13.77.154.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710957566; cv=none; b=RJ87Sm8hF09QLSj0aHwxJjX9Q7sMiXXj005rz/GtA8fG8enNc8jP0yvn+SQAAFzsdvkpyJ1EKDlNwBVC/+utpEr83D86JeVcWlOFSi5hyJqhuV27VkTURMjPGV/gQsLRnOIG2zOTTz92jJ7zb5aD0FclO/CVFEnYooG/3OhJU18= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710957566; c=relaxed/simple; bh=hwiRKS8x3Dz/MZcnQGj74zkiU1VvC70pYcQb54qBPsY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=aJPsVPoo58LDkqLrY0YphBx29B9Wq5TXJKzGorOHzZRt0Ya8Y1U6b50DeaPTdwBWZBhzAbGdMAYrTLAO0wRiRTQfl6RUv4ez4EfpGG1nFqVuyQBrZLUAmi6OUV5L7oPX69wwp07asql5kJzLzgOL6Vi88RvJqavhw2LjS5Ts4sI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com; spf=pass smtp.mailfrom=linux.microsoft.com; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b=c5w6EmvN; arc=none smtp.client-ip=13.77.154.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="c5w6EmvN" Received: from [100.64.129.161] (unknown [20.29.225.195]) by linux.microsoft.com (Postfix) with ESMTPSA id 4C44C20B74C0; Wed, 20 Mar 2024 10:59:24 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 4C44C20B74C0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1710957564; bh=Rato3V56U1xIHpQYHOICTvOn543oqjGwizhO0Sk9Mt0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=c5w6EmvN0GXhAmCwrWt1tnxPQ5dR3a5sHEY1FuqsmONSQeNaTf5VGgGVidSxKORE5 IMhT+F7RGSkDFquY1SPkN9dOnLdA/vbH9kakKUTqGOvpM/Tb7eRcm0QLmv9E/SFmln EYNRxQL6qS3JppOEVsgQw/ZqwKnjrm7kXZmVC1+8= Message-ID: <2c33751e-5995-4be2-a15e-ddca6a6ab4fe@linux.microsoft.com> Date: Wed, 20 Mar 2024 10:59:22 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4] hv/hv_kvp_daemon: Handle IPv4 and Ipv6 combination for keyfile format Content-Language: en-CA To: Shradha Gupta , linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org Cc: "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Olaf Hering , Ani Sinha , Shradha Gupta References: <1710933451-6312-1-git-send-email-shradhagupta@linux.microsoft.com> From: Easwar Hariharan In-Reply-To: <1710933451-6312-1-git-send-email-shradhagupta@linux.microsoft.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/20/2024 4:17 AM, Shradha Gupta wrote: > If the network configuration strings are passed as a combination of IPv4 > and IPv6 addresses, the current KVP daemon does not handle processing for > the keyfile configuration format. > With these changes, the keyfile config generation logic scans through the > list twice to generate IPv4 and IPv6 sections for the configuration files > to handle this support. > > Testcases ran:Rhel 9, Hyper-V VMs > (IPv4 only, IPv6 only, IPv4 and IPv6 combination) > Signed-off-by: Shradha Gupta > --- > Changes in v4 > * Removed the unnecessary memset for addr in the start > * Added a comment to describe how we erase the last comma character > * Fixed some typos in the commit description > * While using strncat, skip copying the '\0' character. > --- > tools/hv/hv_kvp_daemon.c | 181 ++++++++++++++++++++++++++++++--------- > 1 file changed, 140 insertions(+), 41 deletions(-) > LGTM Reviewed-by: Easwar Hariharan - Easwar