Re: [PATCH v5 03/20] x86/resctrl: Consolidate monitoring related data from rdt_resource

Reinette Chatre
2024-07-12T21:57:28Z

Hi Babu,

On 7/3/24 2:48 PM, Babu Moger wrote:
> The cache allocation and memory bandwidth allocation feature properties
> are consolidated into cache and membw structures respectively. In

Let "In preparation ... " start a new paragraph.

Quoting Documentation/process/maintainer-tip.rst:
It's also useful to structure the changelog into several paragraphs
and not lump everything together into a single one. A good structure
is to explain the context, the problem and the solution in separate
paragraphs and this order.

> preparation for more monitoring properties that will clobber the existing
> resource struct more, re-organize the monitoring specific properties into
> separate structure.

"re-organize the monitoring specific properties into separate structure" ->
"re-organize the monitoring specific properties to also be in a separate structure."

>
> Suggested-by: Reinette Chatre <reinette.chatre@intel.com>
> Signed-off-by: Babu Moger <babu.moger@amd.com>
> ---

...

> diff --git a/include/linux/resctrl.h b/include/linux/resctrl.h
> index b0875b99e811..e43fc5bb5a3a 100644
> --- a/include/linux/resctrl.h
> +++ b/include/linux/resctrl.h
> @@ -182,6 +182,16 @@ enum resctrl_scope {
> RESCTRL_L3_NODE,
> };
>
> +/**
> + * struct resctrl_mon - Monitoring related data
> + * @num_rmid: Number of RMIDs available
> + * @evt_list: List of monitoring events
> + */
> +struct resctrl_mon {
> + int num_rmid;
> + struct list_head evt_list;
> +};
> +
> /**
> * struct rdt_resource - attributes of a resctrl resource
> * @rid: The index of the resource
> @@ -207,11 +217,11 @@ struct rdt_resource {
> int rid;
> bool alloc_capable;
> bool mon_capable;
> - int num_rmid;
> enum resctrl_scope ctrl_scope;
> enum resctrl_scope mon_scope;
> struct resctrl_cache cache;
> struct resctrl_membw membw;
> + struct resctrl_mon mon;
> struct list_head ctrl_domains;
> struct list_head mon_domains;
> char *name;
> @@ -221,7 +231,6 @@ struct rdt_resource {
> int (*parse_ctrlval)(struct rdt_parse_data *data,
> struct resctrl_schema *s,
> struct rdt_ctrl_domain *d);
> - struct list_head evt_list;
> unsigned long fflags;
> bool cdp_capable;
> };

struct rdt_resource's kernel-doc still refers to the members
removed in this patch. Its kernel-doc also needs an update for the new
member added.

Reinette