From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758016AbcIGSe2 (ORCPT ); Wed, 7 Sep 2016 14:34:28 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:34395 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756339AbcIGSe1 (ORCPT ); Wed, 7 Sep 2016 14:34:27 -0400 Subject: Re: linux-next: Tree for Sep 7 (kernel/trace/trace_hwlat.c) To: Steven Rostedt References: <20160907175258.1f17a8ba@canb.auug.org.au> <20160907124422.70216727@gandalf.local.home> Cc: Stephen Rothwell , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org From: Randy Dunlap Message-ID: <2c4a12e1-7970-f272-8883-db7c6ae36825@infradead.org> Date: Wed, 7 Sep 2016 11:34:24 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20160907124422.70216727@gandalf.local.home> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/07/16 09:44, Steven Rostedt wrote: > Thanks! > > Below is the fix. I'll have to add it. > > -- Steve > > > diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig > index 72c07c2ffd79..d9000a81960e 100644 > --- a/kernel/trace/Kconfig > +++ b/kernel/trace/Kconfig > @@ -224,6 +224,7 @@ config SCHED_TRACER > config HWLAT_TRACER > bool "Tracer to detect hardware latencies (like SMIs)" > select GENERIC_TRACER > + select TRACER_MAX_TRACE > help > This tracer, when enabled will create one or more kernel threads, > depening on what the cpumask file is set to, which each thread > Hm, now I get: ../kernel/trace/trace.c: In function 'tracing_set_tracer': ../kernel/trace/trace.c:4850:3: error: implicit declaration of function 'free_snapshot' [-Werror=implicit-function-declaration] free_snapshot(tr); ^ ../kernel/trace/trace.c:4856:3: error: implicit declaration of function 'alloc_snapshot' [-Werror=implicit-function-declaration] ret = alloc_snapshot(tr); ^ -- ~Randy