From: Markus Elfring <Markus.Elfring@web.de>
To: "Ma Ke" <make24@iscas.ac.cn>,
linux-s390@vger.kernel.org, netdev@vger.kernel.org,
"Alexander Gordeev" <agordeev@linux.ibm.com>,
"Alexandra Winter" <wintera@linux.ibm.com>,
"Christian Bornträger" <borntraeger@linux.ibm.com>,
"David S. Miller" <davem@davemloft.net>,
"Gerd Bayer" <gbayer@linux.ibm.com>,
"Heiko Carstens" <hca@linux.ibm.com>,
"Niklas Schnelle" <schnelle@linux.ibm.com>,
"Stefan Raspl" <raspl@linux.ibm.com>,
"Sven Schnelle" <svens@linux.ibm.com>,
"Thorsten Winkler" <twinkler@linux.ibm.com>,
"Vasily Gorbik" <gor@linux.ibm.com>,
"Wenjia Zhang" <wenjia@linux.ibm.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Ratheesh Kannoth <rkannoth@marvell.com>
Subject: Re: [PATCH v2] s390/ism: Add check for dma_set_max_seg_size in ism_probe()
Date: Thu, 27 Jun 2024 09:17:05 +0200 [thread overview]
Message-ID: <2c4ff078-a792-480e-971f-8bfeac07fac8@web.de> (raw)
In-Reply-To: <20240627021314.2976443-1-make24@iscas.ac.cn>
> As the possible failure of the dma_set_max_seg_size(), we should better
> check the return value of the dma_set_max_seg_size().
Please avoid the repetition of a function name in such a change description.
Can it be improved with corresponding imperative wordings?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc5#n94
…
> +++ b/drivers/s390/net/ism_drv.c
> @@ -620,7 +620,10 @@ static int ism_probe(struct pci_dev *pdev, const struct pci_device_id *id)
> goto err_resource;
>
> dma_set_seg_boundary(&pdev->dev, SZ_1M - 1);
> - dma_set_max_seg_size(&pdev->dev, SZ_1M);
> + ret = dma_set_max_seg_size(&pdev->dev, SZ_1M);
> + if (ret)
> + goto err_resource;
> +
> pci_set_master(pdev);
…
A) Will the shown dma_set_seg_boundary() call trigger similar software development concerns?
https://elixir.bootlin.com/linux/v6.10-rc5/source/include/linux/dma-mapping.h#L562
B) Under which circumstances would you become interested to increase the application
of scope-based resource management here?
https://elixir.bootlin.com/linux/v6.10-rc5/source/include/linux/cleanup.h#L8
Regards,
Markus
next prev parent reply other threads:[~2024-06-27 7:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-27 2:13 [PATCH v2] s390/ism: Add check for dma_set_max_seg_size in ism_probe() Ma Ke
2024-06-27 5:20 ` Ratheesh Kannoth
2024-06-27 7:17 ` Markus Elfring [this message]
2024-06-27 19:42 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c4ff078-a792-480e-971f-8bfeac07fac8@web.de \
--to=markus.elfring@web.de \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=davem@davemloft.net \
--cc=gbayer@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=make24@iscas.ac.cn \
--cc=netdev@vger.kernel.org \
--cc=raspl@linux.ibm.com \
--cc=rkannoth@marvell.com \
--cc=schnelle@linux.ibm.com \
--cc=svens@linux.ibm.com \
--cc=twinkler@linux.ibm.com \
--cc=wenjia@linux.ibm.com \
--cc=wintera@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox