From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D5320303DF3; Fri, 4 Jul 2025 08:08:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751616538; cv=none; b=BCB69SbICtU5kmXN//QlJ9Tthgq4el+VIMLj0Aaao6u6sLrCIoT41AbJS4+4qNmElxCleeEeKX8TVkUkUaydFn8wwUFppfuJmuKcoKHyk3/OiMcT+BlByxufy1osN3JLJ88no+jgKUR2GZECUDoPZL3pA+Vc1YzzP1Ev0YIkMJk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751616538; c=relaxed/simple; bh=rGN315Ao+iDirINpTwMm+NSfebWgG3GOvTJmCfbPutk=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=WuVYoc3T2fnu/H7MwlI/IazZCe89wuPx81kHy9mM2a6EZND4izXfDVepoh9Eq/Jtk/CdcfOhgYcoxzDbXYJETe/tIo8ihmqMR6gZPutc0ZvXkJD0KfsAmKzcQZM05eFHM8RZu9rlzcduT0fnggFKgJ3P0Md+yZebfa31wEMzKXQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=AWWmR2mq; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="AWWmR2mq" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1288FC4CEE3; Fri, 4 Jul 2025 08:08:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1751616538; bh=rGN315Ao+iDirINpTwMm+NSfebWgG3GOvTJmCfbPutk=; h=Date:Subject:To:References:From:In-Reply-To:From; b=AWWmR2mqVWg0OWAQ2V1PEsbfdz+PBWPchQ4An7EnmcollFczeyleNjFMKG1sx1QEt AZ47v76UwG7Ac7l3XijLAL/W3XPyiwrGRgX8XU70cUMUx1nRejG1dPq97Ilj9+vYnD 59MEQLiU5F2+dUfp5llHwy0EhWvTVbfX7XcQCW8yDQmbtyQDuGRSZZenSVVJcDVovH xpPhSEXlelrGtOY1rXjiSpYg84GkkzXlhd60dsRMbB024ZlbNIJtw35qS7/ykRfPIx kOA8E0cldwl0Qvrs6K6ZNaPhO+MxLMU26h2uIgs7yI4wwcTCCIWSnnHrMiiU9wQG8G H/h2qIF9u/Rtw== Message-ID: <2c558cde-b257-404e-805c-a59e41852bc6@kernel.org> Date: Fri, 4 Jul 2025 10:08:53 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/4] dt-bindings: media: Add Sony IMX585 CMOS image sensor To: Will Whang , Sakari Ailus , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "open list:SONY IMX585 SENSOR DRIVER" , open list , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" References: <20250702063836.3984-1-will@willwhang.com> <20250702063836.3984-2-will@willwhang.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <20250702063836.3984-2-will@willwhang.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 02/07/2025 08:38, Will Whang wrote: > + > +description: > + IMX585 sensor is a Sony CMOS sensor with 4K and FHD outputs. > + > +properties: > + compatible: > + const: sony,imx585 > + > + clocks: > + maxItems: 1 > + > + clock-names: > + const: xclk > + > + clock-frequency: > + enum: [ 74250000, 37125000, 72000000, 27000000, 24000000 ] Drop the property. > + > + reg: reg always follows compatible. > + maxItems: 1 > + description: I2C Address for IMX585 Drop description, redundant. > + > + VANA-supply: Lower case. > + description: Analog power supply (3.3V) > + > + VDDL-supply: > + description: Interface power supply (1.8V) > + > + VDIG-supply: > + description: Digital power supply (1.1V) > + > + reset-gpios: > + description: Sensor reset (XCLR) GPIO > + maxItems: 1 > + > + port: > + $ref: /schemas/graph.yaml#/$defs/port-base > + additionalProperties: false > + > + properties: > + endpoint: > + $ref: /schemas/media/video-interfaces.yaml# > + unevaluatedProperties: false > + > + properties: > + data-lanes: > + anyOf: > + - items: > + - const: 1 > + - const: 2 > + - const: 3 > + - const: 4 > + > + sync-mode: Missing vendor prefix > + description: | > + Select the synchronisation mode of the sensor > + 0 – internal sync, leader (default) > + 1 – internal sync, follower > + 2 – external sync > + $ref: /schemas/types.yaml#/definitions/uint8 > + enum: [ 0, 1, 2 ] This should be just string enum Missing default > + > + link-frequencies: > + description: Select the MIPI-CSI2 link speed in Mhz > + items: > + enum: [ 297000000, 360000000, 445500000, 594000000, > + 720000000, 891000000, 1039500000 ] > + > + required: > + - data-lanes > + - link-frequencies > + > + required: > + - endpoint > + > +required: > + - compatible > + - reg And why here is different? BTW, here it is correct. > + - clocks > + - clock-frequency Drop > + - port > + > +additionalProperties: false > + > +examples: > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + imx585@1a { Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > + compatible = "sony,imx585"; > + reg = <0x1a>; > + clocks = <&imx585_clk>; > + clock-frequency = <24000000>; > + > + VANA-supply = <&camera_vadd_3v3>; > + VDDL-supply = <&camera_vdd1_1v8>; > + VDIG-supply = <&camera_vdd2_1v1>; > + > + port { > + imx585: endpoint { > + remote-endpoint = <&cam>; > + data-lanes = <1 2 3 4>; > + link-frequencies = /bits/ 64 <720000000>; > + }; > + }; > + }; > + }; > +... > diff --git a/MAINTAINERS b/MAINTAINERS > index da34c7227..9cc404790 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -23150,6 +23150,14 @@ T: git git://linuxtv.org/media.git > F: Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml > F: drivers/media/i2c/imx415.c > > +SONY IMX585 SENSOR DRIVER > +M: Will Whang > +L: linux-media@vger.kernel.org > +S: Maintained > +T: git git://linuxtv.org/media.git Drop, you do not have access there, AFAIK. > +F: Documentation/devicetree/bindings/media/i2c/sony,imx585.yaml > +F: drivers/media/i2c/imx585.c There is no such file. > + > SONY MEMORYSTICK SUBSYSTEM > M: Maxim Levitsky > M: Alex Dubov Best regards, Krzysztof