From: "Jürgen Groß" <jgross@suse.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Yan Yankovskyi <yyankovskyi@gmail.com>, Wei Liu <wl@xen.org>,
xen-devel <xen-devel@lists.xenproject.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
clang-built-linux <clang-built-linux@googlegroups.com>
Subject: Re: [PATCH] xenbus: avoid stack overflow warning
Date: Wed, 6 May 2020 07:12:24 +0200 [thread overview]
Message-ID: <2c6e4b36-6618-1889-55c4-16eeb1ef6f57@suse.com> (raw)
In-Reply-To: <CAK8P3a2_7+_a_cwDK1cwfrJX4azQJhd_Y0xB18cCUn6=p7fVsg@mail.gmail.com>
On 05.05.20 22:57, Arnd Bergmann wrote:
> On Tue, May 5, 2020 at 6:02 PM Jürgen Groß <jgross@suse.com> wrote:
>> On 05.05.20 17:01, Arnd Bergmann wrote:
>>> On Tue, May 5, 2020 at 4:34 PM Jürgen Groß <jgross@suse.com> wrote:
>>>> On 05.05.20 16:15, Arnd Bergmann wrote:
>>>
>>> I considered that as well, and don't really mind either way. I think it does
>>> get a bit ugly whatever we do. If you prefer the union, I can respin the
>>> patch that way.
>>
>> Hmm, thinking more about it I think the real clean solution would be to
>> extend struct map_ring_valloc_hvm to cover the pv case, too, to add the
>> map and unmap arrays (possibly as a union) to it and to allocate it
>> dynamically instead of having it on the stack.
>>
>> Would you be fine doing this?
>
> This is a little more complex than I'd want to do without doing any testing
> (and no, I don't want to do the testing either) ;-)
>
> It does sound like a better approach though.
I take this as you are fine with me writing the patch and adding you as
"Reported-by:"?
Juergen
next prev parent reply other threads:[~2020-05-06 5:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-05 14:15 [PATCH] xenbus: avoid stack overflow warning Arnd Bergmann
2020-05-05 14:33 ` Jürgen Groß
2020-05-05 15:01 ` Arnd Bergmann
2020-05-05 16:02 ` Jürgen Groß
2020-05-05 16:12 ` Boris Ostrovsky
2020-05-05 16:34 ` Jürgen Groß
2020-05-05 20:57 ` Arnd Bergmann
2020-05-06 5:12 ` Jürgen Groß [this message]
2020-05-06 10:28 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c6e4b36-6618-1889-55c4-16eeb1ef6f57@suse.com \
--to=jgross@suse.com \
--cc=arnd@arndb.de \
--cc=boris.ostrovsky@oracle.com \
--cc=clang-built-linux@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
--cc=yyankovskyi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox