* [PATCH] drm: vmwgfx: constify vmw_fence_ops
@ 2017-08-30 5:47 Arvind Yadav
2017-08-30 6:21 ` Thomas Hellstrom
0 siblings, 1 reply; 5+ messages in thread
From: Arvind Yadav @ 2017-08-30 5:47 UTC (permalink / raw)
To: airlied, thellstrom, syeh, linux-graphics-maintainer
Cc: linux-kernel, dri-devel
vmw_fence_ops are not supposed to change at runtime. Functions
"dma_fence_init" working with const vmw_fence_ops provided
by <linux/dma-fence.h>. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/gpu/drm/vmwgfx/vmwgfx_fence.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c b/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c
index b8bc5bc..abc5f03 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c
@@ -225,7 +225,7 @@ static long vmw_fence_wait(struct dma_fence *f, bool intr, signed long timeout)
return ret;
}
-static struct dma_fence_ops vmw_fence_ops = {
+static const struct dma_fence_ops vmw_fence_ops = {
.get_driver_name = vmw_fence_get_driver_name,
.get_timeline_name = vmw_fence_get_timeline_name,
.enable_signaling = vmw_fence_enable_signaling,
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] drm: vmwgfx: constify vmw_fence_ops
2017-08-30 5:47 [PATCH] drm: vmwgfx: constify vmw_fence_ops Arvind Yadav
@ 2017-08-30 6:21 ` Thomas Hellstrom
2017-08-30 8:30 ` Daniel Vetter
0 siblings, 1 reply; 5+ messages in thread
From: Thomas Hellstrom @ 2017-08-30 6:21 UTC (permalink / raw)
To: Arvind Yadav, airlied, syeh, linux-graphics-maintainer
Cc: linux-kernel, dri-devel
On 08/30/2017 07:47 AM, Arvind Yadav wrote:
> vmw_fence_ops are not supposed to change at runtime. Functions
> "dma_fence_init" working with const vmw_fence_ops provided
> by <linux/dma-fence.h>. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> drivers/gpu/drm/vmwgfx/vmwgfx_fence.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c b/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c
> index b8bc5bc..abc5f03 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c
> @@ -225,7 +225,7 @@ static long vmw_fence_wait(struct dma_fence *f, bool intr, signed long timeout)
> return ret;
> }
>
> -static struct dma_fence_ops vmw_fence_ops = {
> +static const struct dma_fence_ops vmw_fence_ops = {
> .get_driver_name = vmw_fence_get_driver_name,
> .get_timeline_name = vmw_fence_get_timeline_name,
> .enable_signaling = vmw_fence_enable_signaling,
Reviewed-by: Thomas Hellstrom <thellstrom@vmware.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm: vmwgfx: constify vmw_fence_ops
2017-08-30 6:21 ` Thomas Hellstrom
@ 2017-08-30 8:30 ` Daniel Vetter
2017-08-30 9:09 ` Thomas Hellstrom
2017-08-30 15:42 ` Sinclair Yeh
0 siblings, 2 replies; 5+ messages in thread
From: Daniel Vetter @ 2017-08-30 8:30 UTC (permalink / raw)
To: Thomas Hellstrom
Cc: Arvind Yadav, airlied, syeh, linux-graphics-maintainer,
linux-kernel, dri-devel
On Wed, Aug 30, 2017 at 08:21:46AM +0200, Thomas Hellstrom wrote:
> On 08/30/2017 07:47 AM, Arvind Yadav wrote:
> > vmw_fence_ops are not supposed to change at runtime. Functions
> > "dma_fence_init" working with const vmw_fence_ops provided
> > by <linux/dma-fence.h>. So mark the non-const structs as const.
> >
> > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> > ---
> > drivers/gpu/drm/vmwgfx/vmwgfx_fence.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c b/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c
> > index b8bc5bc..abc5f03 100644
> > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c
> > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c
> > @@ -225,7 +225,7 @@ static long vmw_fence_wait(struct dma_fence *f, bool intr, signed long timeout)
> > return ret;
> > }
> > -static struct dma_fence_ops vmw_fence_ops = {
> > +static const struct dma_fence_ops vmw_fence_ops = {
> > .get_driver_name = vmw_fence_get_driver_name,
> > .get_timeline_name = vmw_fence_get_timeline_name,
> > .enable_signaling = vmw_fence_enable_signaling,
>
> Reviewed-by: Thomas Hellstrom <thellstrom@vmware.com>
Does this mean you'll merge it, or does this mean you'll expect someone
else to merge this?
I'm always confused when maintainers reply with an r-b/ack for a patch
only touching their driver, and no further information at all.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm: vmwgfx: constify vmw_fence_ops
2017-08-30 8:30 ` Daniel Vetter
@ 2017-08-30 9:09 ` Thomas Hellstrom
2017-08-30 15:42 ` Sinclair Yeh
1 sibling, 0 replies; 5+ messages in thread
From: Thomas Hellstrom @ 2017-08-30 9:09 UTC (permalink / raw)
To: Arvind Yadav, airlied, syeh, linux-graphics-maintainer,
linux-kernel, dri-devel
On 08/30/2017 10:30 AM, Daniel Vetter wrote:
> On Wed, Aug 30, 2017 at 08:21:46AM +0200, Thomas Hellstrom wrote:
>> On 08/30/2017 07:47 AM, Arvind Yadav wrote:
>>> vmw_fence_ops are not supposed to change at runtime. Functions
>>> "dma_fence_init" working with const vmw_fence_ops provided
>>> by <linux/dma-fence.h>. So mark the non-const structs as const.
>>>
>>> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
>>> ---
>>> drivers/gpu/drm/vmwgfx/vmwgfx_fence.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c b/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c
>>> index b8bc5bc..abc5f03 100644
>>> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c
>>> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c
>>> @@ -225,7 +225,7 @@ static long vmw_fence_wait(struct dma_fence *f, bool intr, signed long timeout)
>>> return ret;
>>> }
>>> -static struct dma_fence_ops vmw_fence_ops = {
>>> +static const struct dma_fence_ops vmw_fence_ops = {
>>> .get_driver_name = vmw_fence_get_driver_name,
>>> .get_timeline_name = vmw_fence_get_timeline_name,
>>> .enable_signaling = vmw_fence_enable_signaling,
>> Reviewed-by: Thomas Hellstrom <thellstrom@vmware.com>
> Does this mean you'll merge it, or does this mean you'll expect someone
> else to merge this?
>
> I'm always confused when maintainers reply with an r-b/ack for a patch
> only touching their driver, and no further information at all.
> -Daniel
For patches only touching our driver, I'd say we're always responsible
for sorting out how it's going to be merged.
Since Sinclair is maintaining the vmwgfx trees I thought I'd give him a
chance to comment on how he wanted it merged.
/Thomas
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm: vmwgfx: constify vmw_fence_ops
2017-08-30 8:30 ` Daniel Vetter
2017-08-30 9:09 ` Thomas Hellstrom
@ 2017-08-30 15:42 ` Sinclair Yeh
1 sibling, 0 replies; 5+ messages in thread
From: Sinclair Yeh @ 2017-08-30 15:42 UTC (permalink / raw)
To: Thomas Hellstrom, Arvind Yadav, airlied,
linux-graphics-maintainer, linux-kernel, dri-devel
On Wed, Aug 30, 2017 at 10:30:24AM +0200, Daniel Vetter wrote:
> On Wed, Aug 30, 2017 at 08:21:46AM +0200, Thomas Hellstrom wrote:
> > On 08/30/2017 07:47 AM, Arvind Yadav wrote:
> > > vmw_fence_ops are not supposed to change at runtime. Functions
> > > "dma_fence_init" working with const vmw_fence_ops provided
> > > by <linux/dma-fence.h>. So mark the non-const structs as const.
> > >
> > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> > > ---
> > > drivers/gpu/drm/vmwgfx/vmwgfx_fence.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c b/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c
> > > index b8bc5bc..abc5f03 100644
> > > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c
> > > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c
> > > @@ -225,7 +225,7 @@ static long vmw_fence_wait(struct dma_fence *f, bool intr, signed long timeout)
> > > return ret;
> > > }
> > > -static struct dma_fence_ops vmw_fence_ops = {
> > > +static const struct dma_fence_ops vmw_fence_ops = {
> > > .get_driver_name = vmw_fence_get_driver_name,
> > > .get_timeline_name = vmw_fence_get_timeline_name,
> > > .enable_signaling = vmw_fence_enable_signaling,
> >
> > Reviewed-by: Thomas Hellstrom <thellstrom@vmware.com>
>
> Does this mean you'll merge it, or does this mean you'll expect someone
> else to merge this?
Yes, we have this queued and will go out in the next pull request.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-08-30 15:42 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-30 5:47 [PATCH] drm: vmwgfx: constify vmw_fence_ops Arvind Yadav
2017-08-30 6:21 ` Thomas Hellstrom
2017-08-30 8:30 ` Daniel Vetter
2017-08-30 9:09 ` Thomas Hellstrom
2017-08-30 15:42 ` Sinclair Yeh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox