Re: [PATCH v8 13/20] PCI/ERR: Add printk level to pcie_print_tlp_log()

Ilpo Järvinen
2025-05-28T10:00:48Z

On Wed, 28 May 2025, Lukas Wunner wrote:

> On Thu, May 22, 2025 at 06:21:19PM -0500, Bjorn Helgaas wrote:
> > @@ -130,6 +132,6 @@ void pcie_print_tlp_log(const struct pci_dev *dev,
> > }
> > }
> >
> > - pci_err(dev, "%sTLP Header%s: %s\n", pfx,
> > + dev_printk(level, &dev->dev, "%sTLP Header%s: %s\n", pfx,
> > log->flit ? " (Flit)" : "", buf);
> > }
>
> Nit: pci_printk() ?
>
> The definition in include/linux/pci.h was retained by fab874e12593.

If pci_printk() is taken into use once again, there's 56d305b24d64 ("PCI:
Remove pci_printk()") queued already in pci/misc which should be dropped
in that case.

--
i.