From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1761687AbdEVTrr (ORCPT <rfc822;w@1wt.eu>);
        Mon, 22 May 2017 15:47:47 -0400
Received: from mout.web.de ([212.227.15.4]:50866 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1761549AbdEVTri (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 22 May 2017 15:47:38 -0400
Subject: Re: [PATCH 2/5] sctp: Delete an error message for a failed memory
 allocation in sctp_init()
To: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
        linux-sctp@vger.kernel.org, netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
        Neil Horman <nhorman@tuxdriver.com>,
        Vlad Yasevich <vyasevich@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
References: <2845df67-d35d-536a-0a53-b2eb83fe1ba5@users.sourceforge.net>
 <7db0cb49-109b-88a6-532f-c591cc8ffa85@users.sourceforge.net>
 <20170522165658.GA4642@localhost.localdomain>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <2c849843-549f-419e-2326-1fcb7bcdc2e2@users.sourceforge.net>
Date: Mon, 22 May 2017 21:46:21 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.1.1
MIME-Version: 1.0
In-Reply-To: <20170522165658.GA4642@localhost.localdomain>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:hi1ILkCdSJkblrBS9fA9maySI5UXM6qjqt4Bx82i6SKKnCkKYhe
 co908CTYBux8nCiyEQy9R+LCOfYHGs1BuslWim7K0+Br7FssuPm0Kr4PHNbfH7P9tddlyDq
 o7XKrK6/YcnruDKFvRUna77jaZ+AqiTAkzDTKrVynTVmtvq5KWrFh4dsitiK2T9NFX4aprA
 +I/i0JX5HixVSVuImwkeA==
X-UI-Out-Filterresults: notjunk:1;V01:K0:p6t5I9nlE24=:GTk6sIwv+DW153EJWVCYVf
 icbivfipqcl9rmXMMZ8s96EmSRRtGm7XNeDwajfSXKh5WxeLEiLsGrWPKlmQ5IhhakFyrhKlS
 RIX/jXs6V+ZnCJnX+fp5Mm+DYunAd+0P8mcmlFQ2tPorkM9N7lGcxv8mOf+lgG55cZ0JOZSGL
 9NuAravDFwTYj+Hu9b20Oaye75usOKx+48vJk34hnS/hENDnmNl5v040D/yjhzLQw0QNMaPId
 4hcxQk6G8MAwgbREKxTPGIZY/H+7zoHNPt3C8cafm/c6+LVgBtximvwGj5++H3T7P6un61Gi/
 FW4t4HS+CiPu8MXrI9OxykobqhcKE4bj8nDpjJeA2utzCUVWOeVzNVb769VsM8+xLW9yTBoQJ
 TY9pU9JLIaiLF1WyKS8AC/1TzesuZRB7QwpsV4+bQl6PGzqGiBwEHtZZZbIZfVwL83nUNiVlI
 3UImP8OI8LKZnYwai/Pp4G2SLaN1VhOaFGq9VtTSg9lP4N8IRLLpaCPBdJnSbX8U2m/uach0m
 90cshjtS0N16AFpQwyRDOugt43MP/XuKzPuaiLLvCDOdjrj5Jy7Cy0cu6AZ02wb0rdE06DwGH
 k3EqQhd2jNe5EVObgVZCJc7/pEZ99NIG8i2S+3GUuK+J//59sz9Sr6Q6wcSu3FsQ7mIZqm04I
 Xk/hHE5PbMvv7cJ85h5AK7fKz4UADZ2dLrCe/w9vRdc1uq+enFqomZaokghPTbsnHu7DzWwOl
 HP7B9q5DkiQFZG1dXcxJw4b//XdhjhR8WKNnmi++SXBCfRf6KoQ976X6ES3+bJ8201rqV3lyx
 JowWTH+
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> +++ b/net/sctp/protocol.c
>> @@ -1447,5 +1447,4 @@ static __init int sctp_init(void)
>>  	if (!sctp_ep_hashtable) {
>> -		pr_err("Failed endpoint_hash alloc\n");
> 
> Okay but then why not also delete the one a few lines below this one:
>         if (!sctp_port_hashtable) {
>                 pr_err("Failed bind hash alloc\n");
>                 status = -ENOMEM;
>                 goto err_bhash_alloc;
>         }
> Seems the same pattern to me.
> 
>>  		status = -ENOMEM;
>>  		goto err_ehash_alloc;
>>  	}

How do you think about to remove the other error message in another
update step if a consensus would be achieved in such a direction
for this software module?

Regards,
Markus