public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Coywolf Qi Hunt <coywolf@gmail.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Linux 2.6.10-ac2
Date: Fri, 31 Dec 2004 10:01:34 +0800	[thread overview]
Message-ID: <2cd57c900412301801b7794be@mail.gmail.com> (raw)
In-Reply-To: <2cd57c90041230174037300542@mail.gmail.com>

Suppose index is 0 or 1,  pci_find_device calling could be avoided also.


On Fri, 31 Dec 2004 09:40:19 +0800, Coywolf Qi Hunt <coywolf@gmail.com> wrote:
> On Thu, 30 Dec 2004 23:42:34 +0000, Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> >
> > Forward ported from 2.6.9-ac
> > o       Don't probe legacy ISA ide2,3,4,5 on PCI boxes  (Alan Cox)
> 
> Below is a cut from the 2.6.10-ac2 patch. I think since
> pci_find_device() == NULL is more unlikely, please consider this patch
> previousely posted on your original thread:
> http://lkml.org/lkml/2004/12/27/195
> 
> diff -u --new-file --recursive --exclude-from /usr/src/exclude
> linux.vanilla-2.6.10/include/asm-i386/ide.h
> linux-2.6.10/include/asm-i386/ide.h
> --- linux.vanilla-2.6.10/include/asm-i386/ide.h 2004-12-25
> 21:13:51.000000000 +0000
> +++ linux-2.6.10/include/asm-i386/ide.h 2004-12-29 22:34:05.000000000 +0000
> @@ -41,16 +41,20 @@
> 
>  static __inline__ unsigned long ide_default_io_base(int index)
>  {
> +       if(pci_find_device(PCI_ANY_ID, PCI_ANY_ID, NULL) == NULL) {
> +               switch(index) {
> +                       case 2: return 0x1e8;
> +                       case 3: return 0x168;
> +                       case 4: return 0x1e0;
> +                       case 5: return 0x160;
> +                       }
> +       }
>         switch (index) {
>                 case 0: return 0x1f0;
>                 case 1: return 0x170;
> -               case 2: return 0x1e8;
> -               case 3: return 0x168;
> -               case 4: return 0x1e0;
> -               case 5: return 0x160;
>                 default:
>                         return 0;
> -       }
> +       }
>  }
> 
>  #define IDE_ARCH_OBSOLETE_INIT
> 
> 
> --
> Coywolf Qi Hunt
> Homepage http://sosdg.org/~coywolf/
> 


-- 
Coywolf Qi Hunt
Homepage http://sosdg.org/~coywolf/

  reply	other threads:[~2004-12-31  2:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-30 23:42 Linux 2.6.10-ac2 Alan Cox
2004-12-31  1:40 ` Coywolf Qi Hunt
2004-12-31  2:01   ` Coywolf Qi Hunt [this message]
2005-01-02 20:56 ` Christian Hesse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2cd57c900412301801b7794be@mail.gmail.com \
    --to=coywolf@gmail.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox