From: Coywolf Qi Hunt <coywolf@gmail.com>
To: Andrew Morton <akpm@osdl.org>
Cc: coywolf@sosdg.org, linux-kernel@vger.kernel.org
Subject: Re: [patch] oom_kill fix
Date: Wed, 16 Mar 2005 02:44:03 +0800 [thread overview]
Message-ID: <2cd57c9005031510443ba02e8@mail.gmail.com> (raw)
In-Reply-To: <20050314180258.271acfab.akpm@osdl.org>
On Mon, 14 Mar 2005 18:02:58 -0800, Andrew Morton <akpm@osdl.org> wrote:
> Coywolf Qi Hunt <coywolf@sosdg.org> wrote:
> >
> > This oom_kill fix is to do mmput(mm) a bit earlier and returning 0 or 1
> > to indicate success or failure instead of returning mm_struct pointer.
>
> Why is this a "fix"? What bug is it fixing?
>
It's at least a coding style improvement and lets the code be less obfuscated.
It increases the system survival possibilities by doing mmput immediately
and reduces the chances of oom killing another process unnecessarily, IMHO.
Or rather rename "fix" to "cleanup".
--
Coywolf Qi Hunt
http://sosdg.org/~coywolf/
prev parent reply other threads:[~2005-03-15 18:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-14 18:14 [patch] oom_kill fix Coywolf Qi Hunt
2005-03-15 2:02 ` Andrew Morton
2005-03-15 18:44 ` Coywolf Qi Hunt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2cd57c9005031510443ba02e8@mail.gmail.com \
--to=coywolf@gmail.com \
--cc=akpm@osdl.org \
--cc=coywolf@sosdg.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox