From: Coywolf Qi Hunt <coywolf@gmail.com>
To: Matt Mackall <mpm@selenic.com>
Cc: Andrew Morton <akpm@osdl.org>,
YhLu@tyan.com, linux-tiny@selenic.com,
linux-kernel@vger.kernel.org
Subject: Re: serial console
Date: Tue, 17 May 2005 09:24:23 +0800 [thread overview]
Message-ID: <2cd57c9005051618243be2ae14@mail.gmail.com> (raw)
In-Reply-To: <20050516234757.GG5914@waste.org>
On 5/17/05, Matt Mackall <mpm@selenic.com> wrote:
> On Mon, May 16, 2005 at 04:37:12PM -0700, Andrew Morton wrote:
> >
> > It would be nicer if this was a static inline, so all the function call
> > code at the callsites is removed by the compiler.
>
> Better yet, a patch that's actually right. add_preferred_console is
> setting the console used by init and so on, so it's still relevant
> with CONFIG_PRINTK off. So I just move it out of the ifdef. Obviously
> more correct(tm).
>
> Move add_preferred_console out of CONFIG_PRINTK so serial console does
> the right thing.
What's the purpose of serial console if printk is disabled? I suggest
we put add_preferred_console and all its callers, console code etc
into CONFIG_PRINTK.
--
Coywolf Qi Hunt
http://sosdg.org/~coywolf/
next prev parent reply other threads:[~2005-05-17 1:24 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <3174569B9743D511922F00A0C943142309F80D9F@TYANWEB>
[not found] ` <20050516205731.GA5914@waste.org>
2005-05-16 23:15 ` serial console Matt Mackall
2005-05-16 23:37 ` Andrew Morton
2005-05-16 23:47 ` Matt Mackall
2005-05-17 1:24 ` Coywolf Qi Hunt [this message]
2005-05-17 2:26 ` Matt Mackall
2005-05-17 2:40 ` Coywolf Qi Hunt
2005-05-17 2:19 ` Rob Landley
[not found] <200208191108120240.0D409F0A@192.168.128.16>
2002-08-19 9:10 ` Serial Console Carlos Velasco
2002-08-19 9:18 ` Russell King
2000-12-05 18:09 Jon Burgess
-- strict thread matches above, loose matches on Subject: below --
2000-12-05 15:20 Jon Burgess
2000-12-05 16:03 ` Chad Schwartz
2000-12-05 12:04 Steve Hill
2000-12-05 12:11 ` Miquel van Smoorenburg
2000-12-05 14:44 ` Paul Jakma
2000-12-05 14:58 ` Steve Hill
2000-12-05 15:07 ` Chad Schwartz
2000-12-05 15:14 ` Paul Jakma
2000-12-05 15:28 ` Steve Hill
2000-12-05 15:38 ` Chad Schwartz
2000-12-05 16:25 ` Rogier Wolff
2000-12-05 17:00 ` Miquel van Smoorenburg
2000-12-06 13:09 ` Vitaly Luban
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2cd57c9005051618243be2ae14@mail.gmail.com \
--to=coywolf@gmail.com \
--cc=YhLu@tyan.com \
--cc=akpm@osdl.org \
--cc=coywolf@lovecn.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tiny@selenic.com \
--cc=mpm@selenic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox