Re: halt: init exits/panic

Re: halt: init exits/panic

[DervishD]

    Hi Nico :)

 * Nico Schottelius <nico-kernel@schottelius.org> dixit:
> What's the 'correct behaviour' of an init system, if someone wants
> to shutdown the system?

    What I do in my vcinit, the last steps I mean, is:

    reboot(RB_POWER_OFF); /* If halting*/
        or
    reboot(RB_AUTOBOOT); /* If rebooting */

    exit(EXIT_SUCCESS);

    And my vcinit doesn't panic ;)

    Raúl Núñez de Arenas Coronado

-- 
Linux Registered User 88736 | http://www.dervishd.net
http://www.pleyades.net & http://www.gotesdelluna.net
It's my PC and I'll cry if I want to...

halt: init exits/panic

[Nico Schottelius]

[-- Attachment #1: Type: text/plain, Size: 532 bytes --]

Hello!

What's the 'correct behaviour' of an init system, if someone wants
to shutdown the system?

I currently do:

- call reboot(RB_POWER_OFF/RB_AUTOBOOT/RB_HALT_SYSTEM)
- _exit(0)

Is this exit() call wrong? If I do RB_HALT_SYSTEM and _exit(0) after,
the kernel panics.

Should init simply sleep, return to normal processing or exit?

Sincerly,

Nico

-- 
Keep it simple & stupid, use what's available.
Please use pgp encryption: 8D0E 27A4 is my id.
http://nico.schotteli.us | http://linux.schottelius.org

[-- Attachment #2: Type: application/pgp-signature, Size: 827 bytes --]

Re: halt: init exits/panic

[Coywolf Qi Hunt]

On 7/9/05, Nico Schottelius <nico-kernel@schottelius.org> wrote:
> Hello!
> 
> What's the 'correct behaviour' of an init system, if someone wants
> to shutdown the system?
> 
> I currently do:
> 
> - call reboot(RB_POWER_OFF/RB_AUTOBOOT/RB_HALT_SYSTEM)
> - _exit(0)
> 
> Is this exit() call wrong? If I do RB_HALT_SYSTEM and _exit(0) after,
> the kernel panics.

What the panic shows?
-- 
Coywolf Qi Hunt
http://ahbl.org/~coywolf/

Re: halt: init exits/panic

[Nico Schottelius]

[-- Attachment #1: Type: text/plain, Size: 709 bytes --]

Sorry for the delay.

Coywolf Qi Hunt [Sun, Jul 10, 2005 at 01:09:22AM +0800]:
> On 7/9/05, Nico Schottelius <nico-kernel@schottelius.org> wrote:
> > Hello!
> > 
> > What's the 'correct behaviour' of an init system, if someone wants
> > to shutdown the system?
> > 
> > I currently do:
> > 
> > - call reboot(RB_POWER_OFF/RB_AUTOBOOT/RB_HALT_SYSTEM)
> > - _exit(0)
> > 
> > Is this exit() call wrong? If I do RB_HALT_SYSTEM and _exit(0) after,
> > the kernel panics.
> 
> What the panic shows?

"Attempted to kill init!"

--> Panic.

Nico


-- 
Latest project: cconfig (http://nico.schotteli.us/papers/linux/cconfig/)
Open Source nutures open minds and free, creative developers.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 827 bytes --]

Re: halt: init exits/panic

[Nico Schottelius]

[-- Attachment #1: Type: text/plain, Size: 883 bytes --]

Coywolf Qi Hunt [Sun, Jul 10, 2005 at 01:09:22AM +0800]:
> On 7/9/05, Nico Schottelius <nico-kernel@schottelius.org> wrote:
> > Hello!
> > 
> > What's the 'correct behaviour' of an init system, if someone wants
> > to shutdown the system?
> > 
> > I currently do:
> > 
> > - call reboot(RB_POWER_OFF/RB_AUTOBOOT/RB_HALT_SYSTEM)
> > - _exit(0)
> > 
> > Is this exit() call wrong? If I do RB_HALT_SYSTEM and _exit(0) after,
> > the kernel panics.
> 
> What the panic shows?

To be fully correct:

"Kernel panic - not syncing: Attempted to kill init" (from the last time
I tried, 2.6.13.2)

Perhaps _exit(0) is not correct for an init system?
This at least explains why it always looks like nothing is synced.

Nico

-- 
Latest project: cconfig (http://nico.schotteli.us/papers/linux/cconfig/)
Open Source nutures open minds and free, creative developers.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 827 bytes --]

Re: halt: init exits/panic

[Coywolf Qi Hunt]

On 10/4/05, Nico Schottelius <nico-kernel@schottelius.org> wrote:
> Coywolf Qi Hunt [Sun, Jul 10, 2005 at 01:09:22AM +0800]:
> > On 7/9/05, Nico Schottelius <nico-kernel@schottelius.org> wrote:
> > > Hello!
> > >
> > > What's the 'correct behaviour' of an init system, if someone wants
> > > to shutdown the system?
> > >
> > > I currently do:
> > >
> > > - call reboot(RB_POWER_OFF/RB_AUTOBOOT/RB_HALT_SYSTEM)
> > > - _exit(0)
> > >
> > > Is this exit() call wrong? If I do RB_HALT_SYSTEM and _exit(0) after,
> > > the kernel panics.
> >
> > What the panic shows?
>
> To be fully correct:
>
> "Kernel panic - not syncing: Attempted to kill init" (from the last time
> I tried, 2.6.13.2)
>
> Perhaps _exit(0) is not correct for an init system?
> This at least explains why it always looks like nothing is synced.

Right. init(8) should not call _exit() or exit(). Otherwise you'll get
that panic. It's OK for *another* process, reboot(8) to call reboot(2)
and then exit(). You should follow this way.
--
Coywolf Qi Hunt
http://sosdg.org/~coywolf/

Re: halt: init exits/panic

[Nico Schottelius]

[-- Attachment #1: Type: text/plain, Size: 1462 bytes --]

Coywolf Qi Hunt [Tue, Oct 04, 2005 at 04:12:40PM +0800]:
> On 10/4/05, Nico Schottelius <nico-kernel@schottelius.org> wrote:
> > Coywolf Qi Hunt [Sun, Jul 10, 2005 at 01:09:22AM +0800]:
> > > On 7/9/05, Nico Schottelius <nico-kernel@schottelius.org> wrote:
> > > > Hello!
> > > >
> > > > What's the 'correct behaviour' of an init system, if someone wants
> > > > to shutdown the system?
> > > >
> > > > I currently do:
> > > >
> > > > - call reboot(RB_POWER_OFF/RB_AUTOBOOT/RB_HALT_SYSTEM)
> > > > - _exit(0)
> > > >
> > > > Is this exit() call wrong? If I do RB_HALT_SYSTEM and _exit(0) after,
> > > > the kernel panics.
> > >
> > > What the panic shows?
> >
> > To be fully correct:
> >
> > "Kernel panic - not syncing: Attempted to kill init" (from the last time
> > I tried, 2.6.13.2)
> >
> > Perhaps _exit(0) is not correct for an init system?
> > This at least explains why it always looks like nothing is synced.
> 
> Right. init(8) should not call _exit() or exit(). Otherwise you'll get
> that panic. It's OK for *another* process, reboot(8) to call reboot(2)
> and then exit(). You should follow this way.

Ok, as far as I understood my init simply returns to its normal state
and hopes that the kernel halts|reboots|powers off.

Will do that' thanks for the info.

Nico

-- 
Latest project: cconfig (http://nico.schotteli.us/papers/linux/cconfig/)
Open Source nutures open minds and free, creative developers.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 827 bytes --]